mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Ravi Bangoria <ravi.bangoria@amd.com>
Subject: [RFC/PATCH 0/4] perf: Relax privilege restriction on AMD IBS (v2)
Date: Fri, 30 Aug 2024 16:29:06 -0700	[thread overview]
Message-ID: <20240830232910.1839548-1-namhyung@kernel.org> (raw)

Hello,

This is RFC v2 to allow AMD IBS to regular users on the default settings
where kernel-level profiling is disabled.  Currently AMD IBS doesn't
allow any kind of exclusion in the event attribute.  But users needs to
set attr.exclude_kernel to open an event on such an environment.

v2) changes

* add PERF_FORMAT_DROPPED
* account dropped sw events and from BPF handler
* use precise RIP from IBS record

v1) https://lore.kernel.org/lkml/20240822230816.564262-1-namhyung@kernel.org/

While IBS doesn't support hardware level privilege filters, the kernel
can allow the event and drop samples belongs to the kernel like in the
software events.

In order to count those dropped samples correctly, I'd propose a new
read format PERF_FORMAT_DROPPED same as we did for the lost samples.
With this, it can count dropped samples in the software events and
from the BPF overflow handler as well.

Let me know what you think.

Thanks,
Namhyung


Namhyung Kim (4):
  perf/core: Add PERF_FORMAT_DROPPED
  perf/core: Export perf_exclude_event()
  perf/core: Account dropped samples from BPF
  perf/x86: Relax privilege filter restriction on AMD IBS

 arch/x86/events/amd/ibs.c       | 13 +++++++++++--
 include/linux/perf_event.h      |  3 +++
 include/uapi/linux/perf_event.h |  5 ++++-
 kernel/events/core.c            | 27 ++++++++++++++++++++++-----
 4 files changed, 40 insertions(+), 8 deletions(-)

-- 
2.46.0.469.g59c65b2a67-goog


             reply	other threads:[~2024-08-30 23:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30 23:29 Namhyung Kim [this message]
2024-08-30 23:29 ` [RFC/PATCH 1/4] perf/core: Add PERF_FORMAT_DROPPED Namhyung Kim
2024-08-30 23:29 ` [RFC/PATCH 2/4] perf/core: Export perf_exclude_event() Namhyung Kim
2024-08-30 23:29 ` [RFC/PATCH 3/4] perf/core: Account dropped samples from BPF Namhyung Kim
2024-08-30 23:29 ` [RFC/PATCH 4/4] perf/x86: Relax privilege filter restriction on AMD IBS Namhyung Kim
2024-09-02  9:12   ` Peter Zijlstra
2024-09-02 17:30     ` Namhyung Kim
2024-09-03  8:54       ` Peter Zijlstra
     [not found]         ` <CAM9d7ch8fwk-o7W6KrTgtJ5n8-oVMGqzxvW_zd_hrcWFoE2AHg@mail.gmail.com>
2024-09-04  6:53           ` Ravi Bangoria
2024-09-04 11:39           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830232910.1839548-1-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®