From: "André Apitzsch via B4 Relay" <devnull+git.apitzsch.eu@kernel.org>
To: Ricardo Ribalda <ribalda@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, "André Apitzsch" <git@apitzsch.eu>
Subject: [PATCH 07/13] media: i2c: imx214: Use number of lanes from device tree
Date: Mon, 02 Sep 2024 23:54:34 +0200 [thread overview]
Message-ID: <20240902-imx214-v1-7-c96cba989315@apitzsch.eu> (raw)
In-Reply-To: <20240902-imx214-v1-0-c96cba989315@apitzsch.eu>
From: André Apitzsch <git@apitzsch.eu>
The imx214 camera is capable of either two-lane or four-lane operation.
Currently only the four-lane mode is supported, as proper pixel rates
and link frequences for the two-lane mode are unknown.
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
drivers/media/i2c/imx214.c | 37 ++++++++++++++++++++++++++++++-------
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index 4507e12dd4cd..3b422cddbdce 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
@@ -195,11 +195,13 @@ struct imx214 {
struct regulator_bulk_data supplies[IMX214_NUM_SUPPLIES];
struct gpio_desc *enable_gpio;
+
+ /* Two or Four lanes */
+ u8 lanes;
};
/*From imx214_mode_tbls.h*/
static const struct cci_reg_sequence mode_4096x2304[] = {
- { IMX214_REG_CSI_LANE_MODE, IMX214_CSI_4_LANE_MODE },
{ IMX214_REG_HDR_MODE, IMX214_HDR_MODE_OFF },
{ IMX214_REG_HDR_RES_REDUCTION, IMX214_HDR_RES_REDU_THROUGH },
{ IMX214_REG_EXPOSURE_RATIO, 1 },
@@ -272,7 +274,6 @@ static const struct cci_reg_sequence mode_4096x2304[] = {
};
static const struct cci_reg_sequence mode_1920x1080[] = {
- { IMX214_REG_CSI_LANE_MODE, IMX214_CSI_4_LANE_MODE },
{ IMX214_REG_HDR_MODE, IMX214_HDR_MODE_OFF },
{ IMX214_REG_HDR_RES_REDUCTION, IMX214_HDR_RES_REDU_THROUGH },
{ IMX214_REG_EXPOSURE_RATIO, 1 },
@@ -774,6 +775,13 @@ static int imx214_ctrls_init(struct imx214 *imx214)
return 0;
};
+static int imx214_configure_lanes(struct imx214 *imx214)
+{
+ return cci_write(imx214->regmap, IMX214_REG_CSI_LANE_MODE,
+ imx214->lanes == 2 ? IMX214_CSI_2_LANE_MODE :
+ IMX214_CSI_4_LANE_MODE, NULL);
+};
+
static int imx214_start_streaming(struct imx214 *imx214)
{
const struct imx214_mode *mode;
@@ -786,6 +794,13 @@ static int imx214_start_streaming(struct imx214 *imx214)
return ret;
}
+ /* Configure two or four Lane mode */
+ ret = imx214_configure_lanes(imx214);
+ if (ret) {
+ dev_err(imx214->dev, "%s failed to configure lanes\n", __func__);
+ return ret;
+ }
+
mode = v4l2_find_nearest_size(imx214_modes,
ARRAY_SIZE(imx214_modes), width, height,
imx214->fmt.width, imx214->fmt.height);
@@ -930,7 +945,7 @@ static int imx214_get_regulators(struct device *dev, struct imx214 *imx214)
imx214->supplies);
}
-static int imx214_parse_fwnode(struct device *dev)
+static int imx214_parse_fwnode(struct device *dev, struct imx214 *imx214)
{
struct fwnode_handle *endpoint;
struct v4l2_fwnode_endpoint bus_cfg = {
@@ -949,6 +964,14 @@ static int imx214_parse_fwnode(struct device *dev)
goto done;
}
+ /* Check the number of MIPI CSI2 data lanes */
+ if (bus_cfg.bus.mipi_csi2.num_data_lanes != 4) {
+ dev_err_probe(dev, -EINVAL,
+ "only 4 data lanes are currently supported\n");
+ goto done;
+ }
+ imx214->lanes = bus_cfg.bus.mipi_csi2.num_data_lanes;
+
for (i = 0; i < bus_cfg.nr_of_link_frequencies; i++)
if (bus_cfg.link_frequencies[i] == IMX214_DEFAULT_LINK_FREQ)
break;
@@ -973,14 +996,14 @@ static int imx214_probe(struct i2c_client *client)
struct imx214 *imx214;
int ret;
- ret = imx214_parse_fwnode(dev);
- if (ret)
- return ret;
-
imx214 = devm_kzalloc(dev, sizeof(*imx214), GFP_KERNEL);
if (!imx214)
return -ENOMEM;
+ ret = imx214_parse_fwnode(dev, imx214);
+ if (ret)
+ return ret;
+
imx214->dev = dev;
imx214->xclk = devm_clk_get(dev, NULL);
--
2.46.0
next prev parent reply other threads:[~2024-09-02 21:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 21:54 [PATCH 00/13] media: i2c: imx214: Miscellaneous cleanups and improvements André Apitzsch via B4 Relay
2024-09-02 21:54 ` [PATCH 01/13] media: i2c: imx214: Use subdev active state André Apitzsch via B4 Relay
2024-09-12 13:40 ` Ricardo Ribalda Delgado
2024-09-02 21:54 ` [PATCH 02/13] media: i2c: imx214: Remove unneeded goto André Apitzsch via B4 Relay
2024-09-12 13:40 ` Ricardo Ribalda Delgado
2024-09-02 21:54 ` [PATCH 03/13] media: i2c: imx214: Simplify with dev_err_probe() André Apitzsch via B4 Relay
2024-09-12 13:40 ` Ricardo Ribalda Delgado
2024-09-02 21:54 ` [PATCH 04/13] media: i2c: imx214: Convert to CCI register access helpers André Apitzsch via B4 Relay
2024-09-12 13:40 ` Ricardo Ribalda Delgado
2024-09-02 21:54 ` [PATCH 05/13] media: i2c: imx214: Replace register addresses with macros André Apitzsch via B4 Relay
2024-09-12 13:40 ` Ricardo Ribalda Delgado
2024-09-02 21:54 ` [PATCH 06/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays André Apitzsch via B4 Relay
2024-09-12 13:40 ` Ricardo Ribalda Delgado
2024-09-02 21:54 ` André Apitzsch via B4 Relay [this message]
2024-09-12 13:40 ` [PATCH 07/13] media: i2c: imx214: Use number of lanes from device tree Ricardo Ribalda Delgado
2024-09-02 21:54 ` [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls André Apitzsch via B4 Relay
2024-09-12 13:40 ` Ricardo Ribalda Delgado
2024-09-12 14:51 ` Dave Stevenson
2024-09-13 17:40 ` Dave Stevenson
2024-10-06 21:41 ` André
2024-10-07 17:29 ` Dave Stevenson
2024-10-12 21:45 ` André Apitzsch
2024-10-14 12:17 ` Dave Stevenson
2024-09-02 21:54 ` [PATCH 09/13] media: i2c: imx214: Extract format and crop settings André Apitzsch via B4 Relay
2024-09-12 13:40 ` Ricardo Ribalda Delgado
2024-10-06 21:28 ` André
2024-09-02 21:54 ` [PATCH 10/13] media: i2c: imx214: Implement vflip/hflip controls André Apitzsch via B4 Relay
2024-09-12 13:40 ` Ricardo Ribalda Delgado
2024-09-12 15:16 ` Dave Stevenson
2024-09-02 21:54 ` [PATCH 11/13] media: i2c: imx214: Add analogue/digital gain control André Apitzsch via B4 Relay
2024-09-12 13:39 ` Ricardo Ribalda Delgado
2024-09-02 21:54 ` [PATCH 12/13] media: i2c: imx214: Verify chip ID André Apitzsch via B4 Relay
2024-09-12 13:39 ` Ricardo Ribalda Delgado
2024-09-02 21:54 ` [PATCH 13/13] media: i2c: imx214: Add test pattern control André Apitzsch via B4 Relay
2024-09-12 13:39 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902-imx214-v1-7-c96cba989315@apitzsch.eu \
--to=devnull+git.apitzsch.eu@kernel.org \
--cc=git@apitzsch.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=ribalda@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®