mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prasanth Mantena <p-mantena@ti.com>
To: Beleswar Prasad Padhi <b-padhi@ti.com>
Cc: Nishanth Menon <nm@ti.com>, <vigneshr@ti.com>,
	<kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <u-kumar1@ti.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am69-sk: Update OSPI partitions offsets
Date: Mon, 2 Sep 2024 11:31:20 +0530	[thread overview]
Message-ID: <20240902060120.n2qj2zkbd6vakoha@uda0496754> (raw)
In-Reply-To: <451abe2a-7568-43c7-8483-242a9919684d@ti.com>

On 20:38-20240830, Beleswar Prasad Padhi wrote:
> 
> On 30-08-2024 14:52, Nishanth Menon wrote:
> > On 14:37-20240830, Beleswar Padhi wrote:
> > > OSPI NOR flash was partitioned with a size of 1 MB for the initial
> > > bootloader ("ospi.tiboot3"). On the AM69-SK board, boot failures were
> > > sometimes observed when the initial bootloader size exceeded 512 KB. To
> > Why does the boot fail when > 512MB?
> 
> 
> It is a limitation by BOOT ROM where it can not bring up the initial
> bootloader when its size exceeds 512 KB in the DFU boot mode.
> 
> > 
> > > address this, the initial bootloader image has been optimized to be
> > > smaller than 512 KB.
> > > 
> > > Therefore, limit the first OSPI partition size to 512 KB and adjust the
> > > remaining size across the subsequent partitions.
> > I am NOT a fan of redoing flash partition organization of platforms that
> > are already in production - all kinds of ecosystem messes happen as a
> > result. Alternatively - give the 512K to u-boot tispl partition and
> > leave all others as is - this will at least allow people's current env
> > to be retained.
> 
> 
> This sounds good to me. I will let Prasanth comment over this.
> 

We can align things in u-boot level rather than changing anything here.
This patch can be dropped Beleswar.

> > 
> > > Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> > > ---
> > >   arch/arm64/boot/dts/ti/k3-am69-sk.dts | 18 +++++++++---------
> > >   1 file changed, 9 insertions(+), 9 deletions(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> > > index 1e36965a1403..641236918379 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> > > +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> > > @@ -1241,27 +1241,27 @@ partitions {
> > >   			partition@0 {
> > >   				label = "ospi.tiboot3";
> > > -				reg = <0x0 0x100000>;
> > > +				reg = <0x0 0x80000>;
> > >   			};
> > > -			partition@100000 {
> > > +			partition@80000 {
> > >   				label = "ospi.tispl";
> > > -				reg = <0x100000 0x200000>;
> > > +				reg = <0x80000 0x200000>;
> > >   			};
> > > -			partition@300000 {
> > > +			partition@280000 {
> > >   				label = "ospi.u-boot";
> > > -				reg = <0x300000 0x400000>;
> > > +				reg = <0x280000 0x400000>;
> > >   			};
> > > -			partition@700000 {
> > > +			partition@680000 {
> > >   				label = "ospi.env";
> > > -				reg = <0x700000 0x40000>;
> > > +				reg = <0x680000 0x40000>;
> > >   			};
> > > -			partition@740000 {
> > > +			partition@6c0000 {
> > >   				label = "ospi.env.backup";
> > > -				reg = <0x740000 0x40000>;
> > > +				reg = <0x6c0000 0x40000>;
> > >   			};
> > >   			partition@800000 {
> > > -- 
> > > 2.34.1
> > > 

  reply	other threads:[~2024-09-02  6:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  9:07 Beleswar Padhi
2024-08-30  9:22 ` Nishanth Menon
2024-08-30 15:08   ` Beleswar Prasad Padhi
2024-09-02  6:01     ` Prasanth Mantena [this message]
2024-08-30 15:15   ` Kumar, Udit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240902060120.n2qj2zkbd6vakoha@uda0496754 \
    --to=p-mantena@ti.com \
    --cc=b-padhi@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®