mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ye Zhang <ye.zhang@rock-chips.com>
To: Ye Zhang <ye.zhang@rock-chips.com>,
	linus.walleij@linaro.org, brgl@bgdev.pl, heiko@sntech.de,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	mika.westerberg@linux.intel.com,
	andriy.shevchenko@linux.intel.com, tao.huang@rock-chips.com,
	finley.xiao@rock-chips.com, tim.chen@rock-chips.com,
	elaine.zhang@rock-chips.com
Subject: [PATCH v3 04/12] gpio: rockchip: resolve underflow issue
Date: Tue,  3 Sep 2024 15:36:41 +0800	[thread overview]
Message-ID: <20240903073649.237362-5-ye.zhang@rock-chips.com> (raw)
In-Reply-To: <20240903073649.237362-1-ye.zhang@rock-chips.com>

div_reg may be < 0 if debounce is zero, causing the unsigned int to
overflow.

Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com>
---
 drivers/gpio/gpio-rockchip.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index 6dcb8bb0d1b4..26191197cd37 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -205,8 +205,11 @@ static int rockchip_gpio_set_debounce(struct gpio_chip *gc,
 	unsigned int cur_div_reg;
 	u64 div;
 
-	if (bank->gpio_type == GPIO_TYPE_V2 && !IS_ERR(bank->db_clk)) {
+	if ((bank->gpio_type == GPIO_TYPE_V2) && !IS_ERR(bank->db_clk))
 		div_debounce_support = true;
+	else
+		div_debounce_support = false;
+	if (debounce && div_debounce_support) {
 		freq = clk_get_rate(bank->db_clk);
 		if (!freq)
 			return -EINVAL;
@@ -217,8 +220,6 @@ static int rockchip_gpio_set_debounce(struct gpio_chip *gc,
 
 		div = (u64)debounce * freq;
 		div_reg = DIV_ROUND_CLOSEST_ULL(div, 2 * USEC_PER_SEC) - 1;
-	} else {
-		div_debounce_support = false;
 	}
 
 	raw_spin_lock_irqsave(&bank->slock, flags);
-- 
2.34.1


  parent reply	other threads:[~2024-09-03 17:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03  7:36 [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver Ye Zhang
2024-09-03  7:36 ` [PATCH v3 01/12] gpio: rockchip: avoid division by zero Ye Zhang
2024-09-03 15:53   ` Andy Shevchenko
2024-09-03  7:36 ` [PATCH v3 02/12] gpio: rockchip: release reference to device node Ye Zhang
2024-09-03  7:36 ` [PATCH v3 03/12] gpio: rockchip: resolve overflow issues Ye Zhang
2024-09-03  7:36 ` Ye Zhang [this message]
2024-09-03 15:55   ` [PATCH v3 04/12] gpio: rockchip: resolve underflow issue Andy Shevchenko
2024-09-03  7:36 ` [PATCH v3 05/12] gpio: rockchip: fix debounce calculate Ye Zhang
2024-09-03  7:36 ` [PATCH v3 08/12] gpio: rockchip: explan the format of the GPIO version ID Ye Zhang
2024-09-03 16:03   ` Andy Shevchenko
2024-09-03  7:36 ` [PATCH v3 09/12] gpio: rockchip: change the GPIO version judgment logic Ye Zhang
2024-09-03 16:05   ` Andy Shevchenko
2024-09-03  7:36 ` [PATCH v3 12/12] gpio: rockchip: replace mutex_lock() with guard() Ye Zhang
2024-09-03 16:10   ` Andy Shevchenko
2024-09-03 16:52   ` Christophe JAILLET
     [not found] ` <20240903073649.237362-8-ye.zhang@rock-chips.com>
2024-09-03 15:59   ` [PATCH v3 07/12] gpio: rockchip: support 'clock-names' from dt nodes Andy Shevchenko
2024-09-03 16:00 ` [PATCH v3 00/12] gpio: rockchip: Update the GPIO driver Andy Shevchenko
     [not found] ` <20240903073649.237362-11-ye.zhang@rock-chips.com>
2024-09-03 16:07   ` [PATCH v3 10/12] gpio: rockchip: support new version gpio Andy Shevchenko
     [not found] ` <20240903073649.237362-12-ye.zhang@rock-chips.com>
2024-09-03 16:08   ` [PATCH v3 11/12] gpio: rockchip: Set input direction when request irq Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240903073649.237362-5-ye.zhang@rock-chips.com \
    --to=ye.zhang@rock-chips.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@bgdev.pl \
    --cc=elaine.zhang@rock-chips.com \
    --cc=finley.xiao@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=tao.huang@rock-chips.com \
    --cc=tim.chen@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®