From: Huan Yang <link@vivo.com>
To: vivek.kasireddy@intel.com,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com, Huan Yang <link@vivo.com>
Subject: [PATCH v5 1/7] udmabuf: pre-fault when first page fault
Date: Tue, 3 Sep 2024 16:38:06 +0800 [thread overview]
Message-ID: <20240903083818.3071759-2-link@vivo.com> (raw)
In-Reply-To: <20240903083818.3071759-1-link@vivo.com>
The current udmabuf mmap uses a page fault to populate the vma.
However, the current udmabuf has already obtained and pinned the folio
upon completion of the creation.This means that the physical memory has
already been acquired, rather than being accessed dynamically.
As a result, the page fault has lost its purpose as a demanding
page. Due to the fact that page fault requires trapping into kernel mode
and filling in when accessing the corresponding virtual address in mmap,
when creating a large size udmabuf, this represents a considerable
overhead.
This patch first the pfn into page table, and then pre-fault each pfn
into vma, when first access. Should know, if anything wrong when
pre-fault, will not report it's error, else, report when task access it
at the first time.
Suggested-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Signed-off-by: Huan Yang <link@vivo.com>
---
drivers/dma-buf/udmabuf.c | 35 +++++++++++++++++++++++++++++++++--
1 file changed, 33 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index 047c3cd2ceff..0a8c231a36e1 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -43,7 +43,8 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf)
struct vm_area_struct *vma = vmf->vma;
struct udmabuf *ubuf = vma->vm_private_data;
pgoff_t pgoff = vmf->pgoff;
- unsigned long pfn;
+ unsigned long addr, end, pfn;
+ vm_fault_t ret;
if (pgoff >= ubuf->pagecount)
return VM_FAULT_SIGBUS;
@@ -51,7 +52,37 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf)
pfn = folio_pfn(ubuf->folios[pgoff]);
pfn += ubuf->offsets[pgoff] >> PAGE_SHIFT;
- return vmf_insert_pfn(vma, vmf->address, pfn);
+ ret = vmf_insert_pfn(vma, vmf->address, pfn);
+ if (ret & VM_FAULT_ERROR)
+ return ret;
+
+ /* pre fault */
+ pgoff = vma->vm_pgoff;
+ end = vma->vm_end;
+ addr = vma->vm_start;
+
+ for (; addr < end; pgoff++, addr += PAGE_SIZE) {
+ if (addr == vmf->address)
+ continue;
+
+ if (WARN_ON(pgoff >= ubuf->pagecount))
+ break;
+
+ pfn = folio_pfn(ubuf->folios[pgoff]);
+
+ pfn += ubuf->offsets[pgoff] >> PAGE_SHIFT;
+
+ /**
+ * If something wrong, due to this vm fault success,
+ * do not report in here, report only when true access
+ * this addr.
+ * So, don't update ret here, just break.
+ */
+ if (vmf_insert_pfn(vma, addr, pfn) & VM_FAULT_ERROR)
+ break;
+ }
+
+ return ret;
}
static const struct vm_operations_struct udmabuf_vm_ops = {
--
2.45.2
next prev parent reply other threads:[~2024-09-03 8:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 8:38 [PATCH v5 0/7] udmbuf bug fix and some improvements Huan Yang
2024-09-03 8:38 ` Huan Yang [this message]
2024-09-06 8:12 ` [PATCH v5 1/7] udmabuf: pre-fault when first page fault Kasireddy, Vivek
2024-09-06 8:37 ` Huan Yang
2024-09-03 8:38 ` [PATCH v5 2/7] udmabuf: change folios array from kmalloc to kvmalloc Huan Yang
2024-09-03 8:38 ` [PATCH v5 3/7] udmabuf: fix vmap_udmabuf error page set Huan Yang
2024-09-03 8:38 ` [PATCH v5 4/7] udmabuf: udmabuf_create pin folio codestyle cleanup Huan Yang
2024-09-06 8:17 ` Kasireddy, Vivek
2024-09-06 8:30 ` Huan Yang
2024-09-09 5:03 ` Kasireddy, Vivek
2024-09-09 6:31 ` Huan Yang
2024-09-03 8:38 ` [PATCH v5 5/7] udmabuf: introduce udmabuf init and deinit helper Huan Yang
2024-09-06 8:20 ` Kasireddy, Vivek
2024-09-06 8:38 ` Huan Yang
2024-09-03 8:38 ` [PATCH v5 6/7] udmabuf: remove udmabuf_folio Huan Yang
2024-09-06 8:22 ` Kasireddy, Vivek
2024-09-06 8:39 ` Huan Yang
2024-09-03 8:38 ` [PATCH v5 7/7] udmabuf: reuse folio array when pin folios Huan Yang
2024-09-06 8:23 ` Kasireddy, Vivek
2024-09-06 8:40 ` Huan Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903083818.3071759-2-link@vivo.com \
--to=link@vivo.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=sumit.semwal@linaro.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®