From: Namhyung Kim <namhyung@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
Kyle Huey <me@kylehuey.com>,
bpf@vger.kernel.org
Subject: [PATCH 3/5] perf/core: Account dropped samples from BPF
Date: Wed, 4 Sep 2024 20:10:25 -0700 [thread overview]
Message-ID: <20240905031027.2567913-4-namhyung@kernel.org> (raw)
In-Reply-To: <20240905031027.2567913-1-namhyung@kernel.org>
Like in the software events, the BPF overflow handler can drop samples
by returning 0. Let's count the dropped samples here too.
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Song Liu <song@kernel.org>
Cc: Kyle Huey <me@kylehuey.com>
Cc: bpf@vger.kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
kernel/events/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 8250e76f63358689..ba1f6b51ea26db5b 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9808,8 +9808,10 @@ static int __perf_event_overflow(struct perf_event *event,
ret = __perf_event_account_interrupt(event, throttle);
- if (event->prog && !bpf_overflow_handler(event, data, regs))
+ if (event->prog && !bpf_overflow_handler(event, data, regs)) {
+ atomic64_inc(&event->dropped_samples);
return ret;
+ }
/*
* XXX event_limit might not quite work as expected on inherited
--
2.46.0.469.g59c65b2a67-goog
next prev parent reply other threads:[~2024-09-05 3:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 3:10 [RFC/PATCH 0/5] perf: Relax privilege restriction on AMD IBS (v3) Namhyung Kim
2024-09-05 3:10 ` [PATCH 1/5] perf/core: Add PERF_FORMAT_DROPPED Namhyung Kim
2024-09-05 3:10 ` [PATCH 2/5] perf/core: Export perf_exclude_event() Namhyung Kim
2024-09-05 3:10 ` Namhyung Kim [this message]
2024-09-05 4:17 ` [PATCH 3/5] perf/core: Account dropped samples from BPF Kyle Huey
2024-09-05 3:10 ` [PATCH 4/5] perf/powerpc: Count dropped samples in core-book3s PMU Namhyung Kim
2024-09-13 4:46 ` Madhavan Srinivasan
2024-09-05 3:10 ` [PATCH 5/5] perf/x86: Relax privilege filter restriction on AMD IBS Namhyung Kim
2024-09-23 10:33 ` Ravi Bangoria
2024-10-22 22:24 ` Namhyung Kim
2024-10-15 13:36 ` Ravi Bangoria
2024-10-22 22:25 ` Namhyung Kim
2024-09-09 18:16 ` [RFC/PATCH 0/5] perf: Relax privilege restriction on AMD IBS (v3) Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905031027.2567913-4-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=eranian@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=me@kylehuey.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®