mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lizhi Xu <lizhi.xu@windriver.com>
To: <syzbot+8811381d455e3e9ec788@syzkaller.appspotmail.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<pabeni@redhat.com>, <syzkaller-bugs@googlegroups.com>
Subject: Re: [syzbot] [net?] KASAN: slab-use-after-free Read in unix_stream_read_actor (2)
Date: Thu, 5 Sep 2024 13:25:32 +0800	[thread overview]
Message-ID: <20240905052532.533159-1-lizhi.xu@windriver.com> (raw)
In-Reply-To: <00000000000083b05a06214c9ddc@google.com>

The sock queue oob twice, the first manage_oob (in unix_stream_read_generic) peek next skb only,
and the next skb is the oob skb, so if skb is oob skb we need use manage_oob dealwith it.

#syz test

diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 0be0dcb07f7b..2821a8b5dea9 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -2918,6 +2918,14 @@ static int unix_stream_read_generic(struct unix_stream_read_state *state,
 
 		/* Mark read part of skb as used */
 		if (!(flags & MSG_PEEK)) {
+#if IS_ENABLED(CONFIG_AF_UNIX_OOB)
+			if (skb == u->oob_skb) {
+				skb = manage_oob(skb, sk, flags, copied);
+				if (!skb && copied) {
+					break;
+				}
+			}
+#endif
 			UNIXCB(skb).consumed += chunk;
 
 			sk_peek_offset_bwd(sk, chunk);

  parent reply	other threads:[~2024-09-05  5:25 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 15:13 syzbot
2024-09-04 15:32 ` Eric Dumazet
2024-09-04 17:32   ` Shoaib Rao
2024-09-05  7:35     ` Shoaib Rao
2024-09-05  8:04       ` Eric Dumazet
2024-09-05 19:06         ` Shoaib Rao
2024-09-05 19:46       ` Kuniyuki Iwashima
2024-09-05 20:15         ` Shoaib Rao
2024-09-05 20:35           ` Kuniyuki Iwashima
2024-09-05 20:48             ` Shoaib Rao
2024-09-05 21:03               ` Kuniyuki Iwashima
2024-09-06 12:37               ` Eric Dumazet
2024-09-06 16:48                 ` Shoaib Rao
2024-09-07  5:06                   ` Shoaib Rao
2024-09-07  5:39                     ` Kuniyuki Iwashima
2024-09-10  0:29                     ` Shoaib Rao
2024-09-10  0:48                       ` Kuniyuki Iwashima
2024-09-10 16:55                         ` Shoaib Rao
2024-09-10 17:57                           ` Kuniyuki Iwashima
2024-09-10 18:16                             ` Shoaib Rao
2024-09-10 18:33                               ` Kuniyuki Iwashima
2024-09-10 18:49                                 ` Shoaib Rao
2024-09-10 19:49                                   ` Kuniyuki Iwashima
2024-09-10 20:57                                     ` Shoaib Rao
2024-09-10 21:53                                       ` Kuniyuki Iwashima
2024-09-10 22:30                                         ` Shoaib Rao
2024-09-10 22:59                                           ` Kuniyuki Iwashima
2024-09-10 23:42                                             ` Shoaib Rao
2024-09-11  0:16                                               ` Kuniyuki Iwashima
2024-09-05 20:37           ` Shoaib Rao
2024-09-05 20:41             ` Shoaib Rao
2024-09-05 20:42             ` Kuniyuki Iwashima
2024-09-05  5:25 ` Lizhi Xu [this message]
2024-09-05  5:57   ` syzbot
2024-09-05  6:59   ` Kuniyuki Iwashima
2024-09-05  7:46     ` syzbot
2024-09-05 22:50 ` Hillf Danton
2024-09-05 23:17   ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240905052532.533159-1-lizhi.xu@windriver.com \
    --to=lizhi.xu@windriver.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+8811381d455e3e9ec788@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®