From: Paolo Bonzini <pbonzini@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kvm@vger.kernel.org, Sean Christopherson <seanjc@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Joel Fernandes <joel@joelfernandes.org>,
Suleiman Souhlal <ssouhlal@freebsd.org>,
Vineeth Pillai <vineeth@bitbyteword.org>,
Borislav Petkov <bp@alien8.de>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [RFC][PATCH] KVM: Remove HIGH_RES_TIMERS dependency
Date: Thu, 5 Sep 2024 12:19:27 -0400 [thread overview]
Message-ID: <20240905161926.186090-2-pbonzini@redhat.com> (raw)
In-Reply-To: <20240821095127.45d17b19@gandalf.local.home>
> Commit 92b5265d38f6a ("KVM: Depend on HIGH_RES_TIMERS") added a dependency
> to high resolution timers with the comment:
>
> KVM lapic timer and tsc deadline timer based on hrtimer,
> setting a leftmost node to rb tree and then do hrtimer reprogram.
> If hrtimer not configured as high resolution, hrtimer_enqueue_reprogram
> do nothing and then make kvm lapic timer and tsc deadline timer fail.
>
> That was back in 2012, where hrtimer_start_range_ns() would do the
> reprogramming with hrtimer_enqueue_reprogram(). But as that was a nop with
> high resolution timers disabled, this did not work. But a lot has changed
> in the last 12 years.
>
> For example, commit 49a2a07514a3a ("hrtimer: Kick lowres dynticks targets on
> timer enqueue") modifies __hrtimer_start_range_ns() to work with low res
> timers. There's been lots of other changes that make low res work.
>
> I added this change to my main server that runs all my VMs (my mail
> server, my web server, my ssh server) and disabled HIGH_RES_TIMERS and the
> system has been running just fine for over a month.
>
> ChromeOS has tested this before as well, and it hasn't seen any issues with
> running KVM with high res timers disabled.
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Queued, thanks.
Paolo
prev parent reply other threads:[~2024-09-05 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 13:51 Steven Rostedt
2024-08-28 19:34 ` Sean Christopherson
2024-09-04 7:35 ` Suleiman Souhlal
2024-09-04 13:25 ` Paolo Bonzini
2024-09-05 7:23 ` Suleiman Souhlal
2024-09-05 16:19 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905161926.186090-2-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=anna-maria@linutronix.de \
--cc=bp@alien8.de \
--cc=fweisbec@gmail.com \
--cc=joel@joelfernandes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=ssouhlal@freebsd.org \
--cc=tglx@linutronix.de \
--cc=vineeth@bitbyteword.org \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®