From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A940A1B85D5; Fri, 6 Sep 2024 19:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725650606; cv=none; b=PBD8p6BKSkXR1ktfUBQI/kM5rqMs8T3u4v5Q9kVN1pfFUAa79AI7bP6UyGUezl/eR4qkGXMzNM43/fSBhO7YfAXHqSdmR+UiSBw8z7u8bzsGPi2vxsybLPX0c9hHLb1DdswtYnSLcDZw3HllNUkq51gieSTh15VgcOodfbaSmKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725650606; c=relaxed/simple; bh=/n96Kto0JZug0XlU6wzixOGIsRQmVNlzwkTH7ThriiM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gjlSO/ur/artC2ydh4z500qb9wfrJBJTY3DFZmylfjyw6W5AJoh2eyKWd/52250142tatr/2KruXnAYS81BIRGXyDAd5CMEZAeBJz6RC4AVeAz4omTH3lL7xbbEkchskd9VfkaG7PzRCS+7QbbqnMYj76GGwqKrqwESi4ykpk78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k/2tmJK0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k/2tmJK0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCB13C4CEC4; Fri, 6 Sep 2024 19:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725650606; bh=/n96Kto0JZug0XlU6wzixOGIsRQmVNlzwkTH7ThriiM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k/2tmJK0ZIGo88O1HE1+DTpj1x8V/ZUa4loaN18gbxhwGafooIAqA0snN6lcl3BnD tHGE/I27eRUfMvwbykJyJz4R5y41Et/JERKNFdNNQwHmMIeHki8cANYcXazZnf5bFQ AE9wie939zT1oHWDiUVa8OHBh0oQyXZ8xyRTob6KHrC7StGbvtaImoy5BYCRh4/U5I 9eTWosx5C2OjaGnyRbPv2SM6zvdG01EPnLVnA89qjv14/y1d9VyD33syg1md8p3YOm xPuHIAUAEc5KRrU3fHSddFxZOPySfzxiUImK1OTpqXdwpxgdHvplkDXMmvWA71/DcN rKlzHB0YmkzPg== Date: Fri, 6 Sep 2024 12:23:23 -0700 From: Nathan Chancellor To: Mark Brown Cc: Alexandre Mergnat , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Lee Jones , Flora Fu , Jaroslav Kysela , Takashi Iwai , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Catalin Marinas , Will Deacon , Rob Herring , Krzysztof Kozlowski , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Krzysztof Kozlowski , Nicolas Belin Subject: Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board Message-ID: <20240906192323.GA3160860@thelio-3990X> References: <20240226-audio-i350-v7-0-6518d953a141@baylibre.com> <172544860860.19172.7052813450885034844.b4-ty@kernel.org> <20240906180348.GA1239602@thelio-3990X> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 06, 2024 at 07:27:01PM +0100, Mark Brown wrote: > Are these just warnings introduced by recent versions of the toolchains? > These commits passed an x86 allmodconfig with GCC 12 at each step (I did > catch one warning there with another patch in the series that didn't get > applied) and 0day didn't say anything at any point. Not sure, I did not look too hard. At cursory glance, I am not sure x86 allmodconfig would catch these, as this code depends on ARCH_MEDIATEK (not COMPILE_TEST), which only exists for arm and arm64. > > Clang 19: > > That's relatively modern, though some of the warnings don't look > particularly new and exciting. Fair although I still see some of them on old versions too: https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/10738441894 > > sound/soc/mediatek/mt8365/mt8365-dai-adda.c:93:8: error: implicit conversion from 'unsigned long' to 'unsigned int' changes value from 18446744073709551614 to 4294967294 [-Werror,-Wconstant-conversion] > > 91 | regmap_update_bits(afe->regmap, AFE_ADDA_UL_DL_CON0, > > | ~~~~~~~~~~~~~~~~~~ > > 92 | AFE_ADDA_UL_DL_ADDA_AFE_ON, > > 93 | ~AFE_ADDA_UL_DL_ADDA_AFE_ON); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 1 error generated. > > That's a bit surprising, regmap_update_bits() takes an unsigned long? I > suspect the constants need to be defined as unsigned. Does it? I see it taking 'unsigned int' for all of its parameters. $ sed -n '1242,1250p' include/linux/regmap.h int regmap_update_bits_base(struct regmap *map, unsigned int reg, unsigned int mask, unsigned int val, bool *change, bool async, bool force); static inline int regmap_update_bits(struct regmap *map, unsigned int reg, unsigned int mask, unsigned int val) { return regmap_update_bits_base(map, reg, mask, val, NULL, false, false); } Cheers, Nathan