mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH 03/16] Staging: rtl8192e: Rename variable SignalStrength
Date: Sun,  8 Sep 2024 12:26:20 -0700	[thread overview]
Message-ID: <20240908192633.94144-4-tdavies@darkphysics.net> (raw)
In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net>

Rename variable SignalStrength to signal_strength
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 ++++----
 drivers/staging/rtl8192e/rtllib.h              | 4 ++--
 drivers/staging/rtl8192e/rtllib_rx.c           | 8 ++++----
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index f5a46754d65f..a8bb2d3f7e9d 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1319,12 +1319,12 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
 	}
 
 	if (is_cck_rate) {
-		pstats->SignalStrength = precord_stats->SignalStrength =
+		pstats->signal_strength = precord_stats->signal_strength =
 					 _rtl92e_signal_scale_mapping(priv, (long)pwdb_all);
 
 	} else {
 		if (rf_rx_num != 0)
-			pstats->SignalStrength = precord_stats->SignalStrength =
+			pstats->signal_strength = precord_stats->signal_strength =
 					 _rtl92e_signal_scale_mapping(priv,
 					 (long)(total_rssi /= rf_rx_num));
 	}
@@ -1352,10 +1352,10 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
 		last_rssi = priv->stats.slide_signal_strength[slide_rssi_index];
 		priv->stats.slide_rssi_total -= last_rssi;
 	}
-	priv->stats.slide_rssi_total += prev_st->SignalStrength;
+	priv->stats.slide_rssi_total += prev_st->signal_strength;
 
 	priv->stats.slide_signal_strength[slide_rssi_index++] =
-					 prev_st->SignalStrength;
+					 prev_st->signal_strength;
 	if (slide_rssi_index >= PHY_RSSI_SLID_WIN_MAX)
 		slide_rssi_index = 0;
 
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index b033e8345b0a..9f812cedd1b3 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -466,7 +466,7 @@ struct rtllib_rx_stats {
 	u16 Length;
 	u8  SignalQuality;
 	s32 RecvSignalPower;
-	u8  SignalStrength;
+	u8  signal_strength;
 	u16 hw_error:1;
 	u16 bCRC:1;
 	u16 bICV:1;
@@ -951,7 +951,7 @@ struct rtllib_network {
 	bool unknown_cap_exist;
 	bool	berp_info_valid;
 	bool buseprotection;
-	u8 SignalStrength;
+	u8 signal_strength;
 	u8 RSSI;
 	struct list_head list;
 };
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 86beac9dd3a5..8fe224a83dd6 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -2177,8 +2177,8 @@ static inline int rtllib_network_init(
 	network->marvell_cap_exist = false;
 	network->airgo_cap_exist = false;
 	network->turbo_enable = 0;
-	network->SignalStrength = stats->SignalStrength;
-	network->RSSI = stats->SignalStrength;
+	network->signal_strength = stats->signal_strength;
+	network->RSSI = stats->signal_strength;
 	network->country_ie_len = 0;
 	memset(network->country_ie_buf, 0, MAX_IE_LEN);
 	ht_initialize_bss_desc(&network->bssht);
@@ -2215,7 +2215,7 @@ static inline int rtllib_network_init(
 	}
 	if (rtllib_is_empty_essid(network->ssid, network->ssid_len))
 		network->flags |= NETWORK_EMPTY_ESSID;
-	stats->signal = 30 + (stats->SignalStrength * 70) / 100;
+	stats->signal = 30 + (stats->signal_strength * 70) / 100;
 	stats->noise = rtllib_translate_todbm((u8)(100 - stats->signal)) - 25;
 
 	memcpy(&network->stats, stats, sizeof(network->stats));
@@ -2334,7 +2334,7 @@ static inline void update_network(struct rtllib_device *ieee,
 	   src->wmm_param[3].ac_aci_acm_aifsn)
 		memcpy(dst->wmm_param, src->wmm_param, WME_AC_PRAM_LEN);
 
-	dst->SignalStrength = src->SignalStrength;
+	dst->signal_strength = src->signal_strength;
 	dst->RSSI = src->RSSI;
 	dst->turbo_enable = src->turbo_enable;
 
-- 
2.30.2


  parent reply	other threads:[~2024-09-08 19:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
2024-09-08 19:26 ` [PATCH 01/16] Staging: rtl8192e: Rename variable pReorderEntry Tree Davies
2024-09-08 19:26 ` [PATCH 02/16] Staging: rtl8192e: Rename variable SeqNum Tree Davies
2024-09-08 19:26 ` Tree Davies [this message]
2024-09-08 19:26 ` [PATCH 04/16] Staging: rtl8192e: Rename variable pFrame Tree Davies
2024-09-08 19:26 ` [PATCH 05/16] Staging: rtl8192e: Rename variable bPacketToSelf Tree Davies
2024-09-08 19:26 ` [PATCH 06/16] Staging: rtl8192e: Rename variable Para1 Tree Davies
2024-09-08 19:26 ` [PATCH 07/16] Staging: rtl8192e: Rename variable Para2 Tree Davies
2024-09-08 19:26 ` [PATCH 08/16] Staging: rtl8192e: Rename variable ScanOperationBackupHandler Tree Davies
2024-09-08 19:26 ` [PATCH 09/16] Staging: rtl8192e: Rename variable Operation Tree Davies
2024-09-08 19:26 ` [PATCH 10/16] Staging: rtl8192e: Rename variable bAssoc Tree Davies
2024-09-08 19:26 ` [PATCH 11/16] Staging: rtl8192e: Rename variable SignalQuality Tree Davies
2024-09-08 19:26 ` [PATCH 12/16] Staging: rtl8192e: Rename variable isEncrypt Tree Davies
2024-09-08 19:26 ` [PATCH 13/16] Staging: rtl8192e: Rename variable nStuckCount Tree Davies
2024-09-08 19:26 ` [PATCH 14/16] Staging: rtl8192e: Rename variable bAddNewTs Tree Davies
2024-09-08 19:26 ` [PATCH 15/16] Staging: rtl8192e: Rename variable RxBufShift Tree Davies
2024-09-08 19:26 ` [PATCH 16/16] Staging: rtl8192e: Rename variable RxDrvInfoSize Tree Davies
2024-09-08 20:44 ` [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240908192633.94144-4-tdavies@darkphysics.net \
    --to=tdavies@darkphysics.net \
    --cc=anjan@momi.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®