From: Zijun Hu <zijun_hu@icloud.com>
To: Russell King <linux@armlinux.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Saravana Kannan <saravanak@google.com>,
Isaac Manjarres <isaacmanjarres@google.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Zijun Hu <zijun_hu@icloud.com>,
linux-kernel@vger.kernel.org, Zijun Hu <quic_zijuhu@quicinc.com>
Subject: [PATCH RFC 2/3] amba: bus: Move empty @amba_proxy_drv's definition to the front
Date: Mon, 09 Sep 2024 07:37:33 +0800 [thread overview]
Message-ID: <20240909-fix_amba-v1-2-4658eed26906@quicinc.com> (raw)
In-Reply-To: <20240909-fix_amba-v1-0-4658eed26906@quicinc.com>
From: Zijun Hu <quic_zijuhu@quicinc.com>
Move empty @amba_proxy_drv's definition to the front in preparation for
referring to it without forward declaration.
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
drivers/amba/bus.c | 72 +++++++++++++++++++++++++++---------------------------
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index cc3c57f83798..033d626aff46 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -205,6 +205,42 @@ static int amba_read_periphid(struct amba_device *dev)
return ret;
}
+static int amba_proxy_probe(struct amba_device *adev,
+ const struct amba_id *id)
+{
+ WARN(1, "Stub driver should never match any device.\n");
+ return -ENODEV;
+}
+
+static const struct amba_id amba_stub_drv_ids[] = {
+ { 0, 0 },
+};
+
+static struct amba_driver amba_proxy_drv = {
+ .drv = {
+ .name = "amba-proxy",
+ },
+ .probe = amba_proxy_probe,
+ .id_table = amba_stub_drv_ids,
+};
+
+static int __init amba_stub_drv_init(void)
+{
+ if (!IS_ENABLED(CONFIG_MODULES))
+ return 0;
+
+ /*
+ * The amba_match() function will get called only if there is at least
+ * one amba driver registered. If all amba drivers are modules and are
+ * only loaded based on uevents, then we'll hit a chicken-and-egg
+ * situation where amba_match() is waiting on drivers and drivers are
+ * waiting on amba_match(). So, register a stub driver to make sure
+ * amba_match() is called even if no amba driver has been registered.
+ */
+ return __amba_driver_register(&amba_proxy_drv, NULL);
+}
+late_initcall_sync(amba_stub_drv_init);
+
static int amba_match(struct device *dev, const struct device_driver *drv)
{
struct amba_device *pcdev = to_amba_device(dev);
@@ -456,42 +492,6 @@ static int __init amba_init(void)
postcore_initcall(amba_init);
-static int amba_proxy_probe(struct amba_device *adev,
- const struct amba_id *id)
-{
- WARN(1, "Stub driver should never match any device.\n");
- return -ENODEV;
-}
-
-static const struct amba_id amba_stub_drv_ids[] = {
- { 0, 0 },
-};
-
-static struct amba_driver amba_proxy_drv = {
- .drv = {
- .name = "amba-proxy",
- },
- .probe = amba_proxy_probe,
- .id_table = amba_stub_drv_ids,
-};
-
-static int __init amba_stub_drv_init(void)
-{
- if (!IS_ENABLED(CONFIG_MODULES))
- return 0;
-
- /*
- * The amba_match() function will get called only if there is at least
- * one amba driver registered. If all amba drivers are modules and are
- * only loaded based on uevents, then we'll hit a chicken-and-egg
- * situation where amba_match() is waiting on drivers and drivers are
- * waiting on amba_match(). So, register a stub driver to make sure
- * amba_match() is called even if no amba driver has been registered.
- */
- return __amba_driver_register(&amba_proxy_drv, NULL);
-}
-late_initcall_sync(amba_stub_drv_init);
-
/**
* __amba_driver_register - register an AMBA device driver
* @drv: amba device driver structure
--
2.34.1
next prev parent reply other threads:[~2024-09-08 23:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 23:37 [PATCH RFC 0/3] amba: bus: Move reading periphid operation from amba_match() to amba_probe() Zijun Hu
2024-09-08 23:37 ` [PATCH RFC 1/3] amba: bus: Warn on adding an AMBA device without valid periphid Zijun Hu
2024-09-08 23:37 ` Zijun Hu [this message]
2024-09-08 23:37 ` [PATCH RFC 3/3] amba: bus: Move reading periphid operation from amba_match() to amba_probe() Zijun Hu
2024-09-08 23:51 ` Zijun Hu
2024-09-09 7:24 ` [PATCH RFC 0/3] " Saravana Kannan
2024-09-10 12:17 ` Zijun Hu
2024-09-10 16:27 ` Saravana Kannan
2024-09-11 12:50 ` Zijun Hu
2024-10-03 1:49 ` Saravana Kannan
2024-10-10 13:10 ` Zijun Hu
2024-09-17 9:52 ` Russell King (Oracle)
2024-09-17 11:02 ` Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909-fix_amba-v1-2-4658eed26906@quicinc.com \
--to=zijun_hu@icloud.com \
--cc=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=isaacmanjarres@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=quic_zijuhu@quicinc.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®