From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
michael.christie@oracle.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: [PATCH v1 2/7] vhost: Add kthread support in function vhost_worker_queue()
Date: Mon, 9 Sep 2024 09:33:41 +0800 [thread overview]
Message-ID: <20240909013531.1243525-3-lulu@redhat.com> (raw)
In-Reply-To: <20240909013531.1243525-1-lulu@redhat.com>
Added back the previously removed function vhost_worker_queue() and
renamed it to vhost_worker_queue_khtread(). The new vhost_worker_queue()
will select the different mode based on the value of the parameter.
The old function vhost_work_queue() was change to support task in
commit 6e890c5d5021 ('vhost: use vhost_tasks for worker threads')
changed in
commit f9010dbdc ('fork, vhost: Use CLONE_THREAD to fix freezer/ps regression')
and also was change the name of function to vhost_worker_queue() in
commit 0921dddcb5 (vhost: take worker or vq instead of dev for queueing)
Signed-off-by: Cindy Lu <lulu@redhat.com>
---
drivers/vhost/vhost.c | 30 ++++++++++++++++++++++++++++--
drivers/vhost/vhost.h | 1 +
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index be43181af659..6198c165ab15 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -236,8 +236,8 @@ void vhost_poll_stop(struct vhost_poll *poll)
}
EXPORT_SYMBOL_GPL(vhost_poll_stop);
-static void vhost_worker_queue(struct vhost_worker *worker,
- struct vhost_work *work)
+static void vhost_worker_queue_task(struct vhost_worker *worker,
+ struct vhost_work *work)
{
if (!test_and_set_bit(VHOST_WORK_QUEUED, &work->flags)) {
/* We can only add the work to the list after we're
@@ -249,6 +249,32 @@ static void vhost_worker_queue(struct vhost_worker *worker,
}
}
+static void vhost_work_queue_kthread(struct vhost_worker *worker,
+ struct vhost_work *work)
+{
+ if (!worker)
+ return;
+
+ if (!test_and_set_bit(VHOST_WORK_QUEUED, &work->flags)) {
+ /* We can only add the work to the list after we're
+ * sure it was not in the list.
+ * test_and_set_bit() implies a memory barrier.
+ */
+ llist_add(&work->node, &worker->work_list);
+
+ wake_up_process(worker->task);
+ }
+}
+
+static void vhost_worker_queue(struct vhost_worker *worker,
+ struct vhost_work *work)
+{
+ if (use_kthread) {
+ vhost_work_queue_kthread(worker, work);
+ } else {
+ vhost_worker_queue_task(worker, work);
+ }
+}
bool vhost_vq_work_queue(struct vhost_virtqueue *vq, struct vhost_work *work)
{
struct vhost_worker *worker;
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index bb75a292d50c..c7f126fd09e8 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
@@ -27,6 +27,7 @@ struct vhost_work {
};
struct vhost_worker {
+ struct task_struct *task;
struct vhost_task *vtsk;
struct vhost_dev *dev;
/* Used to serialize device wide flushing with worker swapping. */
--
2.45.0
next prev parent reply other threads:[~2024-09-09 1:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 1:33 [PATCH v1 0/7] vhost: Add support of kthread API Cindy Lu
2024-09-09 1:33 ` [PATCH v1 1/7] vhost: Add a new module_param for enable kthread Cindy Lu
2024-09-09 1:33 ` Cindy Lu [this message]
2024-09-11 11:13 ` [PATCH v1 2/7] vhost: Add kthread support in function vhost_worker_queue() kernel test robot
2024-09-09 1:33 ` [PATCH v1 3/7] vhost: Add kthread support in function vhost_workers_free() Cindy Lu
2024-09-09 1:33 ` [PATCH v1 4/7] vhost: Add the vhost_worker to support kthread Cindy Lu
2024-09-09 1:33 ` [PATCH v1 5/7] vhost: Add the cgroup related function Cindy Lu
2024-09-09 1:33 ` [PATCH v1 6/7] vhost: Add kthread support in function vhost_worker_create Cindy Lu
2024-09-11 12:46 ` kernel test robot
2024-09-09 1:33 ` [PATCH v1 7/7] vhost: Add new UAPI to support change to task mode Cindy Lu
2024-09-11 14:10 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909013531.1243525-3-lulu@redhat.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®