From: "Ivan T. Ivanov" <iivanov@suse.de>
To: Corey Minyard <corey@minyard.net>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi:ssif: Improve detecting during probing
Date: Tue, 10 Sep 2024 13:25:31 +0300 [thread overview]
Message-ID: <20240910102531.grjtn2rdmagcgphb@localhost.localdomain> (raw)
In-Reply-To: <ZsU9SRlQgzQn8bDs@mail.minyard.net>
Hi Corey,
On 08-20 20:05, Corey Minyard wrote:
>
> If an IPMI SSIF device is probed and there is something there, but
> probably not an actual BMC, the code would just issue a lot of errors
> before it failed. We kind of need these errors to help with certain
> issues, and some of the failure reports are non-fatal.
>
> However, a get device id command should alway work. If that fails,
> nothing else is going to work and it's a pretty good indication that
> there's no valid BMC there. So issue and check that command and bail
> if it fails.
>
> Reported-by: Ivan T. Ivanov <iivanov@suse.de>
> Signed-off-by: Corey Minyard <corey@minyard.net>
> ---
> drivers/char/ipmi/ipmi_ssif.c | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
Do you plan to merge this fix?
Regards,
Ivan
next prev parent reply other threads:[~2024-09-10 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 6:54 [PATCH] ipmi:ssif: Exit early when there is a SMBus error Ivan T. Ivanov
2024-08-16 18:04 ` Corey Minyard
2024-08-18 9:27 ` Ivan T. Ivanov
2024-08-20 10:20 ` Ivan T. Ivanov
2024-08-20 15:31 ` Corey Minyard
2024-08-20 15:42 ` Ivan T. Ivanov
2024-08-21 1:05 ` [PATCH] ipmi:ssif: Improve detecting during probing Corey Minyard
2024-08-22 7:22 ` Ivan T. Ivanov
2024-08-22 14:40 ` Corey Minyard
2024-08-26 11:31 ` Ivan T. Ivanov
2024-09-10 10:25 ` Ivan T. Ivanov [this message]
2024-09-10 11:30 ` Corey Minyard
2024-09-10 12:05 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910102531.grjtn2rdmagcgphb@localhost.localdomain \
--to=iivanov@suse.de \
--cc=corey@minyard.net \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®