From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B83A3C2F for ; Tue, 10 Sep 2024 17:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725987674; cv=none; b=NM8MO0bz5ZExSSR91Iaaiitz9kGKxwmUaDqYoqtVwmjqafx+cWqaKRm4bxORh+0pmwFniRtYZ+b/5yVwtjF3jUHgBkwV3wI2Y7AKDmNHigyyx+MQqzU/1fmV+QLLKwBLDwItuSDUfIwdQLUW7l+rerAFAay9bU3brjE+5fB4Y6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725987674; c=relaxed/simple; bh=HIYNvnAdgW89EfSpETD3OtBL5KxgpvDe1ZV5+r8iyVM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OSpsXOEcyh+W8mgJ8FeUewX0KnexYd5pb7ZfAyayTIXWibHdtieioAj8rC8bgzKdndFSWSIvxm/mHepEjjUOaZjutH+tnlR8vB8W7I/BcWfrTRfz8TqYxGGNAFSX2K3/vjzH+lRiVJf07h3iTZbN02a/a4WKGNJkbpzNHlPR2+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nEi2hqXy; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nEi2hqXy" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-205659dc63aso57753755ad.1 for ; Tue, 10 Sep 2024 10:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725987673; x=1726592473; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=pBskbk3QBU0YMtrU99WpBguxflCzi8adsZB8njQ7nhU=; b=nEi2hqXy4bFv+4EXH00305ZEe9khGaOb0o7r5k1e7907EtjPorp37Sg6idERwbjLrt BaxF3rwNLBB1KcmCg26EowKEPFX+r1J1NJJCiYxlaWaHZARxdOHh2gdslX7eZNDJFvvi aokzwO3fQIkZ2GoLtPmekyEkD7ZGP2ycs+qO6jcnPLsCF7lR1RLO3UxKaGpfSsMcyXX/ 0C2V//Gn5iFPWG1Gzpqhb1HAoMV3wMGV6RU0K4NvAJu5t+ZKbgWAoBFupFhnwTsR/Kk8 vpJFZjcYN157HT82zDoi+sEA4to/H+Y6rWxUNRgApGzdvhgxN6kn7PcKqPrUoVCBDX+L ft/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725987673; x=1726592473; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pBskbk3QBU0YMtrU99WpBguxflCzi8adsZB8njQ7nhU=; b=UD87SYtwCjqTjzINzu7DQvUQVSDc+Q4Ij39RLI64iL4GY1wTQy9kcQ9319Dk+M71fs tpq6LemIOgES/Ry0Yl+OA88de6fbpCbL50K+WRApZW4PIpVKZGsVkoqMUatiWrNvO29q oW17rydwQ3wBW0wc2JJU8HiNPnadM7eEfvjiGSb1RDLotUSJAy3m1io9nYxDsMQCm4BV JEoNV+JxwkF+SF0JeAH+XSU3A+oJH3fpAwcA+q0LK0+UKh/P223ql9dQc7+pO29PBbX4 QtV776f8ismWk/8S5NerbJ5ZEUM0gO/Gqoz/wQR/iPvZmGDFrc1X4VVom1XmxgLV5Dkx LjFA== X-Forwarded-Encrypted: i=1; AJvYcCW2y8k5LQ2x4vp5uYMH7ty6lv0ESq8Ca7oPnuTTfC9l8ivvlxcdtR6A2+PzbbkLJQrwCl2LJttQ8qwdtdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzMoncb/rU5GIrqT0OGXjR1rjCRIV63NTjWkFtBFugz3I5X5NYZ OHuqrfkskcDM3WAsXUFuKnBa5VLfSbCffIUJdYBO9TDtmKk2eUUThwUChA3IFw== X-Google-Smtp-Source: AGHT+IF/raqp+DCJypfwe5V7+Q+7qT8bMOaTzbFGyeYWrZCI1/k/X6tIvkrcWMVdJdlQehGHErlM4Q== X-Received: by 2002:a17:902:d2c9:b0:207:73f:59f3 with SMTP id d9443c01a7336-2074c681cecmr18549225ad.32.1725987672621; Tue, 10 Sep 2024 10:01:12 -0700 (PDT) Received: from thinkpad ([120.60.128.228]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710f1f469sm50762155ad.223.2024.09.10.10.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 10:01:12 -0700 (PDT) Date: Tue, 10 Sep 2024 22:30:52 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jingoo Han , Chuanhua Lei , Marek Vasut , Yoshihiro Shimoda , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, abel.vesa@linaro.org, johan+linaro@kernel.org, Shashank Babu Chinta Venkata Subject: Re: [PATCH v6 3/4] PCI: qcom: Add equalization settings for 16.0 GT/s Message-ID: <20240910170052.qorc7hedfy4oqzgt@thinkpad> References: <20240904-pci-qcom-gen4-stability-v6-0-ec39f7ae3f62@linaro.org> <20240904-pci-qcom-gen4-stability-v6-3-ec39f7ae3f62@linaro.org> <20240905152742.4llkcjvvu3klmo6j@thinkpad> <20240905173437.hm3hegv5zolaj7gj@thinkpad> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Sep 06, 2024 at 08:49:03AM +0200, Johan Hovold wrote: > On Thu, Sep 05, 2024 at 11:04:37PM +0530, Manivannan Sadhasivam wrote: > > On Thu, Sep 05, 2024 at 06:27:36PM +0200, Johan Hovold wrote: > > > On Thu, Sep 05, 2024 at 08:57:42PM +0530, Manivannan Sadhasivam wrote: > > > > > Perhaps we can just get rid of the Kconfig entry and build it by default for > > > > both RC and EP drivers? I don't see a value in building it as a separate module. > > > > And we may also move more common code in the future. > > > > > > It is already built by default for both drivers. I'm not sure what > > > you're suggesting here. > > > > Right now it is selected by both drivers using a Kconfig symbol. But I'm > > thinking of building it by default as below: > > > > -obj-$(CONFIG_PCIE_QCOM) += pcie-qcom.o > > -obj-$(CONFIG_PCIE_QCOM_EP) += pcie-qcom-ep.o > > +obj-$(CONFIG_PCIE_QCOM) += pcie-qcom.o pcie-qcom-common.o > > +obj-$(CONFIG_PCIE_QCOM_EP) += pcie-qcom-ep.o pcie-qcom-common.o > > > > A separate Kconfig symbol is not really needed here as this file contains common > > code required by both the drivers. > > But the separate Kconfig symbol will only be enabled via either PCI > driver's option (e.g. can't be enabled on its own). > True. But since the common file is required by both drivers, I thought of just building it by default. But looking at your below reply, it won't be possible. > I'm also not sure if the above works if you build one driver as a module > and the other into the kernel (yes, I still intend to resubmit my patch > for making the rc driver modular). > Hmm, I thought you dropped that patch ;) Anyway, if that happens, it will be a problem. I'll keep it as it is. - Mani -- மணிவண்ணன் சதாசிவம்