From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE311A2869; Tue, 10 Sep 2024 17:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725989540; cv=none; b=B/MjPKWEInGt5bPvaw/1nn+yykRDqUDzuIB94qV/KLLghXz2h3tR+u3WD3X5ruVwk2MsPY0WeJUbAlSnmAVIODYsQq06nfuyDLlQCS5o1pcTyspsE6BECKzQ7x2cRaWfPl8SVS2HbFB+j+DJ7Yoi/Tl92j0vRY48C4r4KrzP6Cs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725989540; c=relaxed/simple; bh=nFv9w2O9vQJ50kDWg5FBeGKFXiHA9d13wr91m8laEKU=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jncjob7ki+7amxeQ4tteBGrLHvXR6qvCodMlUhLQYiDK/o+1cCUPNQmrTT3nydoYTpOVpkJxQHpqdVfewg4IHS4cCIXQAViRjdyHVQwdf32MIY6Y9Ad09/Yg2NW6jYAX6R8GOkPshCILKhHJN5OUKARShHwzpw0TB5AfAfd9YVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=muuZ7fOS; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="muuZ7fOS" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48AGx2pQ002705; Tue, 10 Sep 2024 19:31:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=selector1; bh=6ws8DZHi3fGww8Oc+C3Gn/62 lB+b6V2NTWERTjva7Os=; b=muuZ7fOSWhUxNay+jXU8tahr27iS4oGdalKlgCAv GFP2EyAP7u4ESgKDDy9Fe4wj+XaqCRfQv3gJt4+83wKVkbpEZIImPS24USD4tude PlZK35AjO++fSCYpVvga43B0RJLa+5Z9UEs+7vSwZyqkT4acTYx3vMoi4Tr6oGeU u7D7NDhWzROllyPFxqClxSIZKcgBBm3melPjWTmyZnYthVfM+Itv9ZOj+jaBCRPm QwIXAcvyll/EPRN1EXnAfXhOAJC+083UCH+bFJ/9PPigTu49fOJu6Na/e1UsoyNI Y7uVbmL04DSgaPvQdIGAgEYo/dvK6f0pz5v5VcwjtX3AJw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 41h1sgafs4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Sep 2024 19:31:43 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id BDC9240049; Tue, 10 Sep 2024 19:30:23 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 3E84527D535; Tue, 10 Sep 2024 19:26:54 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.129.178.213) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 10 Sep 2024 19:26:53 +0200 Date: Tue, 10 Sep 2024 19:26:52 +0200 From: Alain Volmat To: Ma Ke CC: , , , , , , , , , , , Subject: Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check Message-ID: <20240910172652.GB3518200@gnbcxd0016.gnb.st.com> References: <20240909063359.1197065-1-make24@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240909063359.1197065-1-make24@iscas.ac.cn> X-Disclaimer: ce message est personnel / this message is private X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 Hi, Thank you for your patch. Acked-by: Alain Volmat Regards, Alain On Mon, Sep 09, 2024 at 02:33:59PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the failure. > > Cc: stable@vger.kernel.org > Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes") > Signed-off-by: Ma Ke > --- > drivers/gpu/drm/sti/sti_gdp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c > index 43c72c2604a0..f046f5f7ad25 100644 > --- a/drivers/gpu/drm/sti/sti_gdp.c > +++ b/drivers/gpu/drm/sti/sti_gdp.c > @@ -638,6 +638,9 @@ static int sti_gdp_atomic_check(struct drm_plane *drm_plane, > > mixer = to_sti_mixer(crtc); > crtc_state = drm_atomic_get_crtc_state(state, crtc); > + if (IS_ERR(crtc_state)) > + return PTR_ERR(crtc_state); > + > mode = &crtc_state->mode; > dst_x = new_plane_state->crtc_x; > dst_y = new_plane_state->crtc_y; > -- > 2.25.1 >