mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: lanzano.alex@gmail.com
Cc: Jonathan.Cameron@huawei.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, jagathjog1996@gmail.com,
	jic23@kernel.org, krzk+dt@kernel.org, lars@metafoo.de,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	nuno.sa@analog.com, ramona.bolboaca13@gmail.com, robh@kernel.org,
	skhan@linuxfoundation.org, vassilisamir@gmail.com
Subject: Re: [PATCH v3 0/2] Add I2C driver for Bosch BMI270 IMU
Date: Wed, 11 Sep 2024 00:22:54 +0200	[thread overview]
Message-ID: <20240910222254.14281-1-vassilisamir@gmail.com> (raw)
In-Reply-To: <20240909043254.611589-1-lanzano.alex@gmail.com>

Hi Alex!

I recently received a review for the code for the BMP280 sensors, and I think
it applies well to you as well. Since you are using the sleeping functions in
your code, maybe a comment on top that explains why this value or where you
found it in the datasheet would be helpful.

Specifically for the Bosch Sensors, because Bosch's datasheets have either
hidden or no information at all, and you need to search for stuff in the
respective C sensor API in the Bosch GitHub.

Cheers,
Vasilis

  parent reply	other threads:[~2024-09-10 22:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09  4:32 Alex Lanzano
2024-09-09  4:32 ` [PATCH v3 1/2] dt-bindings: iio: imu: add bmi270 bindings Alex Lanzano
2024-09-09  4:32 ` [PATCH v3 2/2] iio: imu: Add i2c driver for bmi270 imu Alex Lanzano
2024-09-09 17:03   ` kernel test robot
2024-09-10  3:21     ` Alex Lanzano
2024-09-14 11:51       ` Jonathan Cameron
2024-09-09 22:13   ` kernel test robot
2024-09-10  3:24     ` Alex Lanzano
2024-09-10 22:22 ` Vasileios Amoiridis [this message]
2024-09-11 12:38   ` [PATCH v3 0/2] Add I2C driver for Bosch BMI270 IMU Alex Lanzano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240910222254.14281-1-vassilisamir@gmail.com \
    --to=vassilisamir@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jagathjog1996@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lanzano.alex@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=ramona.bolboaca13@gmail.com \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®