mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	kernel@collabora.com, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] kselftests: mm: Fail the test if userfaultfd syscall isn't found
Date: Thu, 12 Sep 2024 15:31:51 +0500	[thread overview]
Message-ID: <20240912103151.1520254-2-usama.anjum@collabora.com> (raw)
In-Reply-To: <20240912103151.1520254-1-usama.anjum@collabora.com>

The userfaultfd is enabled in the config fragment of mm selftest suite.
It must always be present. If it isn't present, we should throw error
and not just skip. This would have helped us catch the test breakage.
Adding this now to catch the future breakages.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 tools/testing/selftests/mm/pagemap_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c
index bcc73b4e805c6..d83dda8edf62c 100644
--- a/tools/testing/selftests/mm/pagemap_ioctl.c
+++ b/tools/testing/selftests/mm/pagemap_ioctl.c
@@ -95,7 +95,7 @@ int init_uffd(void)
 
 	uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY);
 	if (uffd == -1)
-		return uffd;
+		ksft_exit_fail_perror("Userfaultfd syscall failed");
 
 	uffdio_api.api = UFFD_API;
 	uffdio_api.features = UFFD_FEATURE_WP_UNPOPULATED | UFFD_FEATURE_WP_ASYNC |
-- 
2.39.2


  reply	other threads:[~2024-09-12 10:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 10:31 [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value Muhammad Usama Anjum
2024-09-12 10:31 ` Muhammad Usama Anjum [this message]
2024-09-12 16:10   ` [PATCH 2/2] kselftests: mm: Fail the test if userfaultfd syscall isn't found Shuah Khan
2024-09-12 17:28     ` Shuah Khan
2024-09-16  6:33       ` Muhammad Usama Anjum
2024-09-12 15:44 ` [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value Shuah Khan
2024-09-16  6:32   ` Muhammad Usama Anjum
2024-09-17  1:56     ` Shuah Khan
2024-09-18  5:46       ` Muhammad Usama Anjum
2024-09-18  5:46         ` Muhammad Usama Anjum
2024-09-20 14:59         ` Shuah Khan
2024-09-23  5:35           ` Muhammad Usama Anjum
2024-09-23 16:02             ` Shuah Khan
2024-09-24  6:21               ` Muhammad Usama Anjum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240912103151.1520254-2-usama.anjum@collabora.com \
    --to=usama.anjum@collabora.com \
    --cc=akpm@linux-foundation.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®