From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B583188CCA for ; Thu, 12 Sep 2024 17:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726162625; cv=none; b=n8rWoxj3Bvg5Ci2nU1GJ9MlhxpwoSNZd5I4/SWaJ9SsOREXg3ZkzQoopMsGoYXzf7Z56fq9YEttkZqZKN6KV8k9lSOm5uwq52YRE9vAixwwz67KGf34QRT2x9hgTp5GAIL0v168Ew0eqLm8MgVD0zhcvdb0TIyqXQ9rsmKGZrbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726162625; c=relaxed/simple; bh=PVTyuqOVvCFzOUDK9Tn5EdThlcDl9bLWiPrCn58va4U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RL5xGDNgKPRvnxWGlkbqE1rgQg62johA5cG8E6AvZZNwlBMgY1ht+UsibhbceuDGx9YIrQ9aM90pHQSIVcsRPSKGUsrZNGur5GcLmCC9cM+PlNFQs/qm8rZqbhbI7tnjrAdAwc++UY4bBBVAvmPelZuhHHPd9mGX6JeiylI/Ol0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kutsevol.com; spf=none smtp.mailfrom=kutsevol.com; dkim=pass (2048-bit key) header.d=kutsevol-com.20230601.gappssmtp.com header.i=@kutsevol-com.20230601.gappssmtp.com header.b=gUPUzZ1C; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kutsevol.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=kutsevol.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kutsevol-com.20230601.gappssmtp.com header.i=@kutsevol-com.20230601.gappssmtp.com header.b="gUPUzZ1C" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-710d77380cdso640924a34.0 for ; Thu, 12 Sep 2024 10:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kutsevol-com.20230601.gappssmtp.com; s=20230601; t=1726162623; x=1726767423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vOtRJrcxw3dtqnfY3QlAGbA9nOsusxHIxdHYZ/jMLnU=; b=gUPUzZ1C72WGEoxJcwEOLYrHvt2XNgVJfQ07UliaQVB2bCCdY811Jv3rxLPVYdwDu7 1b72JhktAu4tbP7icWc5oDe5JhurPg/joBRE2twRpxyeo80bcof5EHdsoG72v2tPUp4Q 3yfNuSKYGFi835R4DcAhHk+1eVWf+iC2hNtU3LLKn7xeJJG05YeBuTd9knjV9NR0klTA YcRf3AenAl6AGxjwf5scvCySrWWUVun6HucX5CtoEqfGDLIiEWDJfhecjVlojyh8AtJ6 axXcb1T7fpHKe+WxehoyKi4gjLrgQp8QTvISpKOwsp0EZMC101xnsg7H5Q3L0SDxhLe3 638w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726162623; x=1726767423; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vOtRJrcxw3dtqnfY3QlAGbA9nOsusxHIxdHYZ/jMLnU=; b=r8ZyNYp+O3ik8tcn4ITZEWJBpArqD2o9F/vCn1AitQnrioueeJSF+9+jX+Zj9tz1Xk r4FceEFL6dyhHm1I9jq/+H24HYaNkT9/bZawjiJj1RHAQvCUnLY0csGfVCnXEnouEF7S XWuGIJYlaAJRz0W5acGEMJCsXvOGj580pCEnj3OhJWwzdspUvp1pPiAqK97HcfTh6qw9 qyn55vWHXvA6yRcuKoA04UN3OoNFQrj2/i5A7n04rQo7X3+hkL+iDSres9IpV8eruQZq CXFJMkmzEy5FYTSoDcDwqt7FYpaxdMfr02pyE0HG3YhUgMncW4wH3iKv8zHMfbh1tYk8 +2nQ== X-Forwarded-Encrypted: i=1; AJvYcCU0p7cX0QNXHKlCucyFUw3qIUQ8fyd1d+uRTFG0QhZh32gRcFQfAWIxnpZFXBlRSwnIpIc8cET4NYCcsag=@vger.kernel.org X-Gm-Message-State: AOJu0YzPD+WpwPqNbPjtu+R6Prb27j6wXJe01NML+rd3g7p9JfeUPCm6 FCmTzzFjB4+xZiZflZd3YI+meOOOJuMpfNsTaV4j6KSe/AZj3ZkJfxsEDxcyWPk= X-Google-Smtp-Source: AGHT+IFuJFPYZKz2lBRgAmDoR4knbI5REkie9iGjp3ZmQl7NVnWQuED7nT2O2sgZCjPhkrwXzU9mRw== X-Received: by 2002:a05:6358:60cc:b0:1b8:6074:b53 with SMTP id e5c5f4694b2df-1bb14e31b2amr243669755d.10.1726162623037; Thu, 12 Sep 2024 10:37:03 -0700 (PDT) Received: from devbig254.ash8.facebook.com (fwdproxy-ash-000.fbsv.net. [2a03:2880:20ff::face:b00c]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c534773619sm56605626d6.106.2024.09.12.10.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 10:37:02 -0700 (PDT) From: Maksym Kutsevol To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Breno Leitao , Alex Deucher , Greg Kroah-Hartman , Maksym Kutsevol Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 1/2] netpoll: Make netpoll_send_udp return status instead of void Date: Thu, 12 Sep 2024 10:28:51 -0700 Message-ID: <20240912173608.1821083-1-max@kutsevol.com> X-Mailer: git-send-email 2.43.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit netpoll_send_udp can return if send was successful. It will allow client code to be aware of the send status. Possible return values are the result of __netpoll_send_skb (cast to int) and -ENOMEM. This doesn't cover the case when TX was not successful instantaneously and was scheduled for later, __netpoll__send_skb returns success in that case. Signed-off-by: Maksym Kutsevol --- Changelog: v3: No changes, resend. v2: No changes, resend. * https://lore.kernel.org/netdev/20240828214524.1867954-1-max@kutsevol.com/ v1: * https://lore.kernel.org/netdev/20240824215130.2134153-1-max@kutsevol.com/ include/linux/netpoll.h | 2 +- net/core/netpoll.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h index cd4e28db0cbd..b1ba8d6331a5 100644 --- a/include/linux/netpoll.h +++ b/include/linux/netpoll.h @@ -56,7 +56,7 @@ static inline void netpoll_poll_disable(struct net_device *dev) { return; } static inline void netpoll_poll_enable(struct net_device *dev) { return; } #endif -void netpoll_send_udp(struct netpoll *np, const char *msg, int len); +int netpoll_send_udp(struct netpoll *np, const char *msg, int len); void netpoll_print_options(struct netpoll *np); int netpoll_parse_options(struct netpoll *np, char *opt); int __netpoll_setup(struct netpoll *np, struct net_device *ndev); diff --git a/net/core/netpoll.c b/net/core/netpoll.c index ca52cbe0f63c..4719db36ff25 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -390,7 +390,7 @@ netdev_tx_t netpoll_send_skb(struct netpoll *np, struct sk_buff *skb) } EXPORT_SYMBOL(netpoll_send_skb); -void netpoll_send_udp(struct netpoll *np, const char *msg, int len) +int netpoll_send_udp(struct netpoll *np, const char *msg, int len) { int total_len, ip_len, udp_len; struct sk_buff *skb; @@ -414,7 +414,7 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len) skb = find_skb(np, total_len + np->dev->needed_tailroom, total_len - len); if (!skb) - return; + return -ENOMEM; skb_copy_to_linear_data(skb, msg, len); skb_put(skb, len); @@ -490,7 +490,7 @@ void netpoll_send_udp(struct netpoll *np, const char *msg, int len) skb->dev = np->dev; - netpoll_send_skb(np, skb); + return (int)netpoll_send_skb(np, skb); } EXPORT_SYMBOL(netpoll_send_udp); base-commit: bf73478b539b4a13e0b4e104c82fe3c2833db562 -- 2.43.5