mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: NeilBrown <neilb@suse.de>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Jeff Layton <jlayton@kernel.org>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
	linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockd: Fix comment about NLMv3 backwards compatibility
Date: Fri, 13 Sep 2024 01:22:07 +0200	[thread overview]
Message-ID: <20240912232207.p3gzw744bwtdmghp@pali> (raw)
In-Reply-To: <172618264559.17050.3120241812160491786@noble.neil.brown.name>

On Friday 13 September 2024 09:10:45 NeilBrown wrote:
> On Fri, 13 Sep 2024, Pali Rohár wrote:
> > NLMv2 is completely different protocol than NLMv1 and NLMv3, and in
> > original Sun implementation is used for RPC loopback callbacks from statd
> > to lockd services. Linux does not use nor does not implement NLMv2.
> > 
> > Hence, NLMv3 is not backward compatible with NLMv2. But NLMv3 is backward
> > compatible with NLMv1. Fix comment.
> > 
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> >  fs/lockd/clntxdr.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/lockd/clntxdr.c b/fs/lockd/clntxdr.c
> > index a3e97278b997..81ffa521f945 100644
> > --- a/fs/lockd/clntxdr.c
> > +++ b/fs/lockd/clntxdr.c
> > @@ -3,7 +3,9 @@
> >   * linux/fs/lockd/clntxdr.c
> >   *
> >   * XDR functions to encode/decode NLM version 3 RPC arguments and results.
> > - * NLM version 3 is backwards compatible with NLM versions 1 and 2.
> > + * NLM version 3 is backwards compatible with NLM version 1.
> > + * NLM version 2 is different protocol used only for RPC loopback callbacks
> > + * from statd to lockd and is not implemented on Linux.
> >   *
> >   * NLM client-side only.
> >   *
> 
> Reviewed-by: NeilBrown <neilb@suse.de>
> 
> Do you have a reference for that info about v2?  I hadn't heard of it
> before.
> 
> NeilBrown

I have just this information in my notes. I guess it should be possible
to gather more information about v2 from released Sun/Solaris source
code via OpenSolaris / Illumos projects.

  reply	other threads:[~2024-09-12 23:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 22:53 Pali Rohár
2024-09-12 23:10 ` NeilBrown
2024-09-12 23:22   ` Pali Rohár [this message]
2024-09-12 23:28     ` Pali Rohár
2024-09-12 23:34       ` Chuck Lever
2024-10-05 16:51         ` Pali Rohár
2024-10-05 17:52           ` Chuck Lever III
2024-10-05 17:56             ` Pali Rohár
2024-10-18 13:38 ` cel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240912232207.p3gzw744bwtdmghp@pali \
    --to=pali@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®