From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 2/2] xen/swiotlb: fix allocated size
Date: Mon, 16 Sep 2024 08:47:48 +0200 [thread overview]
Message-ID: <20240916064748.18071-3-jgross@suse.com> (raw)
In-Reply-To: <20240916064748.18071-1-jgross@suse.com>
The allocated size in xen_swiotlb_alloc_coherent() and
xen_swiotlb_free_coherent() is calculated wrong for the case of
XEN_PAGE_SIZE not matching PAGE_SIZE. Fix that.
Fixes: 7250f422da04 ("xen-swiotlb: use actually allocated size on check physical continuous")
Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- new patch
---
drivers/xen/swiotlb-xen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index ddf5b1df632e..faa2fb7c74ae 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -147,7 +147,7 @@ xen_swiotlb_alloc_coherent(struct device *dev, size_t size,
void *ret;
/* Align the allocation to the Xen page size */
- size = 1UL << (order + XEN_PAGE_SHIFT);
+ size = ALIGN(size, XEN_PAGE_SIZE);
ret = (void *)__get_free_pages(flags, get_order(size));
if (!ret)
@@ -179,7 +179,7 @@ xen_swiotlb_free_coherent(struct device *dev, size_t size, void *vaddr,
int order = get_order(size);
/* Convert the size to actually allocated. */
- size = 1UL << (order + XEN_PAGE_SHIFT);
+ size = ALIGN(size, XEN_PAGE_SIZE);
if (WARN_ON_ONCE(dma_handle + size - 1 > dev->coherent_dma_mask) ||
WARN_ON_ONCE(range_straddles_page_boundary(phys, size)))
--
2.43.0
next prev parent reply other threads:[~2024-09-16 6:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 6:47 [PATCH v2 0/2] xen/swiotlb: fix 2 issues in xen-swiotlb Juergen Gross
2024-09-16 6:47 ` [PATCH v2 1/2] xen/swiotlb: add alignment check for dma buffers Juergen Gross
2024-09-16 6:50 ` Jan Beulich
2024-09-16 6:56 ` Juergen Gross
2024-09-16 6:59 ` Jan Beulich
2024-09-16 7:02 ` Jürgen Groß
2024-09-16 6:59 ` Juergen Gross
2024-09-16 7:01 ` Jan Beulich
2024-09-16 7:03 ` Jürgen Groß
2024-09-16 20:19 ` Stefano Stabellini
2024-11-29 17:36 ` Thierry Escande
2024-12-02 8:27 ` Jürgen Groß
2024-12-02 17:21 ` Thierry Escande
2024-09-16 6:47 ` Juergen Gross [this message]
2024-09-16 7:59 ` [PATCH v2 2/2] xen/swiotlb: fix allocated size Jan Beulich
2024-09-16 8:05 ` Jürgen Groß
2024-09-16 20:11 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916064748.18071-3-jgross@suse.com \
--to=jgross@suse.com \
--cc=iommu@lists.linux.dev \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®