From: "Pali Rohár" <pali@kernel.org>
To: Paulo Alcantara <pc@manguebit.com>
Cc: Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: Fix getting reparse points from server without WSL support
Date: Tue, 17 Sep 2024 23:07:07 +0200 [thread overview]
Message-ID: <20240917210707.4lt4obty7wlmm42j@pali> (raw)
In-Reply-To: <73552a5120ff0a49a5e046a08c6c57f4@manguebit.com>
On Tuesday 17 September 2024 18:04:37 Paulo Alcantara wrote:
> Pali Rohár <pali@kernel.org> writes:
>
> > Paulo, please look at this patch as it is related to WSL attributes
> > which you introduced in the mentioned commit. I think that the proper
> > fix should be to change SMB2_OP_QUERY_WSL_EA code to not trigger that
> > -EOPNOTSUPP error which is delivered to userspace. I just checked that
> > this my patch works fine for Native NTFS symlinks and NFS-style reparse
> > point special files.
>
> Thanks for the patch. The problem is that the client is considering
> that the entire compound request failed when the server doesn't support
> EA. The client should still parse the rest of the response that
> contains the getinfo and get reparse info data.
I agree with you. This sounds like the best option.
Would you be able to fix the client code to do this?
next prev parent reply other threads:[~2024-09-17 21:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 20:02 Pali Rohár
2024-09-13 20:10 ` Pali Rohár
2024-09-17 20:06 ` Pali Rohár
2024-09-17 20:23 ` Jeremy Allison
2024-09-17 20:29 ` Pali Rohár
2024-09-17 20:31 ` Jeremy Allison
2024-09-17 20:34 ` Pali Rohár
2024-09-17 20:44 ` Jeremy Allison
2024-09-17 20:44 ` ronnie sahlberg
2024-09-17 20:46 ` Jeremy Allison
2024-09-17 20:59 ` Pali Rohár
2024-09-17 21:19 ` Steve French
2025-08-11 10:52 ` Do not use UID and GID from EAs Pali Rohár
2025-08-29 13:01 ` Pali Rohár
2024-09-17 21:04 ` [PATCH] cifs: Fix getting reparse points from server without WSL support Paulo Alcantara
2024-09-17 21:07 ` Pali Rohár [this message]
2024-09-17 21:17 ` Paulo Alcantara
2024-09-23 18:10 ` Pali Rohár
2024-10-06 10:08 ` Pali Rohár
2024-09-17 21:14 ` Steve French
2024-09-28 14:09 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917210707.4lt4obty7wlmm42j@pali \
--to=pali@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®