From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
To: <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <lgirdwood@gmail.com>,
<perex@perex.cz>, <tiwai@suse.com>,
<Basavaraj.Hiregoudar@amd.com>, <Sunil-kumar.Dommati@amd.com>,
<venkataprasad.potturu@amd.com>, <linux-sound@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Vijendar Mukunda" <Vijendar.Mukunda@amd.com>
Subject: [PATCH 5/8] ASoC: amd: acp: pass acp pci revision id as platform data
Date: Wed, 18 Sep 2024 11:45:37 +0530 [thread overview]
Message-ID: <20240918061540.685579-6-Vijendar.Mukunda@amd.com> (raw)
In-Reply-To: <20240918061540.685579-1-Vijendar.Mukunda@amd.com>
Pass acp pci revision id as platform data to machine driver instead of
'platform' variable when ACP PDM configuration is selected. 'acp_rev'
should be retrieved from mach params revision id for other configuration.
Modify the conditional check for the same.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
sound/soc/amd/acp/acp-legacy-mach.c | 5 +++--
sound/soc/amd/acp/acp-platform.c | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/soc/amd/acp/acp-legacy-mach.c b/sound/soc/amd/acp/acp-legacy-mach.c
index 2a59f7916e15..3526fbe2c84d 100644
--- a/sound/soc/amd/acp/acp-legacy-mach.c
+++ b/sound/soc/amd/acp/acp-legacy-mach.c
@@ -172,9 +172,10 @@ static int acp_asoc_probe(struct platform_device *pdev)
goto out;
}
if (!strcmp(pdev->name, "acp-pdm-mach"))
- acp_card_drvdata->platform = *((int *)dev->platform_data);
+ acp_card_drvdata->acp_rev = *((int *)dev->platform_data);
+ else
+ acp_card_drvdata->acp_rev = mach->mach_params.subsystem_rev;
- acp_card_drvdata->acp_rev = mach->mach_params.subsystem_rev;
dmi_id = dmi_first_match(acp_quirk_table);
if (dmi_id && dmi_id->driver_data)
acp_card_drvdata->tdm_mode = dmi_id->driver_data;
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
index c772520227c7..a6e5cb263377 100644
--- a/sound/soc/amd/acp/acp-platform.c
+++ b/sound/soc/amd/acp/acp-platform.c
@@ -114,7 +114,7 @@ int acp_machine_select(struct acp_dev_data *adata)
int size, platform;
if (adata->flag == FLAG_AMD_LEGACY_ONLY_DMIC) {
- platform = adata->platform;
+ platform = adata->acp_rev;
adata->mach_dev = platform_device_register_data(adata->dev, "acp-pdm-mach",
PLATFORM_DEVID_NONE, &platform,
sizeof(platform));
--
2.34.1
next prev parent reply other threads:[~2024-09-18 6:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 6:15 [PATCH 0/8] ASoC: amd: acp: refactor acp version differentiation logic Vijendar Mukunda
2024-09-18 6:15 ` [PATCH 1/8] ASoC: amd: acp: simplify platform conditional checks code Vijendar Mukunda
2024-09-18 6:15 ` [PATCH 2/8] ASoC: amd: acp: use acp_rev for platform specific conditional checks Vijendar Mukunda
2024-09-18 6:15 ` [PATCH 3/8] ASoC: amd: acp: use acp pci revision id for platform differntiation Vijendar Mukunda
2024-09-18 6:15 ` [PATCH 4/8] ASoC: amd: acp: store acp pci rev id in platform driver private structure Vijendar Mukunda
2024-09-18 6:15 ` Vijendar Mukunda [this message]
2024-09-18 6:15 ` [PATCH 6/8] ASoC: amd: acp: remove unused variable from acp_card_drvdata structure Vijendar Mukunda
2024-09-18 6:15 ` [PATCH 7/8] ASoC: amd: acp: replace adata->platform conditional check Vijendar Mukunda
2024-09-18 6:15 ` [PATCH 8/8] ASoC: amd: acp: remove unused variable from acp platform driver Vijendar Mukunda
2024-09-20 8:42 ` [PATCH 0/8] ASoC: amd: acp: refactor acp version differentiation logic Mukunda,Vijendar
2024-10-01 17:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918061540.685579-6-Vijendar.Mukunda@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®