From: Jeongjun Park <aha310510@gmail.com>
To: syzbot+702361cf7e3d95758761@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [mm?] KCSAN: data-race in generic_fillattr / shmem_mknod (2)
Date: Wed, 18 Sep 2024 15:26:09 +0900 [thread overview]
Message-ID: <20240918062609.200332-1-aha310510@gmail.com> (raw)
In-Reply-To: <0000000000007337c705fa1060e2@google.com>
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
---
fs/ext4/super.c | 56 ++++++++++++++++++++++++-------------------------
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e72145c4ae5a..af78b6271e4c 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -314,113 +314,113 @@ void ext4_superblock_csum_set(struct super_block *sb)
ext4_fsblk_t ext4_block_bitmap(struct super_block *sb,
struct ext4_group_desc *bg)
{
- return le32_to_cpu(bg->bg_block_bitmap_lo) |
+ return READ_ONCE(le32_to_cpu(bg->bg_block_bitmap_lo)) |
(EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ?
- (ext4_fsblk_t)le32_to_cpu(bg->bg_block_bitmap_hi) << 32 : 0);
+ READ_ONCE((ext4_fsblk_t)le32_to_cpu(bg->bg_block_bitmap_hi)) << 32 : 0);
}
ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb,
struct ext4_group_desc *bg)
{
- return le32_to_cpu(bg->bg_inode_bitmap_lo) |
+ return READ_ONCE(le32_to_cpu(bg->bg_inode_bitmap_lo)) |
(EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ?
- (ext4_fsblk_t)le32_to_cpu(bg->bg_inode_bitmap_hi) << 32 : 0);
+ READ_ONCE((ext4_fsblk_t)le32_to_cpu(bg->bg_inode_bitmap_hi)) << 32 : 0);
}
ext4_fsblk_t ext4_inode_table(struct super_block *sb,
struct ext4_group_desc *bg)
{
- return le32_to_cpu(bg->bg_inode_table_lo) |
+ return READ_ONCE(le32_to_cpu(bg->bg_inode_table_lo)) |
(EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ?
- (ext4_fsblk_t)le32_to_cpu(bg->bg_inode_table_hi) << 32 : 0);
+ READ_ONCE((ext4_fsblk_t)le32_to_cpu(bg->bg_inode_table_hi)) << 32 : 0);
}
__u32 ext4_free_group_clusters(struct super_block *sb,
struct ext4_group_desc *bg)
{
- return le16_to_cpu(bg->bg_free_blocks_count_lo) |
+ return READ_ONCE(le16_to_cpu(bg->bg_free_blocks_count_lo)) |
(EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ?
- (__u32)le16_to_cpu(bg->bg_free_blocks_count_hi) << 16 : 0);
+ READ_ONCE((__u32)le16_to_cpu(bg->bg_free_blocks_count_hi)) << 16 : 0);
}
__u32 ext4_free_inodes_count(struct super_block *sb,
struct ext4_group_desc *bg)
{
- return le16_to_cpu(bg->bg_free_inodes_count_lo) |
+ return READ_ONCE(le16_to_cpu(bg->bg_free_inodes_count_lo)) |
(EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ?
- (__u32)le16_to_cpu(bg->bg_free_inodes_count_hi) << 16 : 0);
+ READ_ONCE((__u32)le16_to_cpu(bg->bg_free_inodes_count_hi)) << 16 : 0);
}
__u32 ext4_used_dirs_count(struct super_block *sb,
struct ext4_group_desc *bg)
{
- return le16_to_cpu(bg->bg_used_dirs_count_lo) |
+ return READ_ONCE(le16_to_cpu(bg->bg_used_dirs_count_lo)) |
(EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ?
- (__u32)le16_to_cpu(bg->bg_used_dirs_count_hi) << 16 : 0);
+ READ_ONCE((__u32)le16_to_cpu(bg->bg_used_dirs_count_hi)) << 16 : 0);
}
__u32 ext4_itable_unused_count(struct super_block *sb,
struct ext4_group_desc *bg)
{
- return le16_to_cpu(bg->bg_itable_unused_lo) |
+ return READ_ONCE(le16_to_cpu(bg->bg_itable_unused_lo)) |
(EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ?
- (__u32)le16_to_cpu(bg->bg_itable_unused_hi) << 16 : 0);
+ READ_ONCE((__u32)le16_to_cpu(bg->bg_itable_unused_hi)) << 16 : 0);
}
void ext4_block_bitmap_set(struct super_block *sb,
struct ext4_group_desc *bg, ext4_fsblk_t blk)
{
- bg->bg_block_bitmap_lo = cpu_to_le32((u32)blk);
+ WRITE_ONCE(bg->bg_block_bitmap_lo, cpu_to_le32((u32)blk));
if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT)
- bg->bg_block_bitmap_hi = cpu_to_le32(blk >> 32);
+ WRITE_ONCE(bg->bg_block_bitmap_hi, cpu_to_le32(blk >> 32));
}
void ext4_inode_bitmap_set(struct super_block *sb,
struct ext4_group_desc *bg, ext4_fsblk_t blk)
{
- bg->bg_inode_bitmap_lo = cpu_to_le32((u32)blk);
+ WRITE_ONCE(bg->bg_inode_bitmap_lo, cpu_to_le32((u32)blk));
if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT)
- bg->bg_inode_bitmap_hi = cpu_to_le32(blk >> 32);
+ WRITE_ONCE(bg->bg_inode_bitmap_hi, cpu_to_le32(blk >> 32));
}
void ext4_inode_table_set(struct super_block *sb,
struct ext4_group_desc *bg, ext4_fsblk_t blk)
{
- bg->bg_inode_table_lo = cpu_to_le32((u32)blk);
+ WRITE_ONCE(bg->bg_inode_table_lo, cpu_to_le32((u32)blk));
if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT)
- bg->bg_inode_table_hi = cpu_to_le32(blk >> 32);
+ WRITE_ONCE(bg->bg_inode_table_hi, cpu_to_le32(blk >> 32));
}
void ext4_free_group_clusters_set(struct super_block *sb,
struct ext4_group_desc *bg, __u32 count)
{
- bg->bg_free_blocks_count_lo = cpu_to_le16((__u16)count);
+ WRITE_ONCE(bg->bg_free_blocks_count_lo, cpu_to_le16((__u16)count));
if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT)
- bg->bg_free_blocks_count_hi = cpu_to_le16(count >> 16);
+ WRITE_ONCE(bg->bg_free_blocks_count_hi, cpu_to_le16(count >> 16));
}
void ext4_free_inodes_set(struct super_block *sb,
struct ext4_group_desc *bg, __u32 count)
{
- bg->bg_free_inodes_count_lo = cpu_to_le16((__u16)count);
+ WRITE_ONCE(bg->bg_free_inodes_count_lo, cpu_to_le16((__u16)count));
if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT)
- bg->bg_free_inodes_count_hi = cpu_to_le16(count >> 16);
+ WRITE_ONCE(bg->bg_free_inodes_count_hi, cpu_to_le16(count >> 16));
}
void ext4_used_dirs_set(struct super_block *sb,
struct ext4_group_desc *bg, __u32 count)
{
- bg->bg_used_dirs_count_lo = cpu_to_le16((__u16)count);
+ WRITE_ONCE(bg->bg_used_dirs_count_lo, cpu_to_le16((__u16)count));
if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT)
- bg->bg_used_dirs_count_hi = cpu_to_le16(count >> 16);
+ WRITE_ONCE(bg->bg_used_dirs_count_hi, cpu_to_le16(count >> 16));
}
void ext4_itable_unused_set(struct super_block *sb,
struct ext4_group_desc *bg, __u32 count)
{
- bg->bg_itable_unused_lo = cpu_to_le16((__u16)count);
+ WRITE_ONCE(bg->bg_itable_unused_lo, cpu_to_le16((__u16)count));
if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT)
- bg->bg_itable_unused_hi = cpu_to_le16(count >> 16);
+ WRITE_ONCE(bg->bg_itable_unused_hi, cpu_to_le16(count >> 16));
}
static void __ext4_update_tstamp(__le32 *lo, __u8 *hi, time64_t now)
--
next prev parent reply other threads:[~2024-09-18 6:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 7:58 syzbot
2023-04-24 8:26 ` Dmitry Vyukov
2023-05-01 5:15 ` Tetsuo Handa
2023-05-01 14:05 ` Tetsuo Handa
2023-05-02 10:13 ` Tetsuo Handa
2023-05-02 6:13 ` Dmitry Vyukov
2024-01-12 12:15 ` syzbot
2024-09-18 4:03 ` Jeongjun Park
2024-09-18 4:58 ` syzbot
2024-09-18 6:26 ` Jeongjun Park [this message]
2024-09-18 6:31 ` syzbot
2024-09-18 6:41 ` Jeongjun Park
2024-09-18 7:37 ` syzbot
2024-09-18 7:46 ` Jeongjun Park
2024-09-18 7:58 ` syzbot
2024-09-20 14:27 ` Jeongjun Park
2024-09-20 14:32 ` syzbot
2024-09-20 14:33 ` Jeongjun Park
2024-09-20 14:43 ` syzbot
2024-09-08 5:23 Jeongjun Park
2024-09-08 5:39 ` [syzbot] [mm?] " syzbot
2024-09-08 6:09 Jeongjun Park
2024-09-08 6:49 ` [syzbot] [mm?] " syzbot
2024-09-08 6:27 Jeongjun Park
2024-09-08 6:59 ` [syzbot] [mm?] " syzbot
2024-09-08 7:47 Jeongjun Park
2024-09-08 8:01 ` [syzbot] [mm?] " syzbot
2024-09-08 8:16 Jeongjun Park
2024-09-08 9:31 ` [syzbot] [mm?] " syzbot
2024-09-08 8:34 Jeongjun Park
2024-09-08 9:45 ` [syzbot] [mm?] " syzbot
2024-09-08 10:27 Jeongjun Park
2024-09-08 10:44 ` [syzbot] [mm?] " syzbot
2024-09-08 11:33 Jeongjun Park
2024-09-08 11:49 ` syzbot
2024-09-08 11:33 Jeongjun Park
2024-09-08 12:08 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918062609.200332-1-aha310510@gmail.com \
--to=aha310510@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+702361cf7e3d95758761@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome