From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Yan Zhen <yanzhen@vivo.com>
Cc: kvalo@kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] wifi: rt2x00: convert comma to semicolon
Date: Fri, 20 Sep 2024 11:54:48 +0200 [thread overview]
Message-ID: <20240920095448.GA20424@wp.pl> (raw)
In-Reply-To: <20240920025917.1959932-1-yanzhen@vivo.com>
On Fri, Sep 20, 2024 at 10:59:17AM +0800, Yan Zhen wrote:
> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
>
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index 3bb81bcff0ac..60c2a12e9d5e 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -3607,7 +3607,7 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev,
> rt2800_rfcsr_write(rt2x00dev, 52, 0x0C);
> rt2800_rfcsr_write(rt2x00dev, 54, 0xF8);
> if (rf->channel <= 50) {
> - rt2800_rfcsr_write(rt2x00dev, 55, 0x06),
> + rt2800_rfcsr_write(rt2x00dev, 55, 0x06);
> rt2800_rfcsr_write(rt2x00dev, 56, 0xD3);
> } else if (rf->channel >= 52) {
> rt2800_rfcsr_write(rt2x00dev, 55, 0x04);
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-09-20 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 2:59 Yan Zhen
2024-09-20 9:54 ` Stanislaw Gruszka [this message]
2024-10-17 16:46 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240920095448.GA20424@wp.pl \
--to=stf_xl@wp.pl \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome