From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386AB29CF4; Sun, 22 Sep 2024 17:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727024712; cv=none; b=BdqTrlRlbhkF3jflYMdphe2RskisUGMaeiEKKcgQ7FuxwXW452Z/E38+ICe2ceF6T7tZRqwgz6lUQIHvq+c/kcuc+4GfM538HaiOGa7lmOfTezrsvVCVB34IYCG7Z+0ZodARrJHPPRhtAo4yU45Cz/wk5K+Bg3SHv9KfQPKSujE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727024712; c=relaxed/simple; bh=xslP7AXvSkVuMhvWM8OqO8/hx8E19JC6RLFtS4kykIs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CbqXVGA9TCheo8WHYX+yBl+wNr8iinqqV3mbMS4uyACK7z6cQSx1KxzYLEFZBTRyDnNqfZQxgRTXHaGr4NaKLNGRNzCiy9DvsdPL1ODBZ+LHVuRhx9O3Zu4d1oAbKA5cCZUHRTB0701UDyVVfLd3B+x9imdBHFYdBZZleQPzhus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tb4geJDS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tb4geJDS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56A0DC4CEC3; Sun, 22 Sep 2024 17:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727024711; bh=xslP7AXvSkVuMhvWM8OqO8/hx8E19JC6RLFtS4kykIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tb4geJDSEjrBGmuC/mExVwIo6ha8m2jYkGkBj6kXi1blEi1GLSYSFSqGqpmc2AI+2 hE/VCggXEajkvH8VgpSKngkjiqvndvC3W0abooMx5qm4UQKTqHdlOEtyCHecucJiMv ugt8vGVu17Y4/xUw+j8E59YCXF2ZvXkysByUFwbKmbTkxEdUKEeDoidIhqM+lrCRt3 wCi4IJOATxtu4RH1yUmnEKcVwNVUxs7PVHmtJJl6kriN8LdEDsmtyY/XgK/LykjZ9D YDgwkmB8+/bqRfPsOb+lKZVhaJ7ljk4xspNvEDsFdNsLW28wEdFhw7OX2JLtKbg4Zo PEeZzaC3VC6UQ== Date: Sun, 22 Sep 2024 18:05:07 +0100 From: Simon Horman To: Markus Elfring Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Clayton Rayment , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Michal Simek , Paolo Abeni , Radhey Shyam Pandey , LKML , Julia Lawall Subject: Re: [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write() Message-ID: <20240922170507.GD3426578@kernel.org> References: <330c2b9e-9a15-4442-8288-07f66760f856@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <330c2b9e-9a15-4442-8288-07f66760f856@web.de> On Fri, Sep 20, 2024 at 01:01:45PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 20 Sep 2024 12:43:39 +0200 > Subject: [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write() > > Add a label so that a bit of exception handling can be better reused > at the end of this function implementation. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Hi Markus, This change seems reasonable to me. However, I am assuming that as a non-bug-fix, this is targeted at net-next. And net-next is currently closed for the v6.12 merge window. Please consider reposting this patch once net-next reopens. That will occur after v6.12-rc1 has been released. Which I expect to be about a week from now. Also, for networking patches please tag non-bug fixes for net-next (and bug fixes for net, being sure to include a Fixes tag). Subject: [PATCH net-next] ... Please see https://docs.kernel.org/process/maintainer-netdev.html ... > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c ... > @@ -153,12 +151,9 @@ static int axienet_mdio_write(struct mii_bus *bus, int phy_id, int reg, > XAE_MDIO_MCR_OP_WRITE_MASK)); > > ret = axienet_mdio_wait_until_ready(lp); > - if (ret < 0) { > - axienet_mdio_mdc_disable(lp); > - return ret; > - } Please add a blank line here. > +disable_mdc: > axienet_mdio_mdc_disable(lp); > - return 0; > + return ret; > } > > /** -- pw-bot: defer