From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5244C1940AB for ; Sun, 22 Sep 2024 11:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727005016; cv=none; b=E42n/e50KMjy6NA2byN4ZeCvnHMd67dCPZB5dBvjzRF8lq3nUWy9YIyCf2uV09RlZ6Mj8LwmTH8BKTwl2COtxyUFajw93vQQjU6OwVzz7QDzhcz3xn15l2RK74Wm2vxQYLh5iuPkDJmx5Df9hn7s2f5JObMDZK0JSmzQj/XtWGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727005016; c=relaxed/simple; bh=8iZZwK0PfVH2Z9hha2nnerzECeFdznDDonb2vITPbag=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=k9HU1pQq3Q4TVXXlm/wB8hBsf+ox8bYesk3o1zmGOVARIsLlHcc/jh9Qc9EnPA8JiEsgaD20TnoE4FAs0tuNhrZFi5qagMxQRmJHGowx8nAhh2j7gUlhqbBGeiWlvYZtPCmEtSELR84PdhAgTj2KCBk4dPPJwPdaEZsOxenJJ/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JaTkCgiZ; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JaTkCgiZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727005014; x=1758541014; h=date:from:to:cc:subject:message-id:mime-version; bh=8iZZwK0PfVH2Z9hha2nnerzECeFdznDDonb2vITPbag=; b=JaTkCgiZrDRdoi+grStxPPFv7ZcIgaHY9vz6LUrU7ZhMudHlYc04F0qh 0VROf7COihrZbpTFUKH2kfWatUynXtJS/SC9LNL8JbLVklOBmK3QRw0ge 9l6a3n5f62LX42qjzGC9ZkJaB8BW3r41nRy/jQZuiOcrZU5q7ZZzz4fu2 YjI3Nim22mVckGCZbvgAvIjjul1MOEoDCETQ26z3wz3K9CQeR+YY3Sxw0 QZJAdBbsLiwrK13e3LQhVWtIpo9MdpRJn2ynpwNQNQx7fsZsAnnAO7jba BNSQm/+CFxGLqKEYFqymrYUw5fmNnLeS4YuO/zQCBhNmStsmT8dMSB3JC g==; X-CSE-ConnectionGUID: nZaCV1p7SCWH0Bhqh4m70Q== X-CSE-MsgGUID: c2LoQRR/QmaiU3ky/2QH6g== X-IronPort-AV: E=McAfee;i="6700,10204,11202"; a="26115682" X-IronPort-AV: E=Sophos;i="6.10,249,1719903600"; d="scan'208";a="26115682" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2024 04:36:54 -0700 X-CSE-ConnectionGUID: tlKz8dFoR++Zx61QuQddbg== X-CSE-MsgGUID: yRYILjnRSIyvgGR4mQBsJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,249,1719903600"; d="scan'208";a="75339159" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by fmviesa004.fm.intel.com with ESMTP; 22 Sep 2024 04:36:52 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1ssKtW-000GI2-0Y; Sun, 22 Sep 2024 11:36:50 +0000 Date: Sun, 22 Sep 2024 19:36:15 +0800 From: kernel test robot To: Ilya Leoshkevich Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List , Alexander Potapenko Subject: mm/kmsan/hooks.c:269:14: sparse: sparse: cast removes address space '__user' of expression Message-ID: <202409221923.Z2I9fBpk-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ilya, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 88264981f2082248e892a706b2c5004650faac54 commit: 3a8f6f3b469b4075919a3613e182f9a70df92d46 kmsan: enable on s390 date: 3 months ago config: s390-randconfig-r121-20240922 (https://download.01.org/0day-ci/archive/20240922/202409221923.Z2I9fBpk-lkp@intel.com/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 8663a75fa2f31299ab8d1d90288d9df92aadee88) reproduce: (https://download.01.org/0day-ci/archive/20240922/202409221923.Z2I9fBpk-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409221923.Z2I9fBpk-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> mm/kmsan/hooks.c:269:14: sparse: sparse: cast removes address space '__user' of expression mm/kmsan/hooks.c:271:75: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void const *user_addr @@ got void [noderef] __user *to @@ mm/kmsan/hooks.c:271:75: sparse: expected void const *user_addr mm/kmsan/hooks.c:271:75: sparse: got void [noderef] __user *to mm/kmsan/hooks.c:280:50: sparse: sparse: cast removes address space '__user' of expression mm/kmsan/hooks.c:306:59: sparse: sparse: Using plain integer as NULL pointer mm/kmsan/hooks.c:319:79: sparse: sparse: Using plain integer as NULL pointer mm/kmsan/hooks.c:325:79: sparse: sparse: Using plain integer as NULL pointer mm/kmsan/hooks.c:421:78: sparse: sparse: Using plain integer as NULL pointer vim +/__user +269 mm/kmsan/hooks.c b073d7f8aee4eb Alexander Potapenko 2022-09-15 247 75cf0290271bf6 Alexander Potapenko 2022-09-15 248 void kmsan_copy_to_user(void __user *to, const void *from, size_t to_copy, 75cf0290271bf6 Alexander Potapenko 2022-09-15 249 size_t left) 75cf0290271bf6 Alexander Potapenko 2022-09-15 250 { 75cf0290271bf6 Alexander Potapenko 2022-09-15 251 unsigned long ua_flags; 75cf0290271bf6 Alexander Potapenko 2022-09-15 252 75cf0290271bf6 Alexander Potapenko 2022-09-15 253 if (!kmsan_enabled || kmsan_in_runtime()) 75cf0290271bf6 Alexander Potapenko 2022-09-15 254 return; 75cf0290271bf6 Alexander Potapenko 2022-09-15 255 /* 75cf0290271bf6 Alexander Potapenko 2022-09-15 256 * At this point we've copied the memory already. It's hard to check it 75cf0290271bf6 Alexander Potapenko 2022-09-15 257 * before copying, as the size of actually copied buffer is unknown. 75cf0290271bf6 Alexander Potapenko 2022-09-15 258 */ 75cf0290271bf6 Alexander Potapenko 2022-09-15 259 75cf0290271bf6 Alexander Potapenko 2022-09-15 260 /* copy_to_user() may copy zero bytes. No need to check. */ 75cf0290271bf6 Alexander Potapenko 2022-09-15 261 if (!to_copy) 75cf0290271bf6 Alexander Potapenko 2022-09-15 262 return; 75cf0290271bf6 Alexander Potapenko 2022-09-15 263 /* Or maybe copy_to_user() failed to copy anything. */ 75cf0290271bf6 Alexander Potapenko 2022-09-15 264 if (to_copy <= left) 75cf0290271bf6 Alexander Potapenko 2022-09-15 265 return; 75cf0290271bf6 Alexander Potapenko 2022-09-15 266 75cf0290271bf6 Alexander Potapenko 2022-09-15 267 ua_flags = user_access_save(); f926e9326f3a79 Ilya Leoshkevich 2024-06-21 268 if (!IS_ENABLED(CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE) || f926e9326f3a79 Ilya Leoshkevich 2024-06-21 @269 (u64)to < TASK_SIZE) { 75cf0290271bf6 Alexander Potapenko 2022-09-15 270 /* This is a user memory access, check it. */ 75cf0290271bf6 Alexander Potapenko 2022-09-15 271 kmsan_internal_check_memory((void *)from, to_copy - left, to, 75cf0290271bf6 Alexander Potapenko 2022-09-15 272 REASON_COPY_TO_USER); 75cf0290271bf6 Alexander Potapenko 2022-09-15 273 } else { 75cf0290271bf6 Alexander Potapenko 2022-09-15 274 /* Otherwise this is a kernel memory access. This happens when a 75cf0290271bf6 Alexander Potapenko 2022-09-15 275 * compat syscall passes an argument allocated on the kernel 75cf0290271bf6 Alexander Potapenko 2022-09-15 276 * stack to a real syscall. 75cf0290271bf6 Alexander Potapenko 2022-09-15 277 * Don't check anything, just copy the shadow of the copied 75cf0290271bf6 Alexander Potapenko 2022-09-15 278 * bytes. 75cf0290271bf6 Alexander Potapenko 2022-09-15 279 */ 75cf0290271bf6 Alexander Potapenko 2022-09-15 280 kmsan_internal_memmove_metadata((void *)to, (void *)from, 75cf0290271bf6 Alexander Potapenko 2022-09-15 281 to_copy - left); 75cf0290271bf6 Alexander Potapenko 2022-09-15 282 } 75cf0290271bf6 Alexander Potapenko 2022-09-15 283 user_access_restore(ua_flags); 75cf0290271bf6 Alexander Potapenko 2022-09-15 284 } 75cf0290271bf6 Alexander Potapenko 2022-09-15 285 EXPORT_SYMBOL(kmsan_copy_to_user); 75cf0290271bf6 Alexander Potapenko 2022-09-15 286 :::::: The code at line 269 was first introduced by commit :::::: f926e9326f3a79f7e01ac790e2361f44d8ca8320 kmsan: fix kmsan_copy_to_user() on arches with overlapping address spaces :::::: TO: Ilya Leoshkevich :::::: CC: Andrew Morton -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki