mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Marek Vasut <marex@denx.de>,
	Stefan Agner <stefan@agner.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Fabio Estevam <festevam@gmail.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Lukasz Majewski <lukma@denx.de>
Subject: [PATCH] dt-bindings: lcdif: Add support for specifying display with timings
Date: Mon, 23 Sep 2024 15:57:44 +0200	[thread overview]
Message-ID: <20240923135744.2813712-1-lukma@denx.de> (raw)

Up till now the fsl,lcdif.yaml was requiring the "port" property as a
must have to specify the display interface on iMX devices.

However, it shall also be possible to specify the display only with
passing its timing parameters (h* and v* ones) via "display" property:
(as in
Documentation/devicetree/bindings/display/panel/display-timings.yaml).

Such approach has already been used (also in the mainline) with several
imx28, imx5x and imx6q devices.

This change allows them to pass the DT_SCHEMA check without issues.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 .../bindings/display/fsl,lcdif.yaml           | 51 ++++++++++++++++++-
 1 file changed, 49 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index 8e3a98aeec32..14bb64b5b72d 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -50,6 +50,10 @@ properties:
       - const: disp_axi
     minItems: 1
 
+  display:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: The phandle for display timing information
+
   dmas:
     items:
       - description: DMA specifier for the RX DMA channel.
@@ -64,6 +68,9 @@ properties:
       - description: LCDIF Error interrupt
     minItems: 1
 
+  lcd-supply:
+    description: Regulator for LCD supply voltage.
+
   power-domains:
     maxItems: 1
 
@@ -76,7 +83,10 @@ required:
   - reg
   - clocks
   - interrupts
-  - port
+
+patternProperties:
+  'display([0-9])':
+    description: Node with display timing parameters
 
 additionalProperties: false
 
@@ -197,5 +207,42 @@ examples:
             };
         };
     };
-
+  - |
+    lcdif: lcdif@80030000 {
+        compatible = "fsl,imx28-lcdif";
+        reg = <0x80030000 0x2000>;
+        interrupts = <38>;
+        clocks = <&clks 55>;
+        dmas = <&dma_apbh 13>;
+        dma-names = "rx";
+        pinctrl-names = "default";
+        pinctrl-0 = <&lcdif_24bit_pins_a>, <&lcdif_sync_pins_bttc>,
+                 <&lcdif_reset_pins_bttc>;
+        lcd-supply = <&reg_3v3>;
+        display = <&display0>;
+        status = "okay";
+
+        display0: display0 {
+                bits-per-pixel = <32>;
+                bus-width = <24>;
+                display-timings {
+                        native-mode = <&timing0>;
+                        timing0: timing0 {
+                                clock-frequency = <6500000>;
+                                hactive = <320>;
+                                vactive = <240>;
+                                hfront-porch = <20>;
+                                hback-porch = <38>;
+                                hsync-len = <30>;
+                                vfront-porch = <4>;
+                                vback-porch = <14>;
+                                vsync-len = <4>;
+                                hsync-active = <0>;
+                                vsync-active = <0>;
+                                de-active = <0>;
+                                pixelclk-active = <1>;
+                        };
+                };
+        };
+    };
 ...
-- 
2.39.2


             reply	other threads:[~2024-09-23 13:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 13:57 Lukasz Majewski [this message]
2024-09-23 17:53 ` Marek Vasut
2024-09-24 22:57   ` Rob Herring
2024-09-24 23:44     ` Marek Vasut
2024-09-24 23:03 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240923135744.2813712-1-lukma@denx.de \
    --to=lukma@denx.de \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marex@denx.de \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=stefan@agner.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®