From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 370731FB4; Tue, 24 Sep 2024 08:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727167116; cv=none; b=qjBzn67RMWJk0IAqOd/WlAcVRMe749kd3XuzL0f5SYUYnf3SqbTS0vkbx96AfIG1QsAZnOF8JRDTBGSMcEQABJUmx8aDy1TwGs6AulV413JepWK8OtVZD02e6w2m1TKxwUQgkVCG4MbXRB1QM9qFoht+ssVZ3iiLAQqpEpR3m0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727167116; c=relaxed/simple; bh=a6T2q7zwEUIR037M3r82twWNSJzdzNr0usUDmX0rLtU=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qcgnspVQV+qFfwVnY6T16kd+Orn9kDMo4PPS7DFShUuGDEFcxDZHrYV382zlSC0xwSYYf0Hy9uF4ylTwcPdxIc3fx2OVVgyBQnFn8p2kcVv4Mhx+ChSVGsnRRwqRFBDX9rWmvSFaE2ChEcORV2mooPez9I/re8IWep7qd2pNkzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=F/DnC06P; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="F/DnC06P" Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48O0HWal016787; Tue, 24 Sep 2024 09:50:45 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=selector1; bh=7bjVcgL3xmYFzpy2ZSjgVxLI PHy269ySNc6MACILkeg=; b=F/DnC06PibttoJRlztJqMVuIAnrfSoTWHtkBPt95 0Z2YGXSPDSmAPDl51rKsD5sY30lxRlFU62dbEJ0az52XJxfyYrcYRlO+VrDQNUmi ZnuFBQ8nM+IJozdEuAFHt3g1nWITPa3DuSuzsgh8w9jNxFdy/Oe0qQT4xn0RNQ6A 38ZTyV6fRCMOvihmTPDkM2BsB1+Cid0a2MzDjkN4gi5pwB3SGl6PIEAFMZUZF9F2 mjffKQFGfyBJk/pQ7o6qDs+WsEynxqAsoeVd4+6jtlqNALwOLCTN8eLyt936LwAg 8VRlM7Xga13Zd9+SGOuSQEKWdGphhCrqmcna8/8bnVlHhw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 41snfxwawe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Sep 2024 09:50:45 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 1C21340052; Tue, 24 Sep 2024 09:49:31 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 70E6B25E1E5; Tue, 24 Sep 2024 09:48:17 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.129.178.213) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 24 Sep 2024 09:48:16 +0200 Date: Tue, 24 Sep 2024 09:48:15 +0200 From: Alain Volmat To: Ma Ke CC: , , , , , , , , , , Subject: Re: [PATCH] drm/sti: avoid potential dereference of error pointers in sti_hqvdp_atomic_check Message-ID: <20240924074815.GC463025@gnbcxd0016.gnb.st.com> References: <20240913090926.2023716-1-make24@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240913090926.2023716-1-make24@iscas.ac.cn> X-Disclaimer: ce message est personnel / this message is private X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 Hi, On Fri, Sep 13, 2024 at 05:09:26PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the failure. > > Cc: stable@vger.kernel.org > Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes") > Signed-off-by: Ma Ke > --- > drivers/gpu/drm/sti/sti_hqvdp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c > index 0fb48ac044d8..abab92df78bd 100644 > --- a/drivers/gpu/drm/sti/sti_hqvdp.c > +++ b/drivers/gpu/drm/sti/sti_hqvdp.c > @@ -1037,6 +1037,9 @@ static int sti_hqvdp_atomic_check(struct drm_plane *drm_plane, > return 0; > > crtc_state = drm_atomic_get_crtc_state(state, crtc); > + if (IS_ERR(crtc_state)) > + return PTR_ERR(crtc_state); > + > mode = &crtc_state->mode; > dst_x = new_plane_state->crtc_x; > dst_y = new_plane_state->crtc_y; > -- > 2.25.1 > Thanks, patch applied. Regards, Alain