From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3ACA1B4C3B; Wed, 25 Sep 2024 12:07:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727266029; cv=none; b=UcG+6e2WDpz//K0ploMrAtHimiA+iXbxBQ3KmZzsmgORZeF0NDDWa5arJkMdy56MhZdEXz9XOzksVIHxqxJyXMXoJ3yHFo7Hw5GuwGsWoD1vtUa9X/bbTfGS1fxsdmEqCsSyUokYCoWr0YekNTpV5Mz1Vf/v+vCqnMjcg5Fi3co= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727266029; c=relaxed/simple; bh=vc6yD9jjehmseCavxHBwU7jeCBx7Sc9m0zuowjSxheo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nhU202QeChM3KHA1eezmujhSkqq++YUNxj71zbLIt7xjkveheCMyEhR1rJ8RMS6xbQNOjF1+zaDoE5BOCoycQyJjAlMhEGZlhcHLi5l7zFPGtU49Biv+WfQDYmk6vxe0ikwpi+kNJRzA2pmM++cPnl8OZ6f7PXdifPLDBf58S30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bakhi7AS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bakhi7AS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA9B2C4CEC3; Wed, 25 Sep 2024 12:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727266028; bh=vc6yD9jjehmseCavxHBwU7jeCBx7Sc9m0zuowjSxheo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bakhi7ASpVXaQO67pvzUBPsAU9NJkkSlJCccccgLZlKOux74LmDJFSx6mdF9ZNsTo m+5EqfATHm7QZxJ1MDI5S/64Py8ZnHsoRsoLfgfU6jLKL0qhEPgc2Nzzjf0efexRp7 YXK6y7LBdxkzJpMfC0paAuZrypuqaGeIeu5mpAPSshkOWWcv2HuZ0SdIabCndY2jIj hITPgC9/yDqP86/NqqtGM2rwuKqqeCEXimohehOVYJQAwzTWSI1erhLWTGqfYdWWbG DOB04uRi8ul+O4sWtfcccm9C7NAqMwMLd2RhZM06Dg0vK3qeGgeAng9frL4fkR7jfH I37VXcOmNf6Ww== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Hung , Rodrigo Siqueira , Jerry Zuo , Daniel Wheeler , Alex Deucher , Sasha Levin , harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, wenjing.liu@amd.com, alvin.lee2@amd.com, george.shen@amd.com, dillon.varone@amd.com, aurabindo.pillai@amd.com, gabe.teeger@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.10 151/197] drm/amd/display: Check stream before comparing them Date: Wed, 25 Sep 2024 07:52:50 -0400 Message-ID: <20240925115823.1303019-151-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240925115823.1303019-1-sashal@kernel.org> References: <20240925115823.1303019-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.11 Content-Transfer-Encoding: 8bit From: Alex Hung [ Upstream commit 35ff747c86767937ee1e0ca987545b7eed7a0810 ] [WHAT & HOW] amdgpu_dm can pass a null stream to dc_is_stream_unchanged. It is necessary to check for null before dereferencing them. This fixes 1 FORWARD_NULL issue reported by Coverity. Reviewed-by: Rodrigo Siqueira Signed-off-by: Jerry Zuo Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c index 7462c34793799..58f6155fecc5a 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c @@ -3134,6 +3134,8 @@ static bool are_stream_backends_same( bool dc_is_stream_unchanged( struct dc_stream_state *old_stream, struct dc_stream_state *stream) { + if (!old_stream || !stream) + return false; if (!are_stream_backends_same(old_stream, stream)) return false; -- 2.43.0