From: Sergey Matsievskiy <matsievskiysv@gmail.com>
To: tglx@linutronix.de
Cc: maz@kernel.org, alexandre.belloni@bootlin.com,
gregory.clement@bootlin.com, lars.povlsen@microchip.com,
UNGLinuxDriver@microchip.com, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sergey Matsievskiy <matsievskiysv@gmail.com>
Subject: [PATCH 1/2] irqchip/ocelot: Fix trigger register address
Date: Wed, 25 Sep 2024 21:44:15 +0300 [thread overview]
Message-ID: <20240925184416.54204-2-matsievskiysv@gmail.com> (raw)
In-Reply-To: <20240925184416.54204-1-matsievskiysv@gmail.com>
Use main interrupt trigger registers instead of device interrupt trigger
registers.
Controllers, supported by this driver, have two sets of registers:
* (main) interrupt registers control peripheral interrupt sources;
* device interrupt registers configure per-device (network interface)
interrupts and act as an extra stage before the main interrupt registers.
In the driver unmask code, device trigger registers are used in the mask
calculation of the main interrupt sticky register, mixing two kinds of
registers. Use main interrupt trigger register instead.
Signed-off-by: Sergey Matsievskiy <matsievskiysv@gmail.com>
---
drivers/irqchip/irq-mscc-ocelot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-mscc-ocelot.c b/drivers/irqchip/irq-mscc-ocelot.c
index 4d0c3532dbe7..c19ab379e8c5 100644
--- a/drivers/irqchip/irq-mscc-ocelot.c
+++ b/drivers/irqchip/irq-mscc-ocelot.c
@@ -37,7 +37,7 @@ static struct chip_props ocelot_props = {
.reg_off_ena_clr = 0x1c,
.reg_off_ena_set = 0x20,
.reg_off_ident = 0x38,
- .reg_off_trigger = 0x5c,
+ .reg_off_trigger = 0x4,
.n_irq = 24,
};
@@ -70,7 +70,7 @@ static struct chip_props jaguar2_props = {
.reg_off_ena_clr = 0x1c,
.reg_off_ena_set = 0x20,
.reg_off_ident = 0x38,
- .reg_off_trigger = 0x5c,
+ .reg_off_trigger = 0x4,
.n_irq = 29,
};
--
2.39.2
next prev parent reply other threads:[~2024-09-25 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 18:44 [PATCH 0/2] " Sergey Matsievskiy
2024-09-25 18:44 ` Sergey Matsievskiy [this message]
2024-10-02 15:43 ` [tip: irq/urgent] " tip-bot2 for Sergey Matsievskiy
2024-09-25 18:44 ` [PATCH 2/2] irqchip/ocelot: Comment sticky register clearing code Sergey Matsievskiy
2024-10-02 15:43 ` [tip: irq/urgent] " tip-bot2 for Sergey Matsievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925184416.54204-2-matsievskiysv@gmail.com \
--to=matsievskiysv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=gregory.clement@bootlin.com \
--cc=lars.povlsen@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®