From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15E562F2E; Fri, 27 Sep 2024 05:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727413229; cv=none; b=cDmsE9ZzxqdbGa+Ux5/yMScxmh0c4RsvQky6kOgvFg9v7ZKz0bfFG28u9jdEcOgWIs45WU/xb+fDrFo6WNx153H0l4JaVAaTaJQ5JfZDHsbO5Gyq9mj0DFYukEiBJUrdvWfSEAMp25ynR4RdSo3zNYVT7Fw9B8w6oap0/ZwRzBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727413229; c=relaxed/simple; bh=fyEkOgWNjkVh2h59wO0cF/KpMYftbWbXFZjDs5tjBfo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lwmx/3TfmT2mYIBlxD45eP80+Xtwm2EBo+8CEqCrZFJGEar9txhYVRKx27YGaCamUq3XgcqJoT300a8M8q9R9C3rtFbCbiLSQEmUf7dpGsdNf4lxwI1J4ykMgDFtVIEKVVbaBGFypoJKVxHUzkVvumfuU2bQDYuqy2/piXB/q6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DRMSI2LA; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DRMSI2LA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727413228; x=1758949228; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fyEkOgWNjkVh2h59wO0cF/KpMYftbWbXFZjDs5tjBfo=; b=DRMSI2LA/te88F0BJTN35VZs8jJmeVkJSHq5FPW2eAOcBFZFzp75IfbY tDM7byQoJ2kvLHqnqCVqeSDq45h1wizpHUAOa1QpkJGJ/ec7BSR3BkC0m lL1Rr7pBXIRHNFTElca8pcerLIHhxj1jSChzpMKAPsvtzkMkLQFPaygTa jmZipcs3znzc7eL2nIAw65A5WXUbpVaAK8R5rnExsv6ShKOYj5xEeKNNt gT312WiGzT7Giqi3JVsQHPfaJSIugiZsZImZijnWdZcpq5j/Kuq+PNk4X j3Y8phAAJwkETU9Q9QQUAyuySm/nf+9NjlXqWcJ+8YaudyUwxKbpVXrgV g==; X-CSE-ConnectionGUID: EL00soVsSoutFVN5lONqJA== X-CSE-MsgGUID: nqZSdCbTRAupxs2nIVuZvQ== X-IronPort-AV: E=McAfee;i="6700,10204,11207"; a="44062605" X-IronPort-AV: E=Sophos;i="6.11,157,1725346800"; d="scan'208";a="44062605" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2024 22:00:27 -0700 X-CSE-ConnectionGUID: y0CtHs0STD2a81Hi67P80A== X-CSE-MsgGUID: Ua0jgpiCTPOtT7V2VjnvJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,157,1725346800"; d="scan'208";a="72558649" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa008.fm.intel.com with ESMTP; 26 Sep 2024 22:00:25 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id A8CD6170; Fri, 27 Sep 2024 08:00:24 +0300 (EEST) Date: Fri, 27 Sep 2024 08:00:24 +0300 From: Mika Westerberg To: Javier Carrasco Cc: Andy Shevchenko , Linus Walleij , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 0/2] pinctrl: intel: platform: fix error path in device_for_each_child_node() Message-ID: <20240927050024.GB275077@black.fi.intel.com> References: <20240926-intel-pinctrl-platform-scoped-v1-0-5ee4c936eea3@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240926-intel-pinctrl-platform-scoped-v1-0-5ee4c936eea3@gmail.com> On Thu, Sep 26, 2024 at 04:11:01PM +0200, Javier Carrasco wrote: > This series fixes an error path where the reference of a child node is > not decremented upon early return. When at it, a trivial comma/semicolon > substitution I found by chance has been added to improve code clarity. > > Signed-off-by: Javier Carrasco > --- > Javier Carrasco (2): > pinctrl: intel: platform: fix error path in device_for_each_child_node() > pinctrl: intel: platform: use semicolon instead of comma in ncommunities assignment Both, Acked-by: Mika Westerberg