From: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
To: shaggy@kernel.org, ghandatmanas@gmail.com,
juntong.deng@outlook.com, aha310510@gmail.com,
peili.dev@gmail.com, ghanshyam1898@gmail.com, eadavis@qq.com
Cc: jfs-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
syzbot+b5ca8a249162c4b9a7d0@syzkaller.appspotmail.com
Subject: [PATCH] jfs: fix shift-out-of-bounds in dbSplit
Date: Mon, 30 Sep 2024 13:42:18 +0530 [thread overview]
Message-ID: <20240930081218.2992648-1-ghanshyam1898@gmail.com> (raw)
When dmt_budmin is less than zero, it causes errors
in the later stages. Added a check to return an error beforehand
in dbAllocCtl itself.
Reported-by: syzbot+b5ca8a249162c4b9a7d0@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=b5ca8a249162c4b9a7d0
Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
---
fs/jfs/jfs_dmap.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c
index 974ecf5e0d95..f65a07252c22 100644
--- a/fs/jfs/jfs_dmap.c
+++ b/fs/jfs/jfs_dmap.c
@@ -1808,6 +1808,7 @@ dbAllocCtl(struct bmap * bmp, s64 nblocks, int l2nb, s64 blkno, s64 * results)
s64 b, lblkno, n;
struct metapage *mp;
struct dmap *dp;
+ dmtree_t *tp;
/* check if the allocation request is confined to a single dmap.
*/
@@ -1819,6 +1820,10 @@ dbAllocCtl(struct bmap * bmp, s64 nblocks, int l2nb, s64 blkno, s64 * results)
if (mp == NULL)
return -EIO;
dp = (struct dmap *) mp->data;
+ tp = (dmtree_t *) &dp->tree;
+
+ if (tp->dmt_budmin < 0)
+ return -EIO;
/* try to allocate the blocks.
*/
--
2.34.1
next reply other threads:[~2024-09-30 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 8:12 Ghanshyam Agrawal [this message]
2024-10-29 21:53 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930081218.2992648-1-ghanshyam1898@gmail.com \
--to=ghanshyam1898@gmail.com \
--cc=aha310510@gmail.com \
--cc=eadavis@qq.com \
--cc=ghandatmanas@gmail.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=juntong.deng@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peili.dev@gmail.com \
--cc=shaggy@kernel.org \
--cc=syzbot+b5ca8a249162c4b9a7d0@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®