From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rishi Gupta <gupt21@gmail.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>
Subject: [PATCH v3 6/9] iio: light: veml6030: drop processed info for white channel
Date: Tue, 01 Oct 2024 22:21:19 +0200 [thread overview]
Message-ID: <20241001-veml6035-v3-6-d789f6ff147c@gmail.com> (raw)
In-Reply-To: <20241001-veml6035-v3-0-d789f6ff147c@gmail.com>
The resolution of the WHITE channel is not provided by the manufacturer,
neither in the datasheet nor in the application note (even their
proprietary application only processes the ALS channel, giving raw
values for WHITE).
The current implementation assumes that both resolutions are identical,
which is extremely unlikely, especially for photodiodes with different
spectral responses.
Drop the processed information as it is meaningless.
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
drivers/iio/light/veml6030.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
index fe6d2f9a2e01..677374e401b3 100644
--- a/drivers/iio/light/veml6030.c
+++ b/drivers/iio/light/veml6030.c
@@ -210,7 +210,6 @@ static const struct iio_chan_spec veml6030_channels[] = {
.modified = 1,
.channel2 = IIO_MOD_LIGHT_BOTH,
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
- BIT(IIO_CHAN_INFO_PROCESSED) |
BIT(IIO_CHAN_INFO_INT_TIME) |
BIT(IIO_CHAN_INFO_SCALE),
.info_mask_shared_by_all_available = BIT(IIO_CHAN_INFO_INT_TIME) |
@@ -549,11 +548,6 @@ static int veml6030_read_raw(struct iio_dev *indio_dev,
dev_err(dev, "can't read white data %d\n", ret);
return ret;
}
- if (mask == IIO_CHAN_INFO_PROCESSED) {
- *val = (reg * data->cur_resolution) / 10000;
- *val2 = (reg * data->cur_resolution) % 10000;
- return IIO_VAL_INT_PLUS_MICRO;
- }
*val = reg;
return IIO_VAL_INT;
default:
--
2.43.0
next prev parent reply other threads:[~2024-10-01 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 20:21 [PATCH v3 0/9] iio: light: veml6030: fix issues and add support for veml6035 Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 1/9] iio: light: veml6030: add set up delay after any power on sequence Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 2/9] iio: light: veml6030: use dev_err_probe() Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 3/9] dt-bindings: iio: light: veml6030: add vdd-supply property Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 4/9] iio: light: veml6030: add support for a regulator Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 5/9] iio: light: veml6030: use read_avail() for available attributes Javier Carrasco
2024-10-01 20:21 ` Javier Carrasco [this message]
2024-10-01 20:21 ` [PATCH v3 7/9] iio: light: veml6030: power off device in probe error paths Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 8/9] dt-bindings: iio: light: veml6030: add veml6035 Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 9/9] iio: light: veml6030: add support for veml6035 Javier Carrasco
2024-10-06 14:10 ` [PATCH v3 0/9] iio: light: veml6030: fix issues and " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241001-veml6035-v3-6-d789f6ff147c@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gupt21@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®