From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
steve.glendinning@shawell.net
Subject: [PATCHv2 net-next 7/9] net: smsc911x: remove pointless NULL checks
Date: Tue, 1 Oct 2024 11:29:14 -0700 [thread overview]
Message-ID: <20241001182916.122259-8-rosenp@gmail.com> (raw)
In-Reply-To: <20241001182916.122259-1-rosenp@gmail.com>
ioaddr can never be NULL. Probe aborts in such a case.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index e757c5825620..c4c6480c0ffe 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -2110,11 +2110,6 @@ static int smsc911x_init(struct net_device *dev)
spin_lock_init(&pdata->dev_lock);
spin_lock_init(&pdata->mac_lock);
- if (pdata->ioaddr == NULL) {
- SMSC_WARN(pdata, probe, "pdata->ioaddr: 0x00000000");
- return -ENODEV;
- }
-
/*
* poll the READY bit in PMT_CTRL. Any other access to the device is
* forbidden while this bit isn't set. Try for 100ms
@@ -2339,11 +2334,6 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
if (retval)
return retval;
- if (pdata->ioaddr == NULL) {
- SMSC_WARN(pdata, probe, "Error smsc911x base address invalid");
- return -ENOMEM;
- }
-
retval = smsc911x_probe_config(&pdata->config, &pdev->dev);
if (retval && config) {
/* copy config parameters across to pdata */
--
2.46.2
next prev parent reply other threads:[~2024-10-01 18:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 18:29 [PATCHv2 net-next 0/9] clean up with devm Rosen Penev
2024-10-01 18:29 ` [PATCHv2 net-next 1/9] net: smsc911x: use devm_platform_ioremap_resource Rosen Penev
2024-10-01 22:22 ` Andrew Lunn
2024-10-01 18:29 ` [PATCHv2 net-next 2/9] net: smsc911x: use devm_alloc_etherdev Rosen Penev
2024-10-01 22:24 ` Andrew Lunn
2024-10-01 18:29 ` [PATCHv2 net-next 3/9] net: smsc911x: use devm for regulators Rosen Penev
2024-10-01 22:27 ` Andrew Lunn
2024-10-01 23:44 ` Rosen Penev
2024-10-01 18:29 ` [PATCHv2 net-next 4/9] net: smsc911x: use devm for mdiobus functions Rosen Penev
2024-10-01 22:28 ` Andrew Lunn
2024-10-01 18:29 ` [PATCHv2 net-next 5/9] net: smsc911x: use devm for register_netdev Rosen Penev
2024-10-01 22:30 ` Andrew Lunn
2024-10-01 18:29 ` [PATCHv2 net-next 6/9] net: smsc911x: remove debug stuff from _remove Rosen Penev
2024-10-01 22:30 ` Andrew Lunn
2024-10-01 18:29 ` Rosen Penev [this message]
2024-10-01 18:29 ` [PATCHv2 net-next 8/9] net: smsc911x: remove enable_resources function Rosen Penev
2024-10-01 18:29 ` [PATCHv2 net-next 9/9] net: smsc911x: move reset_gpio member down Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241001182916.122259-8-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®