From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB27912E1EE; Wed, 2 Oct 2024 11:30:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868659; cv=none; b=kQfnRlK7oGANitNCzS/7V881Du7olv7YPuihbDffrftk8pAAYFafaRq8/A4A3IZKg4S4YeFBiCRHg87wnQI4qPuE/c3euAiOsl0bhXZtQUHr+uvkYHNRIK6iGvSHm0dpTulIfbq71/4aRzk5AG+XR0L9FUkywcJwFgemrBHt9MY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727868659; c=relaxed/simple; bh=xo+Bne4sKMbrVBoeYhb5KBZhjW7/mVg/usF9sSoJXOI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tNMFVWdP4wrnUinoWJKRYCv6KN87XvpCGrBYYCl3jr7iU1W7EmrRXEzoGMkdFwrvEDX4a9Dj8UgImsyym/Qa2Ys0SxgMHq4at2EaT1aymJfXJYNR0kZYf9hM1SM/6JP1E1nXuhR62uL6Gh9Az7R2I0Z5NGIsuMDNBvRQW9Wmz88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vJhDFvwW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vJhDFvwW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0105FC4CEC5; Wed, 2 Oct 2024 11:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727868659; bh=xo+Bne4sKMbrVBoeYhb5KBZhjW7/mVg/usF9sSoJXOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vJhDFvwWgTzoieYft47lOcydJQR/qnbgmpFt8IrEmLzHVnAeokEAJmc8kwau0Jql3 5Kldy3E4SSg8TS8FQSf5vmyIGAbAEJO2gnTsh8kJVYHs2U10JRV4AV7ohzBHVoyePi YoUxguxCBQaskThPWegy/iUaUPpOQj+LAnrhUjRQb3uFq8OFD7Wkj7LklS2cE0YbL3 6v9BmgnAAGeSNGgW+uYYCxesRFK/eE7UCCSLxFxO8HFtpQdwZoVywjhLeeYnENNaz/ CCZYdnu4USrn8rSMU5PxuGGnLUWe6qIxJLaDPj6ygIZCZkFHTUQHNYR2yZMpGyq/9W kXFQkKd097puA== Date: Wed, 2 Oct 2024 13:30:50 +0200 From: Christian Brauner To: Miguel Ojeda Cc: Alice Ryhl , rust-for-linux@vger.kernel.org, Paul Moore , James Morris , "Serge E. Hallyn" , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Bjoern Roy Baron , Benno Lossin , Peter Zijlstra , Alexander Viro , Greg Kroah-Hartman , Arve Hjonnevag , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Dan Williams , Matthew Wilcox , Thomas Gleixner , Daniel Xu , Martin Rodriguez Reboredo , Trevor Gross , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, Kees Cook , Andreas Hindborg Subject: Re: [PATCH v4] rust: add PidNamespace Message-ID: <20241002-wappnen-kartoffeln-deea146780ef@brauner> References: <20241002-brauner-rust-pid_namespace-v4-1-d28045dc7348@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Oct 02, 2024 at 01:12:08PM GMT, Miguel Ojeda wrote: > On Wed, Oct 2, 2024 at 1:00 PM Christian Brauner wrote: > > > > + let pidns = unsafe { bindings::task_active_pid_ns(Task::current_raw()) }; > > Missing `// SAFETY` -- I mention it since this will be a warning (thus > error in `WERROR`) soon. > > > + let ptr = unsafe { bindings::task_get_pid_ns(self.0.get()) }; > > Ditto. > > > + Some(pidns) => unsafe { bindings::task_tgid_nr_ns(self.0.get(), pidns.as_ptr()) }, > > + None => unsafe { bindings::task_tgid_nr_ns(self.0.get(), ptr::null_mut()) }, > > Ditto. Ah, good to know.