From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACA481CFEB7 for ; Wed, 2 Oct 2024 12:38:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727872706; cv=none; b=U0iJ7UcV6NP0NBEe/VvVOA3uxqwdE97f0ma9l26gWWHxMl5228tDZ6UlPCEiXp/AfufNKUpUbwUhzRIfTpMQhzkgCGu3otAToUbIqIY1LYVaAS/v1Y3OddE3uw7z6XY/bBr3sFfzMyeoyIQoIunb6Kf79EPBDpHOQbfH9lnJifg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727872706; c=relaxed/simple; bh=g1UNvIVEcKZPqIH5c1rcorfzK9E6LCVo7yLwVn0J8pA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UupVItcvaJSXCpPexJyHAlb4ZOmGnNYPDdpkROUEA9NkkaL8zOuWAX9fh5YZYLPJoreO+yqEoUZWiyvheFpAnh5QuJ29ciAI0pPeqfo2qcid01LaNEoAuutv48YjcZUL9imDjk/gHz3KVOHOI0Wn2Rt24saU3tT0TtJJz3pxg1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LAnkoG8r; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LAnkoG8r" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727872703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nUycqu6EqSC60iYvDsl+Om1SzAibDAMectWvdn0BXWc=; b=LAnkoG8r7kvW3jgNtgyUFz8fUL+Cii1WyaPxb9WVhmIgAH+jDQCAQER4+2XaDUfcIk4vLh Huf7sA2XT4oe+jcRsj4XATPn4hOfLSwb+U8J43iNfhRl0eDSdEaTd2vYJxkplX4ZIxTFdt 1ES06aWZ6lxfj/cpMBWMeFEYwzjEO90= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-BLgjER3YOJS2I-sN19Dvsw-1; Wed, 02 Oct 2024 08:38:22 -0400 X-MC-Unique: BLgjER3YOJS2I-sN19Dvsw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37cd4acb55aso3990542f8f.0 for ; Wed, 02 Oct 2024 05:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727872701; x=1728477501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nUycqu6EqSC60iYvDsl+Om1SzAibDAMectWvdn0BXWc=; b=AsKVhqiBE4d9lHUcs5xg9S396lZi20unX0O4xrBn1e7CvAdreuMcNqrJKltqYnqCCW Lb54Vs3bBpX54bYZyF40voN35DYi9MrkonbRnOVWF5uvV0ukDoxVci8fsE0HzFDZL/Q8 iu29Ykxx5HHm+xulm45oU0dUIPa09L/AwmtR3MP1ms4ebjGjO/Y2Gm4ZM5Wi2NJDMIlu LBZISDQMR0HF21LnIlnLbrX7saMdlCs6xc/n9eqskn9Kf8XEBcBnRRAb5FZmVFABgoLC +7ezj/cp2A4HaQnUb0Qbp+LDPAIliZYWISc/oew55FsKP5ItffeEwJPvFXY5AgProjTk JRiQ== X-Forwarded-Encrypted: i=1; AJvYcCW8o3JAPE34NSIoVyD2dQ3A32SLBLelzFua9G71R6+LNnS8gaFbxUSAV7YoA6Ft/6dbVGBikK0g7ondd3s=@vger.kernel.org X-Gm-Message-State: AOJu0YyP6FPv7aIXerSlk+0kPV3aDjnFGfQRkNUKGznmraVH7l7ELJYo 3Ic4CtiAh1NNSmhrA/IAAve/x98wmZriUCBgzy65h7yxhHS4LZGcaQnadKuX69kkDFMsd73pCNv xZPsdjeRqGV9yIeDXeSrlEUsSWLlPLgtMw3E1LnQnPzCPWZg5Z9WwSXYHWiiAmg== X-Received: by 2002:a05:6000:c9:b0:37c:d2e3:1298 with SMTP id ffacd0b85a97d-37cfba19c9amr2701947f8f.55.1727872701312; Wed, 02 Oct 2024 05:38:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGM3GfOi2lkguW+zchNgFC917E3/BtHmefG60ZH994PbjW8zP0KkoN/vzUw316qUHGQh1fseA== X-Received: by 2002:a05:6000:c9:b0:37c:d2e3:1298 with SMTP id ffacd0b85a97d-37cfba19c9amr2701917f8f.55.1727872700825; Wed, 02 Oct 2024 05:38:20 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cd572fbdfsm13859274f8f.79.2024.10.02.05.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 05:38:20 -0700 (PDT) Date: Wed, 2 Oct 2024 14:38:19 +0200 From: Igor Mammedov To: Mauro Carvalho Chehab Cc: "Michael S. Tsirkin" , Ani Sinha , Dongjiu Geng , linux-kernel@vger.kernel.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, Jonathan Cameron Subject: Re: [PATCH v2 14/15] acpi/ghes: better name the offset of the hardware error firmware Message-ID: <20241002143819.281ea155@imammedo.users.ipa.redhat.com> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 1 Oct 2024 09:03:51 +0200 Mauro Carvalho Chehab wrote: > The hardware error firmware is where HEST error structures are > stored. Those can be GHESv2, but they can also be other types. > > Better name the location of the hardware error. > > No functional changes. > > Signed-off-by: Mauro Carvalho Chehab > Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov > --- > hw/acpi/generic_event_device.c | 4 ++-- > hw/acpi/ghes.c | 4 ++-- > include/hw/acpi/ghes.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > index 15b4c3ebbf24..d4dbfb45e181 100644 > --- a/hw/acpi/generic_event_device.c > +++ b/hw/acpi/generic_event_device.c > @@ -346,7 +346,7 @@ static const VMStateDescription vmstate_ghes = { > .version_id = 1, > .minimum_version_id = 1, > .fields = (const VMStateField[]) { > - VMSTATE_UINT64(ghes_addr_le, AcpiGhesState), > + VMSTATE_UINT64(hw_error_le, AcpiGhesState), > VMSTATE_END_OF_LIST() > }, > }; > @@ -354,7 +354,7 @@ static const VMStateDescription vmstate_ghes = { > static bool ghes_needed(void *opaque) > { > AcpiGedState *s = opaque; > - return s->ghes_state.ghes_addr_le; > + return s->ghes_state.hw_error_le; > } > > static const VMStateDescription vmstate_ghes_state = { > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index 3d03506fdaf8..8b3292be07e7 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -379,7 +379,7 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s, > > /* Create a read-write fw_cfg file for Address */ > fw_cfg_add_file_callback(s, ACPI_HW_ERROR_ADDR_FW_CFG_FILE, NULL, NULL, > - NULL, &(ags->ghes_addr_le), sizeof(ags->ghes_addr_le), false); > + NULL, &(ags->hw_error_le), sizeof(ags->hw_error_le), false); > > ags->present = true; > } > @@ -430,7 +430,7 @@ void ghes_record_cper_errors(const void *cper, size_t len, > } > ags = &acpi_ged_state->ghes_state; > > - get_ghes_offsets(le64_to_cpu(ags->ghes_addr_le), > + get_ghes_offsets(le64_to_cpu(ags->hw_error_le), > &cper_addr, &read_ack_register_addr); > > if (!cper_addr) { > diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h > index 051a9322141f..e47ffacbb5c9 100644 > --- a/include/hw/acpi/ghes.h > +++ b/include/hw/acpi/ghes.h > @@ -58,7 +58,7 @@ enum AcpiGhesNotifyType { > }; > > typedef struct AcpiGhesState { > - uint64_t ghes_addr_le; > + uint64_t hw_error_le; > bool present; /* True if GHES is present at all on this board */ > } AcpiGhesState; >