From: Jan Kara <jack@suse.cz>
To: Tang Yizhou <yizhou.tang@shopee.com>
Cc: willy@infradead.org, akpm@linux-foundation.org,
chandan.babu@oracle.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] mm/page-writeback.c: Fix comment of wb_domain_writeout_add()
Date: Thu, 3 Oct 2024 14:16:35 +0200 [thread overview]
Message-ID: <20241003121635.l7wpciq2jnoh7sq2@quack3> (raw)
In-Reply-To: <20241002130004.69010-3-yizhou.tang@shopee.com>
On Wed 02-10-24 21:00:03, Tang Yizhou wrote:
> From: Tang Yizhou <yizhou.tang@shopee.com>
>
> __bdi_writeout_inc() has undergone multiple renamings, but the comment
> within the function body have not been updated accordingly. Update it
> to reflect the latest wb_domain_writeout_add().
>
> Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index a848e7f0719d..4f6efaa060bd 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -586,7 +586,7 @@ static void wb_domain_writeout_add(struct wb_domain *dom,
> /* First event after period switching was turned off? */
> if (unlikely(!dom->period_time)) {
> /*
> - * We can race with other __bdi_writeout_inc calls here but
> + * We can race with other wb_domain_writeout_add calls here but
> * it does not cause any harm since the resulting time when
> * timer will fire and what is in writeout_period_time will be
> * roughly the same.
> --
> 2.25.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-10-03 12:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 13:00 [PATCH 0/3] Cleanup some writeback codes Tang Yizhou
2024-10-02 13:00 ` [PATCH 1/3] mm/page-writeback.c: Rename BANDWIDTH_INTERVAL to UPDATE_INTERVAL Tang Yizhou
2024-10-03 13:01 ` Jan Kara
2024-10-06 12:41 ` Tang Yizhou
2024-10-07 16:23 ` Jan Kara
2024-10-08 14:14 ` Tang Yizhou
2024-10-09 14:55 ` Jan Kara
2024-10-10 3:26 ` Tang Yizhou
2024-10-02 13:00 ` [PATCH 2/3] mm/page-writeback.c: Fix comment of wb_domain_writeout_add() Tang Yizhou
2024-10-03 12:16 ` Jan Kara [this message]
2024-10-02 13:00 ` [PATCH 3/3] xfs: Fix comment of xfs_buffered_write_iomap_begin() Tang Yizhou
2024-10-02 13:45 ` Christoph Hellwig
2024-10-06 14:28 ` Tang Yizhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003121635.l7wpciq2jnoh7sq2@quack3 \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=chandan.babu@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
--cc=yizhou.tang@shopee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®