From: Bryan Brattlof <bb@ti.com>
To: Andrew Davis <afd@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 2/5] arm64: dts: ti: k3-am625-sk: Add M4F remoteproc node
Date: Thu, 3 Oct 2024 16:06:06 -0500 [thread overview]
Message-ID: <20241003210606.2k7wyssklwfziod4@bryanbrattlof.com> (raw)
In-Reply-To: <20241003170118.24932-3-afd@ti.com>
Hi Andrew!
On October 3, 2024 thus sayeth Andrew Davis:
> From: Hari Nagalla <hnagalla@ti.com>
>
> The AM62x SoCs of the TI K3 family have a Cortex M4F core in the MCU
> domain. This core can be used by non safety applications as a remote
> processor. When used as a remote processor with virtio/rpmessage IPC,
> two carveout reserved memory nodes are needed. The first region is used
> as a DMA pool for the rproc device, and the second region will furnish
> the static carveout regions for the firmware memory.
>
> The current carveout addresses and sizes are defined statically for
> each rproc device. The M4F processor does not have an MMU, and as such
> requires the exact memory used by the firmware to be set-aside.
>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> index 44ff67b6bf1e4..6957b3e44c82f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> @@ -56,6 +56,18 @@ linux,cma {
> linux,cma-default;
> };
>
> + mcu_m4fss_dma_memory_region: m4f-dma-memory@9cb00000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x9cb00000 0x00 0x100000>;
> + no-map;
> + };
> +
> + mcu_m4fss_memory_region: m4f-memory@9cc00000 {
> + compatible = "shared-dma-pool";
> + reg = <0x00 0x9cc00000 0x00 0xe00000>;
> + no-map;
> + };
> +
The only issue I have here is this takes away memory from people who do
not use these firmware or causes them to work around this patch if they
choose to have different carveouts.
Would an overlay be appropriate for this?
~Bryan
next prev parent reply other threads:[~2024-10-03 21:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 17:01 [PATCH v12 0/5] TI K3 M4F support on AM62 and AM64 SoCs Andrew Davis
2024-10-03 17:01 ` [PATCH v12 1/5] arm64: dts: ti: k3-am62: Add M4F remoteproc node Andrew Davis
2024-10-03 17:01 ` [PATCH v12 2/5] arm64: dts: ti: k3-am625-sk: " Andrew Davis
2024-10-03 21:06 ` Bryan Brattlof [this message]
2024-10-04 11:26 ` Nishanth Menon
2024-10-04 11:52 ` Andrew Davis
2024-10-03 17:01 ` [PATCH v12 3/5] arm64: dts: ti: k3-am64: " Andrew Davis
2024-10-03 17:01 ` [PATCH v12 4/5] arm64: dts: ti: k3-am642-sk: " Andrew Davis
2024-10-03 17:01 ` [PATCH v12 5/5] arm64: dts: ti: k3-am642-evm: " Andrew Davis
2024-10-28 15:05 ` [PATCH v12 0/5] TI K3 M4F support on AM62 and AM64 SoCs Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003210606.2k7wyssklwfziod4@bryanbrattlof.com \
--to=bb@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®