From: Jan Kara <jack@suse.cz>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acl: Realign struct posix_acl to reduce its size by 8 bytes
Date: Fri, 4 Oct 2024 15:37:16 +0200 [thread overview]
Message-ID: <20241004133716.enkqnmosn42oagos@quack3> (raw)
In-Reply-To: <20241004103401.38579-2-thorsten.blum@linux.dev>
On Fri 04-10-24 12:33:57, Thorsten Blum wrote:
> Reduce posix_acl's struct size by 8 bytes by realigning its members.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/posix_acl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
> index 83b2c5fba1d9..e2d47eb1a7f3 100644
> --- a/include/linux/posix_acl.h
> +++ b/include/linux/posix_acl.h
> @@ -28,8 +28,8 @@ struct posix_acl_entry {
>
> struct posix_acl {
> refcount_t a_refcount;
> - struct rcu_head a_rcu;
> unsigned int a_count;
> + struct rcu_head a_rcu;
> struct posix_acl_entry a_entries[] __counted_by(a_count);
> };
>
> --
> 2.46.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-10-04 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 10:33 Thorsten Blum
2024-10-04 13:37 ` Jan Kara [this message]
2024-10-04 20:11 ` Thorsten Blum
2024-10-04 21:12 ` Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004133716.enkqnmosn42oagos@quack3 \
--to=jack@suse.cz \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®