mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>, Sasha Levin <sashal@kernel.org>,
	mturquette@baylibre.com, linux-clk@vger.kernel.org
Subject: [PATCH AUTOSEL 5.15 16/31] clk: bcm: bcm53573: fix OF node leak in init
Date: Fri,  4 Oct 2024 14:28:24 -0400	[thread overview]
Message-ID: <20241004182854.3674661-16-sashal@kernel.org> (raw)
In-Reply-To: <20241004182854.3674661-1-sashal@kernel.org>

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

[ Upstream commit f92d67e23b8caa81f6322a2bad1d633b00ca000e ]

Driver code is leaking OF node reference from of_get_parent() in
bcm53573_ilp_init().  Usage of of_get_parent() is not needed in the
first place, because the parent node will not be freed while we are
processing given node (triggered by CLK_OF_DECLARE()).  Thus fix the
leak by accessing parent directly, instead of of_get_parent().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240826065801.17081-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/clk/bcm/clk-bcm53573-ilp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/bcm/clk-bcm53573-ilp.c b/drivers/clk/bcm/clk-bcm53573-ilp.c
index 84f2af736ee8a..83ef41d618be3 100644
--- a/drivers/clk/bcm/clk-bcm53573-ilp.c
+++ b/drivers/clk/bcm/clk-bcm53573-ilp.c
@@ -112,7 +112,7 @@ static void bcm53573_ilp_init(struct device_node *np)
 		goto err_free_ilp;
 	}
 
-	ilp->regmap = syscon_node_to_regmap(of_get_parent(np));
+	ilp->regmap = syscon_node_to_regmap(np->parent);
 	if (IS_ERR(ilp->regmap)) {
 		err = PTR_ERR(ilp->regmap);
 		goto err_free_ilp;
-- 
2.43.0


  parent reply	other threads:[~2024-10-04 18:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 18:28 [PATCH AUTOSEL 5.15 01/31] bpf: Check percpu map value size first Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 02/31] s390/boot: Compile all files with the same march flag Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 03/31] s390/facility: Disable compile time optimization for decompressor code Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 04/31] s390/mm: Add cond_resched() to cmm_alloc/free_pages() Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 05/31] bpf, x64: Fix a jit convergence issue Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 06/31] ext4: fix i_data_sem unlock order in ext4_ind_migrate() Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 07/31] ext4: avoid use-after-free in ext4_ext_show_leaf() Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 08/31] ext4: ext4_search_dir should return a proper error Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 09/31] ext4: don't set SB_RDONLY after filesystem errors Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 10/31] ext4: nested locking for xattr inode Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 11/31] s390/cpum_sf: Remove WARN_ON_ONCE statements Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 12/31] ktest.pl: Avoid false positives with grub2 skip regex Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 13/31] RDMA/mad: Improve handling of timed out WRs of mad agent Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 14/31] PCI: Add function 0 DMA alias quirk for Glenfly Arise chip Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 15/31] RDMA/rtrs-srv: Avoid null pointer deref during path establishment Sasha Levin
2024-10-04 18:28 ` Sasha Levin [this message]
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 17/31] PCI: Add ACS quirk for Qualcomm SA8775P Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 18/31] i2c: i801: Use a different adapter-name for IDF adapters Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 19/31] PCI: Mark Creative Labs EMU20k2 INTx masking as broken Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 20/31] ntb: ntb_hw_switchtec: Fix use after free vulnerability in switchtec_ntb_remove due to race condition Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 21/31] media: videobuf2-core: clear memory related fields in __vb2_plane_dmabuf_put() Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 22/31] remoteproc: imx_rproc: Use imx specific hook for find_loaded_rsc_table Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 23/31] clk: imx: Remove CLK_SET_PARENT_GATE for DRAM mux for i.MX7D Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 24/31] usb: chipidea: udc: enable suspend interrupt after usb reset Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 25/31] usb: dwc2: Adjust the timing of USB Driver Interrupt Registration in the Crashkernel Scenario Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 26/31] comedi: ni_routing: tools: Check when the file could not be opened Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 27/31] virtio_pmem: Check device status before requesting flush Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 28/31] tools/iio: Add memory allocation failure check for trigger_name Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 29/31] driver core: bus: Return -EIO instead of 0 when show/store invalid bus attribute Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 30/31] drm/amd/display: Check null pointer before dereferencing se Sasha Levin
2024-10-04 18:28 ` [PATCH AUTOSEL 5.15 31/31] fbdev: sisfb: Fix strbuf array overflow Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241004182854.3674661-16-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®