From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D19181E25EE; Fri, 4 Oct 2024 18:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066582; cv=none; b=NR7pglQB1Vdg5uvpSI0m+cCiLdSe5yOyZCcGlYsm0zn+sxbZqMDyNFkUZO/WkBCyh4WOTbFHj6oPgYi57CqflcX6U8JFpCP/na5brIgLi7mkXl/X/sbdsXY+X0UXp0xB8tfskHqxvmA6iWTkKfyCxQUtAyx3joOj4+zDurESVxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066582; c=relaxed/simple; bh=23AYrvH6m7KzyPtR5dF5yMTUmucHtURniMfelumR7nQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sZxWFYJwTzykinJl2Q7zaGFEBH35lgChBSKzevH1qtz+cvXfW/kCuz0XKqr4ckyTfQoeUnooj30BjaC15D0roOPuXJ/KJMw0tImaMe8gX07SVj7SWQVtelMvxBvaWXsGfJSJvl0vCNl49JKd3AntKWi+rIPfGFuSac8sA/xzK5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Dth1fvgt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dth1fvgt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 662B6C4CEC6; Fri, 4 Oct 2024 18:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728066582; bh=23AYrvH6m7KzyPtR5dF5yMTUmucHtURniMfelumR7nQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dth1fvgtkS3e1pYFjfs4HN+BWg12Oyb5cDISOnwFH56pXoUj59bFPtMSdzmzCJoC4 QXB6ax+KenyCUizT5DQpb3IcIJLIVqUoLVLCyWr7iyEe+y2ZZppJJBkA7VUwhrGrqX pvT78D3zzE1GBoEE95T500mdBqAnpdH8kE22FhmxcpjkyzQgR3aqm5HxhzlJsVKeWB 3MC9pIAXwn3xmMPXXHbHXnijU6sYzfD/n0bCAcwmO7VWxyyL+o6+zYuQOf6kXmZC9L mqAtidDCJTBosB3AlzH9sB9BBRkiodbd2YPfdQcao+kv1ZS/VxzjMGsFCvroNfuLbG ofQpvLo/jkptw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Philip Chen , "Michael S . Tsirkin" , Sasha Levin , pankaj.gupta.linux@gmail.com, dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, ira.weiny@intel.com, virtualization@lists.linux.dev, nvdimm@lists.linux.dev Subject: [PATCH AUTOSEL 5.15 27/31] virtio_pmem: Check device status before requesting flush Date: Fri, 4 Oct 2024 14:28:35 -0400 Message-ID: <20241004182854.3674661-27-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241004182854.3674661-1-sashal@kernel.org> References: <20241004182854.3674661-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.167 Content-Transfer-Encoding: 8bit From: Philip Chen [ Upstream commit e25fbcd97cf52c3c9824d44b5c56c19673c3dd50 ] If a pmem device is in a bad status, the driver side could wait for host ack forever in virtio_pmem_flush(), causing the system to hang. So add a status check in the beginning of virtio_pmem_flush() to return early if the device is not activated. Signed-off-by: Philip Chen Message-Id: <20240826215313.2673566-1-philipchen@chromium.org> Signed-off-by: Michael S. Tsirkin Acked-by: Pankaj Gupta --- drivers/nvdimm/nd_virtio.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c index 10351d5b49fac..41e97c6567cf9 100644 --- a/drivers/nvdimm/nd_virtio.c +++ b/drivers/nvdimm/nd_virtio.c @@ -44,6 +44,15 @@ static int virtio_pmem_flush(struct nd_region *nd_region) unsigned long flags; int err, err1; + /* + * Don't bother to submit the request to the device if the device is + * not activated. + */ + if (vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_NEEDS_RESET) { + dev_info(&vdev->dev, "virtio pmem device needs a reset\n"); + return -EIO; + } + might_sleep(); req_data = kmalloc(sizeof(*req_data), GFP_KERNEL); if (!req_data) -- 2.43.0