From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Guo Ren <guoren@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Nick Terrell <terrelln@fb.com>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Guilherme Amadio <amadio@gentoo.org>,
Changbin Du <changbin.du@huawei.com>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Daniel Wagner <dwagner@suse.de>,
Aditya Gupta <adityag@linux.ibm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Kajol Jain <kjain@linux.ibm.com>,
Huacai Chen <chenhuacai@kernel.org>,
Bibo Mao <maobibo@loongson.cn>, Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@rivosinc.com>,
Shenlin Liang <liangshenlin@eswincomputing.com>,
Oliver Upton <oliver.upton@linux.dev>,
"Steinar H. Gunderson" <sesse@google.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Chen Pei <cp0613@linux.alibaba.com>,
Dima Kogan <dima@secretsauce.net>,
Yury Norov <yury.norov@gmail.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: [PATCH v2 01/31] perf build: Fix !HAVE_DWARF_GETLOCATIONS_SUPPORT
Date: Sat, 5 Oct 2024 12:55:11 -0700 [thread overview]
Message-ID: <20241005195541.380070-2-irogers@google.com> (raw)
In-Reply-To: <20241005195541.380070-1-irogers@google.com>
Testing with a LIBDW_DIR showed some issues. In dwarf-aux.h if
HAVE_DWARF_GETLOCATIONS_SUPPORT isn't defined then the code uses an
undefined errno value, so add errno.h.
In Makefile.config the dwarf feature tests need the LIBDW_DIR setting
in the CFLAGS/LDFLAGS.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/Makefile.config | 6 ++++++
tools/perf/util/dwarf-aux.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 4dcf7a0fd235..5e26d3a91b36 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -159,8 +159,14 @@ ifeq ($(findstring -static,${LDFLAGS}),-static)
DWARFLIBS += -lebl
endif
endif
+FEATURE_CHECK_CFLAGS-dwarf := $(LIBDW_CFLAGS)
+FEATURE_CHECK_LDFLAGS-dwarf := $(LIBDW_LDFLAGS) $(DWARFLIBS)
FEATURE_CHECK_CFLAGS-libdw-dwarf-unwind := $(LIBDW_CFLAGS)
FEATURE_CHECK_LDFLAGS-libdw-dwarf-unwind := $(LIBDW_LDFLAGS) $(DWARFLIBS)
+FEATURE_CHECK_CFLAGS-dwarf_getlocations := $(LIBDW_CFLAGS)
+FEATURE_CHECK_LDFLAGS-dwarf_getlocations := $(LIBDW_LDFLAGS) $(DWARFLIBS)
+FEATURE_CHECK_CFLAGS-dwarf_getcfi := $(LIBDW_CFLAGS)
+FEATURE_CHECK_LDFLAGS-dwarf_getcfi := $(LIBDW_LDFLAGS) $(DWARFLIBS)
# for linking with debug library, run like:
# make DEBUG=1 LIBBABELTRACE_DIR=/opt/libbabeltrace/
diff --git a/tools/perf/util/dwarf-aux.h b/tools/perf/util/dwarf-aux.h
index 336a3a183a78..925a9bb9fb15 100644
--- a/tools/perf/util/dwarf-aux.h
+++ b/tools/perf/util/dwarf-aux.h
@@ -177,6 +177,7 @@ void die_collect_vars(Dwarf_Die *sc_die, struct die_var_type **var_types);
void die_collect_global_vars(Dwarf_Die *cu_die, struct die_var_type **var_types);
#else /* HAVE_DWARF_GETLOCATIONS_SUPPORT */
+#include <errno.h>
static inline int die_get_var_range(Dwarf_Die *sp_die __maybe_unused,
Dwarf_Die *vr_die __maybe_unused,
--
2.47.0.rc0.187.ge670bccf7e-goog
next prev parent reply other threads:[~2024-10-05 19:56 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 19:55 [PATCH v2 00/31] Libdw/dwarf build clean up Ian Rogers
2024-10-05 19:55 ` Ian Rogers [this message]
2024-10-05 19:55 ` [PATCH v2 02/31] perf build: Rename NO_DWARF to NO_LIBDW Ian Rogers
2024-10-05 19:55 ` [PATCH v2 03/31] perf build: Remove defined but never used variable Ian Rogers
2024-10-05 19:55 ` [PATCH v2 04/31] perf build: Rename test-dwarf to test-libdw Ian Rogers
2024-10-05 19:55 ` [PATCH v2 05/31] perf build: Combine libdw-dwarf-unwind into libdw feature tests Ian Rogers
2024-10-05 19:55 ` [PATCH v2 06/31] perf build: Combine test-dwarf-getlocations into test-libdw Ian Rogers
2024-10-05 19:55 ` [PATCH v2 07/31] perf build: Combine test-dwarf-getcfi " Ian Rogers
2024-10-05 19:55 ` [PATCH v2 08/31] perf probe: Move elfutils support check to libdw check Ian Rogers
2024-10-05 19:55 ` [PATCH v2 09/31] perf libdw: Remove unnecessary defines Ian Rogers
2024-10-05 19:55 ` [PATCH v2 10/31] perf build: Rename HAVE_DWARF_SUPPORT to HAVE_LIBDW_SUPPORT Ian Rogers
2024-10-05 19:55 ` [PATCH v2 11/31] perf build: Rename CONFIG_DWARF to CONFIG_LIBDW Ian Rogers
2024-10-05 19:55 ` [PATCH v2 12/31] perf bpf-prologue: Remove unused file Ian Rogers
2024-10-05 19:55 ` [PATCH v2 13/31] perf dwarf-regs: Remove PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET Ian Rogers
2024-10-05 19:55 ` [PATCH v2 14/31] perf dwarf-regs: Add EM_HOST and EF_HOST defines Ian Rogers
2024-10-05 19:55 ` [PATCH v2 15/31] perf disasm: Add e_machine/e_flags to struct arch Ian Rogers
2024-10-05 19:55 ` [PATCH v2 16/31] perf dwarf-regs: Pass accurate disassembly machine to get_dwarf_regnum Ian Rogers
2024-10-07 8:07 ` Masami Hiramatsu
2024-10-07 15:46 ` Ian Rogers
2024-11-07 19:18 ` Namhyung Kim
2024-10-05 19:55 ` [PATCH v2 17/31] perf dwarf-regs: Pass ELF flags to get_dwarf_regstr Ian Rogers
2024-10-07 8:09 ` Masami Hiramatsu
2024-10-07 15:05 ` Ian Rogers
2024-11-07 19:24 ` Namhyung Kim
2024-10-05 19:55 ` [PATCH v2 18/31] perf dwarf-regs: Move x86 dwarf-regs out of arch Ian Rogers
2024-10-07 8:34 ` Masami Hiramatsu
2024-10-07 15:32 ` Ian Rogers
2024-10-05 19:55 ` [PATCH v2 19/31] perf arm64: Remove dwarf-regs.c Ian Rogers
2024-10-07 8:19 ` Masami Hiramatsu
2024-10-05 19:55 ` [PATCH v2 20/31] perf arm: " Ian Rogers
2024-10-05 19:55 ` [PATCH v2 21/31] perf dwarf-regs: Move csky dwarf-regs out of arch Ian Rogers
2024-10-05 19:55 ` [PATCH v2 22/31] perf loongarch: Remove dwarf-regs.c Ian Rogers
2024-10-05 19:55 ` [PATCH v2 23/31] perf mips: " Ian Rogers
2024-10-05 19:55 ` [PATCH v2 24/31] perf dwarf-regs: Move powerpc dwarf-regs out of arch Ian Rogers
2024-10-05 19:55 ` [PATCH v2 25/31] perf riscv: Remove dwarf-regs.c and add dwarf-regs-table.h Ian Rogers
2024-10-05 19:55 ` [PATCH v2 26/31] perf s390: Remove dwarf-regs.c Ian Rogers
2024-10-05 19:55 ` [PATCH v2 27/31] perf sh: " Ian Rogers
2024-10-05 19:55 ` [PATCH v2 28/31] perf sparc: " Ian Rogers
2024-10-05 19:55 ` [PATCH v2 29/31] perf xtensa: " Ian Rogers
2024-10-05 19:55 ` [PATCH v2 30/31] perf dwarf-regs: Remove get_arch_regstr code Ian Rogers
2024-10-05 19:55 ` [PATCH v2 31/31] perf build: Remove PERF_HAVE_DWARF_REGS Ian Rogers
2024-10-16 17:21 ` [PATCH v2 00/31] Libdw/dwarf build clean up Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241005195541.380070-2-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adityag@linux.ibm.com \
--cc=adrian.hunter@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=amadio@gentoo.org \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@rivosinc.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bristot@kernel.org \
--cc=changbin.du@huawei.com \
--cc=chenhuacai@kernel.org \
--cc=cp0613@linux.alibaba.com \
--cc=dima@secretsauce.net \
--cc=dwagner@suse.de \
--cc=guoren@kernel.org \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linux.dev \
--cc=liangshenlin@eswincomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@treblig.org \
--cc=maobibo@loongson.cn \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sesse@google.com \
--cc=terrelln@fb.com \
--cc=will@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome