mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Menglong Dong <menglong8.dong@gmail.com>
To: edumazet@google.com, kuba@kernel.org
Cc: davem@davemloft.net, pabeni@redhat.com, dsahern@kernel.org,
	steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
	dongml2@chinatelecom.cn, bigeasy@linutronix.de, toke@redhat.com,
	idosch@nvidia.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH net-next v2 0/7] net: ip: add drop reasons to input route
Date: Mon,  7 Oct 2024 15:46:55 +0800	[thread overview]
Message-ID: <20241007074702.249543-1-dongml2@chinatelecom.cn> (raw)

In this series, we mainly add some skb drop reasons to the input path of
ip routing.

The errno from fib_validate_source() is -EINVAL or -EXDEV, and -EXDEV is
used in ip_rcv_finish_core() to increase the LINUX_MIB_IPRPFILTER. For
this case, we can check it by
"drop_reason == SKB_DROP_REASON_IP_RPFILTER" instead. Therefore, we can
make fib_validate_source() return -reason.

Meanwhile, we make the following functions return drop reasons too:

  ip_route_input_mc()
  ip_mc_validate_source()
  ip_route_input_slow()
  ip_route_input_rcu()
  ip_route_input_noref()
  ip_route_input()

And following new skb drop reasons are added:

  SKB_DROP_REASON_IP_LOCAL_SOURCE
  SKB_DROP_REASON_IP_INVALID_SOURCE
  SKB_DROP_REASON_IP_LOCALNET
  SKB_DROP_REASON_IP_INVALID_DEST

Changes since v1:
- make ip_route_input_noref/ip_route_input_rcu/ip_route_input_slow return
  drop reasons, instead of passing a local variable to their function
  arguments.

Menglong Dong (7):
  net: ip: make fib_validate_source() return drop reason
  net: ip: make ip_route_input_mc() return drop reason
  net: ip: make ip_mc_validate_source() return drop reason
  net: ip: make ip_route_input_slow() return drop reasons
  net: ip: make ip_route_input_rcu() return drop reasons
  net: ip: make ip_route_input_noref() return drop reasons
  net: ip: make ip_route_input() return drop reasons

 include/net/dropreason-core.h   |  19 +++++
 include/net/route.h             |  27 ++++---
 net/bridge/br_netfilter_hooks.c |  11 +--
 net/core/lwt_bpf.c              |   1 +
 net/ipv4/fib_frontend.c         |  19 +++--
 net/ipv4/icmp.c                 |   1 +
 net/ipv4/ip_fragment.c          |  12 +--
 net/ipv4/ip_input.c             |  11 ++-
 net/ipv4/route.c                | 131 +++++++++++++++++++-------------
 9 files changed, 145 insertions(+), 87 deletions(-)

-- 
2.39.5


             reply	other threads:[~2024-10-07  7:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-07  7:46 Menglong Dong [this message]
2024-10-07  7:46 ` [PATCH net-next v2 1/7] net: ip: make fib_validate_source() return drop reason Menglong Dong
2024-10-10  8:25   ` Paolo Abeni
2024-10-10  9:18     ` Menglong Dong
2024-10-11  6:42       ` Menglong Dong
2024-10-11  8:49         ` Paolo Abeni
2024-10-11  9:17           ` Menglong Dong
2024-10-07  7:46 ` [PATCH net-next v2 2/7] net: ip: make ip_route_input_mc() " Menglong Dong
2024-10-07  7:46 ` [PATCH net-next v2 3/7] net: ip: make ip_mc_validate_source() " Menglong Dong
2024-10-07  7:46 ` [PATCH net-next v2 4/7] net: ip: make ip_route_input_slow() return drop reasons Menglong Dong
2024-10-07  7:47 ` [PATCH net-next v2 5/7] net: ip: make ip_route_input_rcu() " Menglong Dong
2024-10-07  7:47 ` [PATCH net-next v2 6/7] net: ip: make ip_route_input_noref() " Menglong Dong
2024-10-07  7:47 ` [PATCH net-next v2 7/7] net: ip: make ip_route_input() " Menglong Dong
2024-10-10  8:30 ` [PATCH net-next v2 0/7] net: ip: add drop reasons to input route Paolo Abeni
2024-10-10 10:32   ` Menglong Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241007074702.249543-1-dongml2@chinatelecom.cn \
    --to=menglong8.dong@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=dongml2@chinatelecom.cn \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=steffen.klassert@secunet.com \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®