From: Peter Zijlstra <peterz@infradead.org>
To: bigeasy@linutronix.de, tglx@linutronix.de, mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
ankur.a.arora@oracle.com, efault@gmx.de
Subject: [PATCH 3/5] sched: Enable PREEMPT_DYNAMIC for PREEMPT_RT
Date: Mon, 07 Oct 2024 09:46:12 +0200 [thread overview]
Message-ID: <20241007075055.441622332@infradead.org> (raw)
In-Reply-To: <20241007074609.447006177@infradead.org>
In order to enable PREEMPT_DYNAMIC for PREEMPT_RT, remove PREEMPT_RT
from the 'Preemption Model' choice. Strictly speaking PREEMPT_RT is
not a change in how preemption works, but rather it makes a ton more
code preemptible.
Notably, take away NONE and VOLATILE options for PREEMPT_RT, they make
no sense (but are techincally possible).
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
kernel/Kconfig.preempt | 12 +++++++-----
kernel/sched/core.c | 2 ++
kernel/sched/debug.c | 4 ++--
3 files changed, 11 insertions(+), 7 deletions(-)
--- a/kernel/Kconfig.preempt
+++ b/kernel/Kconfig.preempt
@@ -20,6 +20,7 @@ choice
config PREEMPT_NONE
bool "No Forced Preemption (Server)"
+ depends on !PREEMPT_RT
select PREEMPT_NONE_BUILD if !PREEMPT_DYNAMIC
help
This is the traditional Linux preemption model, geared towards
@@ -35,6 +36,7 @@ config PREEMPT_NONE
config PREEMPT_VOLUNTARY
bool "Voluntary Kernel Preemption (Desktop)"
depends on !ARCH_NO_PREEMPT
+ depends on !PREEMPT_RT
select PREEMPT_VOLUNTARY_BUILD if !PREEMPT_DYNAMIC
help
This option reduces the latency of the kernel by adding more
@@ -54,7 +56,7 @@ config PREEMPT_VOLUNTARY
config PREEMPT
bool "Preemptible Kernel (Low-Latency Desktop)"
depends on !ARCH_NO_PREEMPT
- select PREEMPT_BUILD
+ select PREEMPT_BUILD if !PREEMPT_DYNAMIC
help
This option reduces the latency of the kernel by making
all kernel code (that is not executing in a critical section)
@@ -74,7 +76,7 @@ config PREEMPT_LAZY
bool "Scheduler controlled preemption model"
depends on !ARCH_NO_PREEMPT
depends on ARCH_HAS_PREEMPT_LAZY
- select PREEMPT_BUILD
+ select PREEMPT_BUILD if !PREEMPT_DYNAMIC
help
This option provides a scheduler driven preemption model that
is fundamentally similar to full preemption, but is less
@@ -82,6 +84,8 @@ config PREEMPT_LAZY
reduce lock holder preemption and recover some of the performance
gains seen from using Voluntary preemption.
+endchoice
+
config PREEMPT_RT
bool "Fully Preemptible Kernel (Real-Time)"
depends on EXPERT && ARCH_SUPPORTS_RT
@@ -99,8 +103,6 @@ config PREEMPT_RT
Select this if you are building a kernel for systems which
require real-time guarantees.
-endchoice
-
config PREEMPT_COUNT
bool
@@ -110,7 +112,7 @@ config PREEMPTION
config PREEMPT_DYNAMIC
bool "Preemption behaviour defined on boot"
- depends on HAVE_PREEMPT_DYNAMIC && !PREEMPT_RT
+ depends on HAVE_PREEMPT_DYNAMIC
select JUMP_LABEL if HAVE_PREEMPT_DYNAMIC_KEY
select PREEMPT_BUILD
default y if HAVE_PREEMPT_DYNAMIC_CALL
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7406,11 +7406,13 @@ int preempt_dynamic_mode = preempt_dynam
int sched_dynamic_mode(const char *str)
{
+#ifndef CONFIG_PREEMPT_RT
if (!strcmp(str, "none"))
return preempt_dynamic_none;
if (!strcmp(str, "voluntary"))
return preempt_dynamic_voluntary;
+#endif
if (!strcmp(str, "full"))
return preempt_dynamic_full;
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -248,9 +248,9 @@ static int sched_dynamic_show(struct seq
"none", "voluntary", "full", "lazy",
};
int j = ARRAY_SIZE(preempt_modes) - !IS_ENABLED(CONFIG_ARCH_HAS_PREEMPT_LAZY);
- int i;
+ int i = IS_ENABLED(CONFIG_PREEMPT_RT) * 2;
- for (i = 0; i < j; i++) {
+ for (; i < j; i++) {
if (preempt_dynamic_mode == i)
seq_puts(m, "(");
seq_puts(m, preempt_modes[i]);
next prev parent reply other threads:[~2024-10-07 7:51 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 7:46 [PATCH 0/5] sched: Lazy preemption muck Peter Zijlstra
2024-10-07 7:46 ` [PATCH 1/5] sched: Add TIF_NEED_RESCHED_LAZY infrastructure Peter Zijlstra
2024-10-09 12:18 ` Sebastian Andrzej Siewior
2024-10-09 13:01 ` Peter Zijlstra
2024-11-06 10:48 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2024-10-07 7:46 ` [PATCH 2/5] sched: Add Lazy preemption model Peter Zijlstra
2024-10-08 5:43 ` Ankur Arora
2024-10-08 14:48 ` Peter Zijlstra
2024-10-09 8:50 ` Sebastian Andrzej Siewior
2024-10-09 9:14 ` Peter Zijlstra
2024-10-09 9:19 ` Sebastian Andrzej Siewior
2024-10-15 14:37 ` Shrikanth Hegde
2024-10-25 10:42 ` Sebastian Andrzej Siewior
2024-10-22 16:44 ` Shrikanth Hegde
2024-10-25 13:19 ` Sebastian Andrzej Siewior
2024-10-29 18:57 ` Shrikanth Hegde
2024-11-06 10:48 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2024-10-07 7:46 ` Peter Zijlstra [this message]
2024-10-08 13:24 ` [PATCH 3/5] sched: Enable PREEMPT_DYNAMIC for PREEMPT_RT Sebastian Andrzej Siewior
2024-10-08 14:40 ` Peter Zijlstra
2024-10-10 6:52 ` Christoph Hellwig
2024-10-10 7:50 ` Peter Zijlstra
2024-11-06 10:48 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2024-10-07 7:46 ` [PATCH 4/5] sched, x86: Enable Lazy preemption Peter Zijlstra
2024-11-06 10:48 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2024-10-07 7:46 ` [PATCH 5/5] sched: Add laziest preempt model Peter Zijlstra
2024-10-08 5:59 ` Ankur Arora
2024-10-08 14:23 ` Thomas Gleixner
2024-10-08 14:40 ` Peter Zijlstra
2024-10-08 15:07 ` Sebastian Andrzej Siewior
2024-10-07 8:33 ` [PATCH 0/5] sched: Lazy preemption muck Sebastian Andrzej Siewior
2024-10-08 4:58 ` Mike Galbraith
2024-10-08 15:32 ` Sebastian Andrzej Siewior
2024-10-09 4:40 ` Ankur Arora
2024-10-09 6:20 ` Sebastian Andrzej Siewior
2024-10-09 7:23 ` Ankur Arora
2024-10-09 8:02 ` Peter Zijlstra
2024-10-09 8:45 ` Sebastian Andrzej Siewior
2024-10-09 14:01 ` Steven Rostedt
2024-10-09 20:13 ` Thomas Gleixner
2024-10-09 20:43 ` Steven Rostedt
2024-10-09 21:06 ` Thomas Gleixner
2024-10-09 21:19 ` Steven Rostedt
2024-10-09 23:16 ` Thomas Gleixner
2024-10-09 23:29 ` Steven Rostedt
2024-10-10 1:20 ` Thomas Gleixner
2024-10-10 10:23 ` David Laight
2024-10-13 19:02 ` Thomas Gleixner
2024-10-14 8:21 ` David Laight
2024-10-10 3:12 ` Tianchen Ding
2024-10-10 7:47 ` Thomas Gleixner
2024-10-09 7:30 ` Ankur Arora
2024-10-09 7:46 ` Peter Zijlstra
2024-10-09 11:07 ` Sebastian Andrzej Siewior
2024-10-17 12:36 ` Mike Galbraith
2024-11-07 17:21 ` Thomas Meyer
2024-11-08 0:59 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007075055.441622332@infradead.org \
--to=peterz@infradead.org \
--cc=ankur.a.arora@oracle.com \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=efault@gmx.de \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®