From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Zhouyi Zhou <zhouzhouyi@gmail.com>,
linux-kernel@vger.kernel.org, mingo@redhat.com,
juri.lelli@redhat.com, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com
Subject: Re: [PATCH] sched: Fix typo of head comment of ___update_load_avg
Date: Mon, 7 Oct 2024 10:10:15 +0200 [thread overview]
Message-ID: <20241007081015.GF18071@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKfTPtD7TPYcPcwHxC_n8PObZMgqxU+9=U-F6yJbP0=cLAB8hQ@mail.gmail.com>
On Mon, Oct 07, 2024 at 08:42:14AM +0200, Vincent Guittot wrote:
> On Sat, 5 Oct 2024 at 02:53, Zhouyi Zhou <zhouzhouyi@gmail.com> wrote:
> >
> > The head comment of ___update_load_avg illustrates the principle of
> > PELT divider. "unwanted oscillation in the range [1002..1024[" should
> > be "unwanted oscillation in the range [1002..1024]".
> >
> > Fix above typo.
>
> This is not a typo as 1024 is an excluded endpoint of the interval.
> Some may use [1002..1024) but both [1002..1024[ and [1002..1024) can
> be used
Because I'm weird, I googled this, and the [a,b[ notation is from
Bourbaki and hence popular in the French speaking world :-)
We don't have many intervals specified in comments and hence we can't
make the inconsistent style argument either.
So yeah, let it be.. at best its a trigger to get people to better look
at the code. At worst its one of those triggers that people keep trying
to mindlessly 'fix', like my use of borken :-)
next prev parent reply other threads:[~2024-10-07 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 0:52 Zhouyi Zhou
2024-10-07 6:42 ` Vincent Guittot
2024-10-07 8:10 ` Peter Zijlstra [this message]
2024-10-07 8:15 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007081015.GF18071@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®