From: Lucas De Marchi <lucas.demarchi@intel.com>
To: linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
Ian Rogers <irogers@google.com>,
Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH 2/5] perf: Move free outside of the mutex
Date: Tue, 8 Oct 2024 13:34:58 -0500 [thread overview]
Message-ID: <20241008183501.1354695-3-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20241008183501.1354695-1-lucas.demarchi@intel.com>
It's not needed to hold the mutex to free the percpu variables stored in
pmu. Move them outside of the mutex protection in preparation for
possibly allowing them to live longer, according to the lifecycle of the
object owning/containing the pmu.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
kernel/events/core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 3b8b85adb10a..6395dbf67671 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -11845,7 +11845,6 @@ void perf_pmu_unregister(struct pmu *pmu)
synchronize_srcu(&pmus_srcu);
synchronize_rcu();
- free_percpu(pmu->pmu_disable_count);
idr_remove(&pmu_idr, pmu->type);
if (pmu_bus_running && pmu->dev && pmu->dev != PMU_NULL_DEV) {
if (pmu->nr_addr_filters)
@@ -11853,8 +11852,11 @@ void perf_pmu_unregister(struct pmu *pmu)
device_del(pmu->dev);
put_device(pmu->dev);
}
- free_pmu_context(pmu);
+
mutex_unlock(&pmus_lock);
+
+ free_percpu(pmu->pmu_disable_count);
+ free_pmu_context(pmu);
}
EXPORT_SYMBOL_GPL(perf_pmu_unregister);
--
2.46.2
next prev parent reply other threads:[~2024-10-08 18:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 18:34 [PATCH 0/5] perf: Fix pmu for drivers with bind/unbind Lucas De Marchi
2024-10-08 18:34 ` [PATCH 1/5] perf: Add dummy pmu module Lucas De Marchi
2024-10-15 0:26 ` Jeff Johnson
2024-10-15 4:23 ` Lucas De Marchi
2024-10-16 8:51 ` Peter Zijlstra
2024-10-18 19:30 ` Lucas De Marchi
2024-10-08 18:34 ` Lucas De Marchi [this message]
2024-10-08 18:34 ` [PATCH 3/5] perf: Add pmu get/put Lucas De Marchi
2024-10-09 10:44 ` kernel test robot
2024-10-14 17:32 ` Peter Zijlstra
2024-10-14 18:20 ` Lucas De Marchi
2024-10-14 19:25 ` Peter Zijlstra
2024-10-14 20:12 ` Lucas De Marchi
2024-10-16 12:03 ` Peter Zijlstra
2024-10-18 19:46 ` Lucas De Marchi
2024-10-22 21:52 ` Peter Zijlstra
2024-10-23 5:07 ` Lucas De Marchi
2024-10-31 5:07 ` Lucas De Marchi
2024-10-31 9:45 ` Peter Zijlstra
2024-10-08 18:35 ` [PATCH 4/5] perf/dummy_pmu: Tie pmu to device lifecycle Lucas De Marchi
2024-10-08 18:35 ` [PATCH 5/5] perf/dummy_pmu: Track and disable active events Lucas De Marchi
2024-10-11 22:21 ` [PATCH 0/5] perf: Fix pmu for drivers with bind/unbind Umesh Nerlige Ramappa
2024-10-11 23:03 ` Lucas De Marchi
2024-10-11 22:59 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008183501.1354695-3-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=acme@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tvrtko.ursulin@igalia.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®