From: Joe Damato <jdamato@fastly.com>
To: netdev@vger.kernel.org
Cc: mkarsten@uwaterloo.ca, skhawaja@google.com, sdf@fomichev.me,
bjorn@rivosinc.com, amritha.nambiar@intel.com,
sridhar.samudrala@intel.com, willemdebruijn.kernel@gmail.com,
Joe Damato <jdamato@fastly.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Mina Almasry <almasrymina@google.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Daniel Jurgens <danielj@nvidia.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [net-next v5 2/9] netdev-genl: Dump napi_defer_hard_irqs
Date: Wed, 9 Oct 2024 00:54:56 +0000 [thread overview]
Message-ID: <20241009005525.13651-3-jdamato@fastly.com> (raw)
In-Reply-To: <20241009005525.13651-1-jdamato@fastly.com>
Support dumping defer_hard_irqs for a NAPI ID.
Signed-off-by: Joe Damato <jdamato@fastly.com>
---
Documentation/netlink/specs/netdev.yaml | 8 ++++++++
include/uapi/linux/netdev.h | 1 +
net/core/netdev-genl.c | 6 ++++++
tools/include/uapi/linux/netdev.h | 1 +
4 files changed, 16 insertions(+)
diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
index 08412c279297..585e87ec3c16 100644
--- a/Documentation/netlink/specs/netdev.yaml
+++ b/Documentation/netlink/specs/netdev.yaml
@@ -248,6 +248,13 @@ attribute-sets:
threaded mode. If NAPI is not in threaded mode (i.e. uses normal
softirq context), the attribute will be absent.
type: u32
+ -
+ name: defer-hard-irqs
+ doc: The number of consecutive empty polls before IRQ deferral ends
+ and hardware IRQs are re-enabled.
+ type: u32
+ checks:
+ max: s32-max
-
name: queue
attributes:
@@ -636,6 +643,7 @@ operations:
- ifindex
- irq
- pid
+ - defer-hard-irqs
dump:
request:
attributes:
diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h
index 7c308f04e7a0..13dc0b027e86 100644
--- a/include/uapi/linux/netdev.h
+++ b/include/uapi/linux/netdev.h
@@ -122,6 +122,7 @@ enum {
NETDEV_A_NAPI_ID,
NETDEV_A_NAPI_IRQ,
NETDEV_A_NAPI_PID,
+ NETDEV_A_NAPI_DEFER_HARD_IRQS,
__NETDEV_A_NAPI_MAX,
NETDEV_A_NAPI_MAX = (__NETDEV_A_NAPI_MAX - 1)
diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
index 1cb954f2d39e..de9bd76f43f8 100644
--- a/net/core/netdev-genl.c
+++ b/net/core/netdev-genl.c
@@ -161,6 +161,7 @@ static int
netdev_nl_napi_fill_one(struct sk_buff *rsp, struct napi_struct *napi,
const struct genl_info *info)
{
+ u32 napi_defer_hard_irqs;
void *hdr;
pid_t pid;
@@ -189,6 +190,11 @@ netdev_nl_napi_fill_one(struct sk_buff *rsp, struct napi_struct *napi,
goto nla_put_failure;
}
+ napi_defer_hard_irqs = napi_get_defer_hard_irqs(napi);
+ if (nla_put_s32(rsp, NETDEV_A_NAPI_DEFER_HARD_IRQS,
+ napi_defer_hard_irqs))
+ goto nla_put_failure;
+
genlmsg_end(rsp, hdr);
return 0;
diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h
index 7c308f04e7a0..13dc0b027e86 100644
--- a/tools/include/uapi/linux/netdev.h
+++ b/tools/include/uapi/linux/netdev.h
@@ -122,6 +122,7 @@ enum {
NETDEV_A_NAPI_ID,
NETDEV_A_NAPI_IRQ,
NETDEV_A_NAPI_PID,
+ NETDEV_A_NAPI_DEFER_HARD_IRQS,
__NETDEV_A_NAPI_MAX,
NETDEV_A_NAPI_MAX = (__NETDEV_A_NAPI_MAX - 1)
--
2.34.1
next prev parent reply other threads:[~2024-10-09 0:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 0:54 [net-next v5 0/9] Add support for per-NAPI config via netlink Joe Damato
2024-10-09 0:54 ` [net-next v5 1/9] net: napi: Make napi_defer_hard_irqs per-NAPI Joe Damato
2024-10-10 4:10 ` Eric Dumazet
2024-10-09 0:54 ` Joe Damato [this message]
2024-10-10 4:11 ` [net-next v5 2/9] netdev-genl: Dump napi_defer_hard_irqs Eric Dumazet
2024-10-09 0:54 ` [net-next v5 3/9] net: napi: Make gro_flush_timeout per-NAPI Joe Damato
2024-10-10 4:13 ` Eric Dumazet
2024-10-09 0:54 ` [net-next v5 4/9] netdev-genl: Dump gro_flush_timeout Joe Damato
2024-10-10 3:14 ` Jakub Kicinski
2024-10-10 4:34 ` Joe Damato
2024-10-10 4:45 ` Eric Dumazet
2024-10-10 4:59 ` Joe Damato
2024-10-09 0:54 ` [net-next v5 5/9] net: napi: Add napi_config Joe Damato
2024-10-10 4:20 ` Eric Dumazet
2024-10-10 15:59 ` Joe Damato
2024-10-10 16:08 ` Jakub Kicinski
2024-10-09 0:55 ` [net-next v5 6/9] netdev-genl: Support setting per-NAPI config values Joe Damato
2024-10-10 4:24 ` Eric Dumazet
2024-10-10 15:19 ` Jakub Kicinski
2024-10-10 15:30 ` Eric Dumazet
2024-10-10 16:40 ` Joe Damato
2024-10-11 17:19 ` Eric Dumazet
2024-10-11 17:50 ` Joe Damato
2024-10-09 0:55 ` [net-next v5 7/9] bnxt: Add support for persistent NAPI config Joe Damato
2024-10-10 4:25 ` Eric Dumazet
2024-10-09 0:55 ` [net-next v5 8/9] mlx5: " Joe Damato
2024-10-10 4:26 ` Eric Dumazet
2024-10-09 0:55 ` [net-next v5 9/9] mlx4: Add support for persistent NAPI config to RX CQs Joe Damato
2024-10-10 4:28 ` Eric Dumazet
2024-10-10 16:07 ` Joe Damato
2024-10-10 3:17 ` [net-next v5 0/9] Add support for per-NAPI config via netlink Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009005525.13651-3-jdamato@fastly.com \
--to=jdamato@fastly.com \
--cc=almasrymina@google.com \
--cc=amritha.nambiar@intel.com \
--cc=bjorn@rivosinc.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=skhawaja@google.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®