From: Peter Zijlstra <peterz@infradead.org>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: Hariom Panthi <hariom1.p@samsung.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"bsegall@google.com" <bsegall@google.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"vschneid@redhat.com" <vschneid@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rohit Thapliyal <r.thapliyal@samsung.com>
Subject: Re: [PATCH 1/1] sched.h: silent false ATOMIC_SLEEP warning from cond_resched
Date: Thu, 10 Oct 2024 12:39:21 +0200 [thread overview]
Message-ID: <20241010103921.GI14587@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241010100940epcms5p2f7463014f1e1cb1b27a8da300b804e08@epcms5p2>
On Thu, Oct 10, 2024 at 03:39:40PM +0530, Maninder Singh wrote:
> Hi,
>
> > On Thu, Oct 10, 2024 at 08:56:53AM +0530, Hariom Panthi wrote:
> > > In case of (CONFIG_PREEMPTION && !CONFIG_PREEMPT_DYNAMIC),
> > > cond_reched() is not sleeping.
> > >
> > > Thus remove __might_resched in that cases.
> >
> > *why* ? It's still a valid site to do the atomic_sleep testing, no?
>
> In our case there was a call to vunmap_pmd_range from __do_softirq,
> and vunmap_pmd_range is not actually sleeping call, but because of
> cond_resched it was giving warning with DEBUG_ATOMIC_SLEEP.
>
> and cond_resched in case of CONFIG_PREEMPTION is empty function with below change:
By still having that warning we helpfully tell you your code is broken
for that other .config. Code should be good irrespective of the .config
used, right?
next prev parent reply other threads:[~2024-10-10 10:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241010032751epcas5p1154533995a184be3fea39325c4d33740@epcas5p1.samsung.com>
2024-10-10 3:26 ` Hariom Panthi
2024-10-10 9:22 ` Peter Zijlstra
[not found] ` <CGME20241010032751epcas5p1154533995a184be3fea39325c4d33740@epcms5p2>
2024-10-10 10:09 ` Maninder Singh
2024-10-10 10:39 ` Peter Zijlstra [this message]
[not found] ` <CGME20241010032751epcas5p1154533995a184be3fea39325c4d33740@epcms5p4>
2024-10-10 11:08 ` Maninder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010103921.GI14587@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=hariom1.p@samsung.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=r.thapliyal@samsung.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®