mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Bert Karwatzki <spasswolf@web.de>, Felix Fietkau <nbd@nbd.name>,
	Kalle Valo <kvalo@kernel.org>, Sasha Levin <sashal@kernel.org>,
	lorenzo@kernel.org, ryder.lee@mediatek.com,
	matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
	sean.wang@mediatek.com, deren.wu@mediatek.com,
	mingyen.hsieh@mediatek.com, johannes.berg@intel.com,
	hao.zhang@mediatek.com, emmanuel.grumbach@intel.com,
	leon.yen@mediatek.com, linux-wireless@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: [PATCH AUTOSEL 6.6 15/20] wifi: mt76: mt7921: fix NULL pointer access in mt7921_ipv6_addr_change
Date: Sat, 12 Oct 2024 07:26:47 -0400	[thread overview]
Message-ID: <20241012112715.1763241-15-sashal@kernel.org> (raw)
In-Reply-To: <20241012112715.1763241-1-sashal@kernel.org>

From: Bert Karwatzki <spasswolf@web.de>

[ Upstream commit 479ffee68d59c599f8aed8fa2dcc8e13e7bd13c3 ]

When disabling wifi mt7921_ipv6_addr_change() is called as a notifier.
At this point mvif->phy is already NULL so we cannot use it here.

Signed-off-by: Bert Karwatzki <spasswolf@web.de>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20240812104542.80760-1-spasswolf@web.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/net/wireless/mediatek/mt76/mt7921/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
index d8851cb5f400b..da17a29a4ce57 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
@@ -1095,7 +1095,7 @@ static void mt7921_ipv6_addr_change(struct ieee80211_hw *hw,
 				    struct inet6_dev *idev)
 {
 	struct mt792x_vif *mvif = (struct mt792x_vif *)vif->drv_priv;
-	struct mt792x_dev *dev = mvif->phy->dev;
+	struct mt792x_dev *dev = mt792x_hw_dev(hw);
 	struct inet6_ifaddr *ifa;
 	struct in6_addr ns_addrs[IEEE80211_BSS_ARP_ADDR_LIST_LEN];
 	struct sk_buff *skb;
-- 
2.43.0


  parent reply	other threads:[~2024-10-12 11:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-12 11:26 [PATCH AUTOSEL 6.6 01/20] ksmbd: override fsids for share path check Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 02/20] ksmbd: override fsids for smb2_query_info() Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 03/20] usbnet: ipheth: race between ipheth_close and error handling Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 04/20] usbnet: ipheth: remove extraneous rx URB length check Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 05/20] usbnet: ipheth: drop RX URBs with no payload Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 06/20] usbnet: ipheth: do not stop RX on failing RX callback Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 07/20] usbnet: ipheth: fix carrier detection in modes 1 and 4 Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 08/20] kbuild: rust: skip -fmin-function-alignment in bindgen flags Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 09/20] rust: add intrinsics to fix `-Os` builds Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 10/20] net: ethernet: use ip_hdrlen() instead of bit shift Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 11/20] drm: panel-orientation-quirks: Add quirk for Ayn Loki Zero Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 12/20] drm: panel-orientation-quirks: Add quirk for Ayn Loki Max Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 13/20] net: phy: vitesse: repair vsc73xx autonegotiation Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 14/20] powerpc/mm: Fix boot warning with hugepages and CONFIG_DEBUG_VIRTUAL Sasha Levin
2024-10-12 11:26 ` Sasha Levin [this message]
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 16/20] Squashfs: sanity check symbolic link size Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 17/20] of/irq: Prevent device address out-of-bounds read in interrupt map walk Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 18/20] lib/generic-radix-tree.c: Fix rare race in __genradix_ptr_alloc() Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 19/20] net: hns3: use correct release function during uninitialization Sasha Levin
2024-10-12 11:26 ` [PATCH AUTOSEL 6.6 20/20] btrfs: update target inode's ctime on unlink Sasha Levin
  -- strict thread matches above, loose matches on Subject: below --
2024-08-23 14:02 [PATCH AUTOSEL 6.6 01/20] ksmbd: override fsids for share path check Sasha Levin
2024-08-23 14:02 ` [PATCH AUTOSEL 6.6 15/20] wifi: mt76: mt7921: fix NULL pointer access in mt7921_ipv6_addr_change Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241012112715.1763241-15-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=deren.wu@mediatek.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=hao.zhang@mediatek.com \
    --cc=johannes.berg@intel.com \
    --cc=kvalo@kernel.org \
    --cc=leon.yen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mingyen.hsieh@mediatek.com \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=spasswolf@web.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®