From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CB5EB1B978; Sat, 12 Oct 2024 20:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728766057; cv=none; b=fMtVwkHYjuF4M+EOaO0wZqKmevFbnuvlQTUBeqUNc9KCL9DCaalxCCYqzLQY7+N9qkA5W001SttuDhmIB8fcBWJ0tO1922fHIGeTb3kJr27o5oU0Xd7JU5VSMo8OE9Ju40ijtpE0J2yS3A6HtI595T5KepQRG3riGzzNtctcPc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728766057; c=relaxed/simple; bh=mG/SuA5G5n09t5fbYvh9yhKdsdhTUDrEYP5oNSfNjic=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pJEG3ev7snWu6HZiaP+PJxIVxyJsv8QfrN4OoErgEVPN9/ze9MuRmkZ2k7Ggm4CRLHQJdhmX4BwLGIuwkpG2Yw7HsQzJ4zVjGOkypBWEFsNVfQOl3SC6GLaBKJTG6HvSY10iL/KZxtmeqpO4CNWu856ZAjRlDTg3k1brVLHGD78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 544AADA7; Sat, 12 Oct 2024 13:48:03 -0700 (PDT) Received: from e132581.cambridge.arm.com (e132581.arm.com [10.2.76.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 33F883F5A1; Sat, 12 Oct 2024 13:47:32 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Masami Hiramatsu , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v3 0/3] perf probe: Improve logs for long name string Date: Sat, 12 Oct 2024 21:47:22 +0100 Message-Id: <20241012204725.928794-1-leo.yan@arm.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The series [1] tries to use hashed symbol names for event names. This can avoid failures due to long symbol names. Somehow, it is preferred to specify a distinct event name when adding a probe. This series follows up on the comment to improve the logs for long event strings. [1] https://lore.kernel.org/linux-perf-users/20241010234818.ab279974ef597f02b61ab850@kernel.org/T/ Changes from v2: - Printed a more abstract syntax "EVENT=PROBEDEF" in log. - Amended warning for adding suffix failure. Changes from v1: - Used a patch to add MAX_EVENT_NAME_LEN macro. - Refined log for long event name failure to replace hashed event name (Masami). Leo Yan (3): perf probe: Use the MAX_EVENT_NAME_LEN macro perf probe: Check group string length perf probe: Improve log for long event name failure tools/perf/util/probe-event.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) -- 2.25.1